linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Shuah Khan <shuah@kernel.org>, Nhat Pham <nphamcs@gmail.com>,
	Johannes Weiner <hannes@cmpxchg.org>
Cc: linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] selftests: cachestat: properly link in librt
Date: Tue, 15 Aug 2023 16:56:10 +0100	[thread overview]
Message-ID: <20230815155612.2535947-2-andre.przywara@arm.com> (raw)
In-Reply-To: <20230815155612.2535947-1-andre.przywara@arm.com>

Libraries should be listed last on the compiler's command line, so that
the linker can look for and find still unresolved symbols. The librt
library, required for the shm_* functions, was announced using CFLAGS,
which puts the library *before* the source files, and fails compilation
on my system:
======================
gcc -isystem /src/linux-selftests/usr/include -Wall -lrt test_cachestat.c
  -o /src/linux-selftests/kselftest/cachestat/test_cachestat
/usr/bin/ld: /tmp/cceQWO3u.o: in function `test_cachestat_shmem':
test_cachestat.c:(.text+0x890): undefined reference to `shm_open'
/usr/bin/ld: test_cachestat.c:(.text+0x99c): undefined reference to `shm_unlink'
collect2: error: ld returned 1 exit status
make[4]: *** [../lib.mk:181: /src/linux-selftests/kselftest/cachestat/test_cachestat] Error 1
======================

Announce the library using the LDLIBS variable, which ensures the proper
ordering on the command line.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 tools/testing/selftests/cachestat/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/cachestat/Makefile b/tools/testing/selftests/cachestat/Makefile
index fca73aaa7d141..778b54ebb0364 100644
--- a/tools/testing/selftests/cachestat/Makefile
+++ b/tools/testing/selftests/cachestat/Makefile
@@ -3,6 +3,6 @@ TEST_GEN_PROGS := test_cachestat
 
 CFLAGS += $(KHDR_INCLUDES)
 CFLAGS += -Wall
-CFLAGS += -lrt
+LDLIBS += -lrt
 
 include ../lib.mk
-- 
2.25.1



  reply	other threads:[~2023-08-15 15:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-15 15:56 [PATCH 0/3] selftests: cachestat: fix build and run on older kernels Andre Przywara
2023-08-15 15:56 ` Andre Przywara [this message]
2023-08-16 17:14   ` [PATCH 1/3] selftests: cachestat: properly link in librt Shuah Khan
2023-08-15 15:56 ` [PATCH 2/3] selftests: cachestat: use proper syscall number macro Andre Przywara
2023-08-15 18:09   ` Nhat Pham
2023-08-16 17:15   ` Shuah Khan
2023-08-15 15:56 ` [PATCH 3/3] selftests: cachestat: test for cachestat availability Andre Przywara
2023-08-15 23:25   ` Nhat Pham
2023-08-16  9:36     ` Andre Przywara
2023-08-16 17:11   ` Shuah Khan
2023-08-17 14:47     ` Andre Przywara
2023-08-17 18:01       ` Shuah Khan
2023-08-15 18:07 ` [PATCH 0/3] selftests: cachestat: fix build and run on older kernels Nhat Pham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230815155612.2535947-2-andre.przywara@arm.com \
    --to=andre.przywara@arm.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nphamcs@gmail.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox