From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 938DDC04A6A for ; Tue, 15 Aug 2023 15:56:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C7858D0001; Tue, 15 Aug 2023 11:56:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 850E5940020; Tue, 15 Aug 2023 11:56:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F10F8D0001; Tue, 15 Aug 2023 11:56:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 58663940020 for ; Tue, 15 Aug 2023 11:56:34 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 19CC9A0A13 for ; Tue, 15 Aug 2023 15:56:34 +0000 (UTC) X-FDA: 81126791508.15.F9D26C6 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf05.hostedemail.com (Postfix) with ESMTP id E62F4100019 for ; Tue, 15 Aug 2023 15:56:30 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf05.hostedemail.com: domain of andre.przywara@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=andre.przywara@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692114991; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=GMvkEZgwhhmv4VQRxsAkFb8OppYzF3rA+AfaL3F7fgc=; b=FiUrAwVqJIKUrdtnJEGTSuGP3+0ZAgbzzIS86jGXyIxdkyoVquygrKj0qA9d3jO1udmg2t 5qq1laNdDgtfhwbz3nH6kYWs2v5oX57rSvqQZ5LvL4jUZ6zBKCQk2z4OKWF3dJrPD2QZXz kSHC3kyIEGHVFQwQJGYHAwrzt4PCjm0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf05.hostedemail.com: domain of andre.przywara@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=andre.przywara@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692114991; a=rsa-sha256; cv=none; b=Y73UacYfo11hNPPxK1HbeuxSZtMFiCqs4xkgiqXswylP+nWYZJHsjGC1YfFyh6EZnr0qBZ +1/K2kovflMqyf5eiFF+H321MxXxQTEDzIg2aA1frqPWviDy4F1fnKFJOG2rmppO3YT8UC PGiLZHuOKXNTT31qHS/9UpHzNirVdLY= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 231801063; Tue, 15 Aug 2023 08:57:12 -0700 (PDT) Received: from donnerap.arm.com (donnerap.manchester.arm.com [10.32.100.58]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C6E533F6C4; Tue, 15 Aug 2023 08:56:28 -0700 (PDT) From: Andre Przywara To: Shuah Khan , Nhat Pham , Johannes Weiner Cc: linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/3] selftests: cachestat: fix build and run on older kernels Date: Tue, 15 Aug 2023 16:56:09 +0100 Message-Id: <20230815155612.2535947-1-andre.przywara@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: E62F4100019 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 7wpcrooapjubukg5kokgokhbwogfco5b X-HE-Tag: 1692114990-51297 X-HE-Meta: U2FsdGVkX1+7MgCJBX2FVM1L06HGwBSvMpxgkHcMgcDfCw72XVFwb2A3iOpK/YbJIob6B1y6DpB7IzaNj2ibWwQKSZoUnj4F+lVxZ4wvq9Ua/G/IT3D8mp6IZBsLRuG3YIuETCnrTtBu3X2KnWqUGtkQLJDgK/HXm+sxFGsgX0CesDTiNYAA690b28qjzQj+pWJpar60a2qooa1Ab6zGtELOk0xd2WPJf0WEGA7y83udODFnBqgRzbP0FnXcriIr5/FVQT9xSu7vEIPcZMi25PRlHN10puHexEgEIOKdCzxXe7jdoHQK/ZKJLR3f3EbzqlKSJhrSrw5kj/p6urJRLk8J92sJjjW2rizjo/FWJ+DFWRfh0fhW8ww+2hWbqrIy3nyL8g0OXtitDLenRU2pkNi4qnpqYn4OJqpEWzpuXlaDLb6bJQxDEJTeejLuDcYI7DV+VgoHrkSdAfy+LBgrarGULs5YeGmTzv39FRMTAKryj/YWZ7G5kcL/2Hx/sLh5/CabwLUdPHuScveP/vJD4kDBSbNsUuCMXW9osBLaCu8xrZCtcHOv2z6jNaWIji1ZqA0LkOPkmyBNu2OcNVXBrPHahvVPHUDoMuCCCwsD1CHM0qxI/8dl30ltqLwlQpV/1i0BX4Vq1Ucau86142+O/l7SxnnkTxwduknSwFu1P7isnePSUAbVSuD03VSIFlfRCkTAUvsz4bLKBUKYUvC/XpzReA7US1nCqzymDR5gWeSFqoP0lxDWmmPrPM+eAAHL31QC2lyIUIy+A0Vu8jacB5ppr0CZpjBW2ZJGjebR1Rp7AgHKNQJuIxA80Sqood+iW0mlbSOmsEGnH4nxKHhcXJvswjtNNBZ6RYQjPXRf76QoqBh/CkaibHfGgF2dMd72O/l/kSHQqveSx+hV2iaA/9fvDkkEdZ71Z8RCZWIJRmM8laoQSSReCoRI7N05MWj1MECZHVMUF1XCZOkzOEf LLlbOUDL uBwyVvUT7PbFgHvdQu41AL7FeTE5VDpjG0NNFdiynj86MO8ujA51oG78xUhUAndTo3DoDlfnVZPBTPqZsFkY0OLeKQ5WKTwZhLzFd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I ran all kernel selftests on some test machine, and stumbled upon cachestat failing (among others). Those patches fix the cachestat test compilation and run on older kernels. Also I found that the but-last test (on a normal file) fails when run on a tmpfs mounted directory, as it happens on an initramfs-only system, or when the current directory happens to be /dev/shm or /tmp: # Create/open tmpfilecachestat # Cachestat call returned 0 # Using cachestat: Cached: 4, Dirty: 4, Writeback: 0, Evicted: 0, Recently Evicted: 0 # Cachestat call (after fsync) returned 0 # Using cachestat: Cached: 4, Dirty: 4, Writeback: 0, Evicted: 0, Recently Evicted: 0 # Number of dirty should be zero after fsync. not ok 6 cachestat fails with normal file That same test binary succeeds on the same machine right afterwards if the current directory is changed to an ext4 filesystem. I don't really know if this is expected, and whether we should try to figure out if the test file lives on a tmpfs filesystem, or whether the test itself is not strict enough, and requires more "flushing" (drop_caches?) to cover tmpfs directories as well. Any ideas how to fix this would be appreciated. Cheers, Andre Andre Przywara (3): selftests: cachestat: properly link in librt selftests: cachestat: use proper syscall number macro selftests: cachestat: test for cachestat availability tools/testing/selftests/cachestat/Makefile | 2 +- .../selftests/cachestat/test_cachestat.c | 29 +++++++++++++++---- 2 files changed, 25 insertions(+), 6 deletions(-) -- 2.25.1