linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Shuah Khan <shuah@kernel.org>, Nhat Pham <nphamcs@gmail.com>,
	Johannes Weiner <hannes@cmpxchg.org>
Cc: linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] selftests: cachestat: fix build and run on older kernels
Date: Tue, 15 Aug 2023 16:56:09 +0100	[thread overview]
Message-ID: <20230815155612.2535947-1-andre.przywara@arm.com> (raw)

I ran all kernel selftests on some test machine, and stumbled upon
cachestat failing (among others).
Those patches fix the cachestat test compilation and run on older
kernels.

Also I found that the but-last test (on a normal file) fails when run on
a tmpfs mounted directory, as it happens on an initramfs-only system, or
when the current directory happens to be /dev/shm or /tmp:
# Create/open tmpfilecachestat
# Cachestat call returned 0
# Using cachestat: Cached: 4, Dirty: 4, Writeback: 0, Evicted: 0, Recently Evicted: 0
# Cachestat call (after fsync) returned 0
# Using cachestat: Cached: 4, Dirty: 4, Writeback: 0, Evicted: 0, Recently Evicted: 0
# Number of dirty should be zero after fsync.
not ok 6 cachestat fails with normal file

That same test binary succeeds on the same machine right afterwards if
the current directory is changed to an ext4 filesystem.

I don't really know if this is expected, and whether we should try to
figure out if the test file lives on a tmpfs filesystem, or whether the
test itself is not strict enough, and requires more "flushing"
(drop_caches?) to cover tmpfs directories as well.

Any ideas how to fix this would be appreciated.

Cheers,
Andre

Andre Przywara (3):
  selftests: cachestat: properly link in librt
  selftests: cachestat: use proper syscall number macro
  selftests: cachestat: test for cachestat availability

 tools/testing/selftests/cachestat/Makefile    |  2 +-
 .../selftests/cachestat/test_cachestat.c      | 29 +++++++++++++++----
 2 files changed, 25 insertions(+), 6 deletions(-)

-- 
2.25.1



             reply	other threads:[~2023-08-15 15:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-15 15:56 Andre Przywara [this message]
2023-08-15 15:56 ` [PATCH 1/3] selftests: cachestat: properly link in librt Andre Przywara
2023-08-16 17:14   ` Shuah Khan
2023-08-15 15:56 ` [PATCH 2/3] selftests: cachestat: use proper syscall number macro Andre Przywara
2023-08-15 18:09   ` Nhat Pham
2023-08-16 17:15   ` Shuah Khan
2023-08-15 15:56 ` [PATCH 3/3] selftests: cachestat: test for cachestat availability Andre Przywara
2023-08-15 23:25   ` Nhat Pham
2023-08-16  9:36     ` Andre Przywara
2023-08-16 17:11   ` Shuah Khan
2023-08-17 14:47     ` Andre Przywara
2023-08-17 18:01       ` Shuah Khan
2023-08-15 18:07 ` [PATCH 0/3] selftests: cachestat: fix build and run on older kernels Nhat Pham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230815155612.2535947-1-andre.przywara@arm.com \
    --to=andre.przywara@arm.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nphamcs@gmail.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox