From: Oleg Nesterov <oleg@redhat.com>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
brauner@kernel.org, ebiederm@xmission.com, david@redhat.com,
akpm@linux-foundation.org, linux-mm@kvack.org, koct9i@gmail.com,
dave@stgolabs.net
Subject: Re: [PATCH v2] kernel/fork: stop playing lockless games for exe_file replacement
Date: Mon, 14 Aug 2023 20:11:15 +0200 [thread overview]
Message-ID: <20230814181114.GD17738@redhat.com> (raw)
In-Reply-To: <20230814172140.1777161-1-mjguzik@gmail.com>
On 08/14, Mateusz Guzik wrote:
>
> However, fe69d560b5bd ("kernel/fork: always deny write access to current
> MM exe_file") added a semaphore up/down cycle to synchronize the state
> of exe_file against fork, defeating the point of the original change.
Agreed,
> Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
> ---
> fs/exec.c | 4 ++--
> kernel/fork.c | 22 +++++++++-------------
> 2 files changed, 11 insertions(+), 15 deletions(-)
Acked-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2023-08-14 18:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 17:21 Mateusz Guzik
2023-08-14 18:11 ` Oleg Nesterov [this message]
2023-08-15 7:29 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230814181114.GD17738@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=ebiederm@xmission.com \
--cc=koct9i@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mjguzik@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox