[stable:linux-5.4.y 3985/9416] include/linux/nodemask.h:380:20: error: comparison of unsigned expression in '>= 0' is always true

[kernel test robot <lkp@intel.com>]

Hi Christophe,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.4.y
head:   4b4223f7d26d90087de52c8649e42ad8fff2e90a
commit: 73bdb2359dbc260364141c83dd1e1a5497f29d3d [3985/9416] nodemask.h: fix compilation error with GCC12
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20230812/202308121349.5b4LeHk3-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230812/202308121349.5b4LeHk3-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308121349.5b4LeHk3-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/mmzone.h:17,
                    from include/linux/gfp.h:6,
                    from include/linux/mm.h:10,
                    from arch/alpha/mm/numa.c:12:
   arch/alpha/mm/numa.c: In function 'paging_init':
>> include/linux/nodemask.h:380:20: error: comparison of unsigned expression in '>= 0' is always true [-Werror=type-limits]
     380 |              (node >= 0) && (node) < MAX_NUMNODES;                  \
         |                    ^~
   include/linux/nodemask.h:433:9: note: in expansion of macro 'for_each_node_mask'
     433 |         for_each_node_mask((__node), node_states[__state])
         |         ^~~~~~~~~~~~~~~~~~
   include/linux/nodemask.h:513:36: note: in expansion of macro 'for_each_node_state'
     513 | #define for_each_online_node(node) for_each_node_state(node, N_ONLINE)
         |                                    ^~~~~~~~~~~~~~~~~~~
   arch/alpha/mm/numa.c:218:9: note: in expansion of macro 'for_each_online_node'
     218 |         for_each_online_node(nid) {
         |         ^~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors


vim +380 include/linux/nodemask.h

   376	
   377	#if MAX_NUMNODES > 1
   378	#define for_each_node_mask(node, mask)				    \
   379		for ((node) = first_node(mask);				    \
 > 380		     (node >= 0) && (node) < MAX_NUMNODES;		    \
   381		     (node) = next_node((node), (mask)))
   382	#else /* MAX_NUMNODES == 1 */
   383	#define for_each_node_mask(node, mask)                                  \
   384		for ((node) = 0; (node) < 1 && !nodes_empty(mask); (node)++)
   385	#endif /* MAX_NUMNODES */
   386	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki