From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AE69C0015E for ; Fri, 11 Aug 2023 11:00:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 747AF900004; Fri, 11 Aug 2023 07:00:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F7D4900002; Fri, 11 Aug 2023 07:00:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C051900004; Fri, 11 Aug 2023 07:00:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4CD28900002 for ; Fri, 11 Aug 2023 07:00:51 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DD6E014112E for ; Fri, 11 Aug 2023 11:00:50 +0000 (UTC) X-FDA: 81111531060.10.50CD8F8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id EE6A8C0033 for ; Fri, 11 Aug 2023 11:00:48 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=b7LZy3eR; spf=pass (imf10.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691751649; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tBz+ziF4xh2x87ONfleqPfO+iN52Mb/lh3DBCE6jvQo=; b=0MYRA8L/ZbhaV9lfQyRA5TYcUCKHP76DAUiA90C5hotvoVxEwLkeLiJci86/cIV3DWVL8Q yEiaZ5v5CdjHXtZzHBwCJOhZMwiwgQi1xvxLloVBatQ1tC0XpM04MZsSbzERtaKwLssDtc kJbkxbPC8yUZEEPF8GrSK5Wfnnscjqk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691751649; a=rsa-sha256; cv=none; b=eXxQ9n8o9o9dTxDjlAgXvZW+XVl30rVUfZ6jGYoXNk/EvGXNus+GFi1yN9hEXnHTtuMHDw MXbhiZpnRL8h2kkskHMPS05d4xXIakqJoH0mUKacklqQTTuDTQ+6EgCDLSoaOf5luxTbrF PwfIp/eSviAcExYjw/QSevzyIRLGEDU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=b7LZy3eR; spf=pass (imf10.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 02CBA64E9C; Fri, 11 Aug 2023 11:00:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41195C433C8; Fri, 11 Aug 2023 11:00:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691751647; bh=pquqTiNtyapvxvGJ5Cb6d1ymD8+JCygJyZyKVnKO18Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b7LZy3eRjrFAsVz9BJ2/3jM2ewd0yXUnnQyb6GUADTmwJv2tNpua9PEws+1IAtt6W ism5HggLXK0dKzp6o+YtYODoXMfrxXgsyPk/RwTpZur+Y+52CLEujMQoBV3Lff1Fn6 UnJ1/B+7QeqsYJttKyEUTKLRLARrrTTep1dh38urUnwbzHI5AHIpRnJf1WRNuJA3v9 c5BG6v1qO40nIj1ZDkzVThpu4aNhENCJTiA5WsA92L81KCMKGrbPK5ypKcQIdOKjX0 jA5sLNZqDD/yUVdDYwYcLucQJ0zPxZYKrDpavYhv82R7JuykqFG63yMjvheKi+CpN7 6UJ7p2tu9Ry7Q== From: Christian Brauner To: Hugh Dickins Cc: Christian Brauner , Andrew Morton , Oleksandr Tymoshenko , Carlos Maiolino , Jeff Layton , Chuck Lever , Jan Kara , Miklos Szeredi , Daniel Xu , Chris Down , Tejun Heo , Greg Kroah-Hartman , Matthew Wilcox , Christoph Hellwig , Pete Zaitcev , Helge Deller , Topi Miettinen , Yu Kuai , "Darrick J. Wong" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: (subset) [PATCH vfs.tmpfs v2 4/5] tmpfs: trivial support for direct IO Date: Fri, 11 Aug 2023 13:00:33 +0200 Message-Id: <20230811-halde-gesiegt-cea0d6a56411@brauner> X-Mailer: git-send-email 2.34.1 In-Reply-To: <6f2742-6f1f-cae9-7c5b-ed20fc53215@google.com> References: <7c12819-9b94-d56-ff88-35623aa34180@google.com> <6f2742-6f1f-cae9-7c5b-ed20fc53215@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1349; i=brauner@kernel.org; h=from:subject:message-id; bh=pquqTiNtyapvxvGJ5Cb6d1ymD8+JCygJyZyKVnKO18Y=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaRcEzk/JTpXwu5DzbXms7tXWBa0zJklvuyfwUR1i0LHbwVt 3x7s7ihlYRDjYpAVU2RxaDcJl1vOU7HZKFMDZg4rE8gQBi5OAZjIZ0lGhkP6j/aZufH83rzeWOr4Yh npjUU1n8+KcIpt3GR6dGnjvq0M/+vfObsKndz0+On8SC55Hb6/bh2Tb9XpMvc285w+x3Ivhx0A X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: EE6A8C0033 X-Rspam-User: X-Stat-Signature: u5r77y47xd7o978c5ftxhkykexz7rqeh X-Rspamd-Server: rspam03 X-HE-Tag: 1691751648-631802 X-HE-Meta: U2FsdGVkX189QLTqSs4rbc558gkcw10dBoFC2TZnZk7jjSX0W/vglFcrn40Rbtqq9LHrVSyiKL0pqvwJCP+anQ+bECvzMdt99bBpU4GFfvCTnrNiQRtvOScGy4rcy5g03QX4kdREvRpLomycxQ+1NZuDqN64wh3+P405WVgmHUqW1HA0XuSeit7qzlynRhyb2//ZdSuKl/uCXJi+y6i0nvSMwoLr7OJ4N4jdSRIlV1gy1XgtoV2uoGdmUXbJ8iXHOTETJPLCoYsi3uFhf6iDT8Mg6gFoIG9xkaeHZe8XCiMG+1bybZgsDwJW98Au+rIwvpykyw7ZgUDKuMlAuE0ZJx00scctHj/8Dezr3PNiDIjEJtxu9a9u6/3oIq55Vxmk+mHtheqjHAZ+P9xjXx42TdIWtzZZwktZ1+xMe3Dg3lg2OR+nxk3upKXXb2PHFc/n0AGMT+aj/yuqNAqBSR5WdcBHxFrcyA6IhdUdvUF1wJJIDkrkvFFEEEn6eihwUVm+Hbl9VOtk9CxHGYGPDw6Co233fVlgmtUJoKqvmpcoOPovo5ey0sFFk88yyU9m6K5WVAW3yFyqupYRkpiup9ZnNCUxgY2sZ2k9/mlgywKZmzkMvwkBjdLIGlQjHwxH7vx0MmQHL8h7RJtfi66fncMIu263rCaXt1FTjDtT5FAY1YiDpiI4uDLTt3t/K+yTF4LKsf8skYHHqrnyZEucmYu+R4cKz3gx6sqhCUv9Qo8szJL/itTl6131VfXejQfYZdWEzvkSCfnCOFJ1t9jus98TUq3EQRejiA/bYtLAU+Tr+OeKRd91j2V1cDoY4zp51yl87UCTUbyRrPKccZ4ZwF7l2fqawguJwnjs1hSOik1ekLlhMXsNLrVvhCUtFbJUFiN1uOcrKbTw/IebZz3zNgQxkJq8AxrrOwbvp6KTQytFa+dAULePE/gAZprEMmB3N0tltnsdcX127UsPXQ23HtT 4c/te1Qk ueO+7iWGJdK1W3+SUi1P4MjTFSTz8ypjEuCsYYSGADKwE4B3VSPpMyNAmQAOqC0nHrjcdhGQvUyYBG6qeyXBzw2iROMPHu9nmIz1pwXHogo1f1/pvNaTzZryAHySLfy3AuQ9HqN2mT24S/i6Ia7Mj+wJUkHUWtSmr3/lKzfYXr4wNgL7dI/5wyA8s0sSwInO5BO13Pd0lkTtNrUgGqFUkp8mtARF9qQ5cs/qUUkQt+mWmtwOojZISgbl/tSp6eKjb4TfTL1TdWuKEyXdYScAhQ05Gsa+z8YJCoMyf8yAfrX9WNG2p2DEb1w6Nfza4gA3d/FBHlIvdtt5nxNyxvJP7qeetUJ+oHorFdPY7jqOL6cZj9lGWqBYkezFQ/g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 10 Aug 2023 23:27:07 -0700, Hugh Dickins wrote: > Depending upon your philosophical viewpoint, either tmpfs always does > direct IO, or it cannot ever do direct IO; but whichever, if tmpfs is to > stand in for a more sophisticated filesystem, it can be helpful for tmpfs > to support O_DIRECT. So, give tmpfs a shmem_file_open() method, to set > the FMODE_CAN_ODIRECT flag: then unchanged shmem_file_read_iter() and new > shmem_file_write_iter() do the work (without any shmem_direct_IO() stub). > > [...] I've dropped the previous version and applied this one. Thank! --- Applied to the vfs.tmpfs branch of the vfs/vfs.git tree. Patches in the vfs.tmpfs branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.tmpfs [4/5] tmpfs: trivial support for direct IO https://git.kernel.org/vfs/vfs/c/6b55d273ec5b