From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0867BC04A6A for ; Thu, 10 Aug 2023 22:16:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A3746B0071; Thu, 10 Aug 2023 18:16:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 753846B0072; Thu, 10 Aug 2023 18:16:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A5B56B0074; Thu, 10 Aug 2023 18:16:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 46B1D6B0071 for ; Thu, 10 Aug 2023 18:16:06 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0F6F2C0160 for ; Thu, 10 Aug 2023 22:16:06 +0000 (UTC) X-FDA: 81109603932.12.207BD81 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf30.hostedemail.com (Postfix) with ESMTP id 9A6BF80019 for ; Thu, 10 Aug 2023 22:16:02 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-03-30 header.b=IztieRPh; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=R+doHfgW; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf30.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691705762; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KqRIK6G9+J3mTv3WVDlirp2QxzxiyMWo7QNMhWsry9Y=; b=zF6KgmMKHNXJBcEhr/dPA3Wpa86CCvMcDoK/wyi8DWrqSZw2/jnkRMIqIASl/9D8O3MIxC l856zI4vfrIqKJ3Fo3/NsD6ARIWiwoUibtPLVGTpxcg+TIJOHxCJ9VaRnqckHHR1Veh1T5 +pdCNWlDGKujEieR9JNghzi7EBaXTXA= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-03-30 header.b=IztieRPh; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=R+doHfgW; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf30.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1691705762; a=rsa-sha256; cv=pass; b=dt0j0sp15Vg8a/15KUzGTifHYguEO6LxFdiJgN4i9+a3AiqKTXgY2bnVg/HDF8aG1XAPHC dBKRS+bw5B/Y0Rk1XvpYcnowGUI0384ESGnJ3edXrnemk8gG7Wqxe4cQxtm4RJzrLUOeze mNdksyBjxbrnvCMWq14UKTBNkOt0YLM= Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37AL4wdA028028; Thu, 10 Aug 2023 22:15:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2023-03-30; bh=KqRIK6G9+J3mTv3WVDlirp2QxzxiyMWo7QNMhWsry9Y=; b=IztieRPhse27QoadtsIN+FuhAZLcjyICxEVQInGcw9zeJRvlqxtkILhRWlNK5D86+AX8 Cfe0uCV/xQVz1qEH3A11pxkzxv4j9DIGMwTdiWXku1xgi9zk9nkPDbVWd+OiioomN+FT E8X+OqzMKYKBd37pPAmyfGaVUbugm/qtux3KvES4tWZACxYrA3JeSkfmSMt24eUc7Pn6 zk4+EVtHKNOUxOI0v5QvGAGjwM44nzKPnqbwWj6c4/XeUfP0q/Q6xY6SGyy7gLEx0V7S Jfk2p+4kZ5D+6e7ntkmAQeT2R7J36doNtB2kOO4/rU+zCW1JQl0JL5ItWggkTyKZSyxW bQ== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3s9cuev54f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Aug 2023 22:15:59 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 37ALkLqU002943; Thu, 10 Aug 2023 22:15:58 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2102.outbound.protection.outlook.com [104.47.55.102]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3s9cv9cvg8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Aug 2023 22:15:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c9H1qQSlKJQPJLx4LJZ7AqU762ngD8enaPsE/U4NQSI2v1b9MgOMh3i7s/j6akarW3DEWN+jkFdsf8jFtNr2w86NOvmHdMRaoSldklFC9qpas1Wl9c1Nu/fHYHDmAQ2k/FeAFw5ehJKt8bXv0wsLgC6yVUCBJJdZiDBvu3yYaKPM0JG6Bf9oC+ekA61KQ6BuD+/SJ54X7fAZye1nDLfIylx/ehHimiGq0G1SRVmoi4AiAmFc3VAQrG2m29KeYqzyCXEgYvmyZdlmZ7IpJUG2AHx3I6pmLrCtdaLBjc/9y+wj6CPeq5qV58a605GqIqccPpn8JY50i1adlF/mDD7uqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KqRIK6G9+J3mTv3WVDlirp2QxzxiyMWo7QNMhWsry9Y=; b=IE8Ic0DYbbkBlwPa8Pfsmay71G2sBFIkomPc5nn0FDjX+/EDclWY1APAQCrRyYU0M7/HTORFhFscJF7dAy9H/a74AhVuDw5JPOCvPUij6fqVNbXGE5h6aJmoun25W6507tzNYuHbCkYSrVt8ZgkwPC2PFmigXLi83+CCqgeN7oF5dZ3iyxefVoftVPqHQdphLk8WsPWAl4For8qBj00DB8mMtJj7TTaK25qb0U5++HLdbSb7ygFxwb2DDNYT2TNm9x0JLeX/SwbdqUuXRqE1mk27tdyXgbCRDpsExS7cjmzYLbt34YNF5IDu0+7wcrVzASN2DNy9OaGeW7CEX3HbHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KqRIK6G9+J3mTv3WVDlirp2QxzxiyMWo7QNMhWsry9Y=; b=R+doHfgWCoQRklxikLHyuozsCS23Ig8gsk2p7ekTpMxh0BjwOLDF8mJyGU0rAjvMhPFBHFcBY1MoJQfz9vFh+ROBn3hffXyjXWMdpREhtdb9G+nkSvelH3/DlVwcpNLrzuRRd8AvG0XC5U0jKDLMBeWzahEo7jlp9Kb3Ejc0ufw= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by PH7PR10MB7850.namprd10.prod.outlook.com (2603:10b6:510:30c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 22:15:56 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::92ea:33e7:fb66:c937]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::92ea:33e7:fb66:c937%7]) with mapi id 15.20.6652.029; Thu, 10 Aug 2023 22:15:56 +0000 Date: Thu, 10 Aug 2023 15:15:53 -0700 From: Mike Kravetz To: David Hildenbrand Cc: Xueshi Hu , muchun.song@linux.dev, corbet@lwn.net, akpm@linux-foundation.org, n-horiguchi@ah.jp.nec.com, osalvador@suse.de, linux-mm@kvack.org Subject: Re: [PATCH v2 1/4] mm/hugetlb: fix the inconsistency of /proc/sys/vm/nr_huge_pages Message-ID: <20230810221553.GD4734@monkey> References: <20230806074853.317203-1-xueshi.hu@smartx.com> <20230806074853.317203-2-xueshi.hu@smartx.com> <5c9ebf69-cd59-0fb3-bb85-1ab219426530@redhat.com> <79508337-08c1-7926-afd9-af21ee128949@smartx.com> <5b404d86-6b6f-b6c7-6286-f2ce3c4b5424@redhat.com> <42b78b9d-0a2f-c79d-0298-e4a7283a5633@smartx.com> <20230810001755.GC3537@monkey> <396edcf4-2b43-ef2e-baa3-b732134b8f93@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <396edcf4-2b43-ef2e-baa3-b732134b8f93@redhat.com> X-ClientProxiedBy: MW4PR04CA0262.namprd04.prod.outlook.com (2603:10b6:303:88::27) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR10MB4196:EE_|PH7PR10MB7850:EE_ X-MS-Office365-Filtering-Correlation-Id: 0abee192-7685-47c8-a553-08db99ef5e2b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4LB58/zksZh8TdVpPxpXjSxXH/NEk/pLCHh681jVRYv2qeheTFw8HN/e3g2RN1Hhi1qg/iB3GD9tUhtHvfDUPWDyBk3Y/rXTl8eEeDTYV52vQcEVawlCUViOxbN9OcHnvm78EBwVzHJtdnDcfFDOqAIJuIGwQMioUqJcTTc6TvdKx3khqFTjvMmhd0zoiED5WhE62OoiPDKufRmaxcrrAz9qF882cdi7H719psGQqWkcSHb8ajvVqZKkR7asjO8pgv7kemGT+myGW8sWmCp+xi+6QNTm73vxAFD84TzKKmm02XpvNUFPh79t7G1ijLhDmIeBDYegkKupiJx3fd8DI9ojQc8NLdqYr03dOMOQvAimZC/cUPuQ8WthfuLLjNqdU/OVbmZOdqJdKP5/LW5RiQOH2OaRMQmnmwAZBHQAFkBOMCn7bjVwnGvzdFd7I/2B9MLTqr85U0ZSaJMQ9o6yYyNSBKIqeKq6jhYJ0kfRZXB5RhLIhnfx8J68G+80IMynKfE0AcDQSlIHy4PqbGs0zt46Qf7f5xAho+xQlftU94zmxdBZEQ8kXa5w98CgB007JXR+37OjLlEgdpsFyvVTApc15FKThxv6A6TVjBZJkAs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(366004)(346002)(376002)(396003)(39860400002)(136003)(1800799006)(451199021)(186006)(83380400001)(2906002)(6512007)(53546011)(6506007)(9686003)(26005)(33656002)(1076003)(6486002)(86362001)(6666004)(478600001)(8936002)(66556008)(66946007)(6916009)(4326008)(8676002)(66476007)(316002)(5660300002)(41300700001)(44832011)(38100700002)(33716001)(14583001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0IM0R3deu+yC9Zw9c5PEBH46pS2Gv+fdMLX5eItJ0sQKiE1dzWYR8DSfyAOl?= =?us-ascii?Q?M1K337LgKZwTtdibeU+QEq/0M1pOgvX8yXnZiglM+Y/3dKpF5Q18PXsuX4E3?= =?us-ascii?Q?aJOmrbNB9kBEFeGEeJ0t4AvsiJWcwlmtO2eaAZPy3e9uKhr1UfHBTutu6wY4?= =?us-ascii?Q?7Y3eJY0G4rj4qRspIDlDe/oV+PiXIdgFp7SnC7Fwh3bEj4b1mEFlEx7WFWNc?= =?us-ascii?Q?yr1H+E1caw6cYWD+KufZv9m7y/5P07gWrOhwvm6mey2qzcLHX5lDN72EmQaN?= =?us-ascii?Q?sW06yCw7bixJKD20G3kPHSePxMwYyGKV68xfiYxfZ/1T5GW9M8Aoj6igzJRX?= =?us-ascii?Q?UqwUyBWhQRiGUOgbCuMd3/43iPG/VhsYBCgeXPwvhKSJFzyGQykKHKMBfePr?= =?us-ascii?Q?8J1Hnl9JLxADUb6yVsWsgjqcpWX0fWY87h+ANNILnkZO8wP6e6hrg5jg+dJ3?= =?us-ascii?Q?uZ5/y1Ui70gtdCxNZmgxEtNSXzgyD/Xu6V4sGfHgUZxll9kskeMj270QqmDC?= =?us-ascii?Q?p7nyALS3F3TOHW0ZcbawnxMV45PgoUu0UeGqL5/r22zuHVjLMH2hvPZwhfde?= =?us-ascii?Q?88QWKwG1lrUt7BRf543jP+w5GsioyED1bKyMka/xCWJ8JakLou9s2mhxyD9b?= =?us-ascii?Q?piCIdCB0+UL0NsZI9dM2L1szFjhMvdEqMzM00Fg1x6mmDK1kcRZI/ZwOYIiF?= =?us-ascii?Q?AphqV6pikuaa6KQO+eN+UcLO5qw5iNATKKYNGZemlD0JNnzLOqgucSvN3Z4A?= =?us-ascii?Q?Xln9ZVS4vZbeb3RaHfGrHgUEoLK9nr5rc3gLDgzpieMnR80+u+E844WRVcpf?= =?us-ascii?Q?SVxBwW+98O9UKMDrfXRxZM5RJj9Nx0JdkAmRH0snfrqrNF4C11efZk2k6J2p?= =?us-ascii?Q?vZSJZOv3FxV02ZzXe+Fu/lrN0lH9gBGyzK6LLbmpGQsNapXqE7ouAHdInDiE?= =?us-ascii?Q?q5VHiejj0IqAcmY5WZHjxSyLXu2IhbpolpL6nVzr60DxxFNKn9pMQKNaO8df?= =?us-ascii?Q?QAUe0FuK7yojyORA09pAiKMvQJrWzv75Tj/9nWeGqFqnSVTeWVdokUA10zKm?= =?us-ascii?Q?a/eqvuemGxMkxEJn+zvfaX3xcLcHbJU0ro6ti/K2B0lWqrRVVJBsT4ZIsDgV?= =?us-ascii?Q?e6k9ZQiwbkd9OV6hyo+1fdUi7XYLumm5ukznlgQa05a6eYRbF+dlqSsVOBGm?= =?us-ascii?Q?Fr+AfP4CfCfOC80fsyM9B9K/a/VsJ7pxrmOx8lKOJm+MNlSaaVGsNF+WIMa5?= =?us-ascii?Q?+1VH8rZpnW+ezMCVFtuFW9I5oq+BcfqNOg7+JZ+kYqWGol2IYK3+wp2ojvKh?= =?us-ascii?Q?y+AswIgjQs8RQVC3nrmCsulg5b+KQ8vMn79Z7QPnXKBKv2npApiJ2v82dguA?= =?us-ascii?Q?kAghVFRGDxg+WHJtGzJSDp0it102260EcveO0lfIWWBMslzc1Hy7adDRDHya?= =?us-ascii?Q?gAcJdLhgQu/hfocu8JqcRILaHm8Sfg2Gtfod2PHpkgjtOMMpsPS/YA6aM3J5?= =?us-ascii?Q?Ry8N8NLOHpoZFqxJyb7AFBVM4Lc7u5DBSNzAH491K1oq/CIkEqfmJjfmZnSc?= =?us-ascii?Q?dGnoYxlO/e7UajXyh6keWlOQHClkJoEaI7xw9kna+QB6d2+VdJ3cPYmA6aIu?= =?us-ascii?Q?/Q=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?jPIYeilYblol1ueiNqXmPJSfV+CjUuicJS3/Tc5ud/VcN4QM8tSAQKv4mTqc?= =?us-ascii?Q?XVzkfc+3CDuZcvr+I/1u7vFYPifTy0SjzzbaszY1YdDJ7TpWaIrlm/CWXSY3?= =?us-ascii?Q?EMFO405RMu90yputZHhMnRSnq3EjMVOVzeR/3zQBmXiMrQr0fgJdtjXJ+sPm?= =?us-ascii?Q?Gxpz/O9ap3f/Nc9gKt1fGiv6BmT1DZ57wCdRSk1eJkdfABLRKsCe3DWM/8tg?= =?us-ascii?Q?bG7eFZa2RSDU/onWGwjCrnKfnu5VXx2k0mrwsZP3lYfoXm0ra4F47ALV7rPv?= =?us-ascii?Q?92nkrU3IdC3ZM/C2YvMo4ye4gcUdpU4s3ufR9rD12VemDejgAw9CgZa+gHEB?= =?us-ascii?Q?oqfV0LjZTVvRv+20BoM6xLcQD6FDLgqgkvcZZGefIApcmf64ZL73hqk+T74t?= =?us-ascii?Q?5V6Xu7kqJasbEUbGPmOPRfwSoQJ4aKnRmqkhbp2zRWohwuGY6nr20373vK3q?= =?us-ascii?Q?H0OL7ecSyM9H66ITMHrfIDBhlYpnjQVfd61nNsz13FakpfcouhkJW/odhins?= =?us-ascii?Q?uqY0FPYM9e3UCrmBVAAZShhqXBYHRI+TP/dx8L81rJLHcMjhZp3Y5oSaz6Bv?= =?us-ascii?Q?fp5FkW2e54hFhmpbmIItb+0qfFIVhCg5www8NuQE+aOyYr/s3wUAKosnL3YW?= =?us-ascii?Q?eqGhlFZb4h5TeC3OXVT3SdD4wGqc9qX3Gmuai3NBZq2PQNBt8GooPuvnhXVj?= =?us-ascii?Q?mokCKZLnUBFUAhifROKn3p1Ld58eDo++1H49IKOuorDHVlT465RgEMongtpo?= =?us-ascii?Q?iAIQPuDqTcgBkXbYc4YMJUBM/L0M0NrZbIS3U5ae00dhAeXrNHzLPyVEkEeC?= =?us-ascii?Q?vP8A2iWmF8i5phax8qixL6qgwtlEaujT6dzUliDREF/1IZmt6obcBwBfOeHI?= =?us-ascii?Q?MCWBCT1TUR9P4ghUH/DgwdaVmTBZHAe0NUg75Xrv7Ohca0D/HyrmWtOtp1Ax?= =?us-ascii?Q?CO7ZiOoqcrScqO5kGmo4KQ=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0abee192-7685-47c8-a553-08db99ef5e2b X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 22:15:56.1196 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /X8wd95v/yTKAvMRg3Ur9XwIaK6cvFqYvzsor69tUS90jSVGqRF13I/uQM5QGgjS6KTs1AC6X9J74MxaZWTBEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB7850 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-10_16,2023-08-10_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=946 bulkscore=0 adultscore=0 mlxscore=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308100191 X-Proofpoint-ORIG-GUID: KScXUtztcNOKcHUEEf6Kjt9D4ZuBojVx X-Proofpoint-GUID: KScXUtztcNOKcHUEEf6Kjt9D4ZuBojVx X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9A6BF80019 X-Stat-Signature: jw67snozeime15bxqkjgx34h5myuq83a X-Rspam-User: X-HE-Tag: 1691705762-465368 X-HE-Meta: U2FsdGVkX19qgC8uE1gQi+Ws7VUKVlXA0M1fC77fdUNaTFm1mJo5suZx1Jzi10NCKLGin+3QsqBK44Celhja7PEDzKEzXyoyen9o+sEaNE/zTNz8WS8Q8o0Ut9ndv6EXMred7KIMnSL5ofjHOBARqEzkKbZTw9k2NCi317Dc7UIH2KOZwotnulGHl37zbjWNeI+byCUODsHV5x12jE6gp6PC7lyzhnImfOaa5mLUhz308kpsfk3SFz9FmJmDgavwzW+Nf+oimnSf2PtcRNYemO+b3WtiWqAvzsNDKTDQNq9TPzP8HBxKsWcxZpgoYHiWS0MLtAIdolYsuVlNudg+Zc7heds002TVxPhzTFpX0o4t45taaEck5lFGoUhqEw8ACd16wcmBWJKCDhM5Ysra8hA9JjYnv2tGOgQ+pHJ453UUhJzek8OBa8jeOfPV5zOyebkCZW6ds8TbdwperRFbulaq5luWWeiUGWp/JmwKERZBHUgxI6Gok41xd+M0mlyuaucu9rrKf0qr8sV2qGVCvFIhuWSuYHYQXg21hehujfrw+McULgoGI1zUGvm2XDMigTBKtpvV4mJwa+GLiXugkyRdwec96TnlBxVahu2QI1CBTsUnvK+Gp24CJhOidqsjY/w7a8mOD1/olZ5C9V6VQ+ALei8dLJqiAKJ6M4h0jzMpCcLRhj0G/q9679UuqhithnstUq16dBq4UuKJh9/Y3UBK1xF0dRcaOlMA5vS3hKDR3y5fkO78AX4z2eTj4WlZL2eFPKp0Et6n0WSNKvWZDZ0yMTWSNxV5npjGgGCeGZOd520+2Y1kqTqQ4fLxLNQkS8xBCiWB6XBYSEURtIp/NQkxB75C2DCa6ehyX99kSuTU3GELrs9jSfQl8y9OTDEMroolV+lR2Ca4/ZsmS8Qqmwy2vt1ECdAu3yvIorsURPYtXEvy+JK5hlr3z8Z/6xu84z0yQQ4NHwIMWGHh9Zz wfEsYc0H Jmp7LqBdOT6XLCTnxbS3fKNlGblv8ul9rbl92bSk1RCGSFX3dmmjPX6nZ/BCjVYID5zGbQkCbTDUvBd7GA8kISHyGcJ0ahT0gmeS5gBkBRd92nMfC1o1gjTsaJQGWhru0QyiQCmKwqHzzTm17WJhLQodaP6svU28q4yP7IOGToS0qgTQJObuMtYCCPuUnius29baRNY7AVHUkZOs+cVNR0ErreOmw3wKiSQNZh3BQlNq2uo0ihVfi5wRhuobnrYrozc7yGqSkEg4Xdc2EMsWQ4rqAOUoCDVx/keu0M4DoYCrlD8VWw23klZdNVVKWdSGmYZWNtPWTk0s+oPwCBVvvaN39BoysOwl9OywwvX+ccQneuDcIx2rTicg6+d39/5hIPHbJmzhvRo3SikYW10i4fBznWiAz95RyoOWt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08/10/23 09:34, David Hildenbrand wrote: > On 10.08.23 02:17, Mike Kravetz wrote: > > On 08/08/23 17:13, Xueshi Hu wrote: > > > On 8/8/23 15:58, David Hildenbrand wrote: > > > > On 08.08.23 04:28, Xueshi Hu wrote: > > > > > On 8/7/23 23:15, David Hildenbrand wrote: > > > > > > On 06.08.23 09:48, Xueshi Hu wrote: > > > > The question is 'Should we change the /proc/sys/vm/nr_hugepages (and sysctl) > > interfaces to be consistent with all the other read/show interfaces? > > > > The argument for changing is that consistency is good. Why have one interface > > that is not like the others? > > > > The reason for not changing is that this is the oldest interface. The > > information/interfaces originally available in /proc were created in /sys. > > And, as mentioned in the documentation the /proc interfaces were kept > > for backward compatibility. Unfortunately, the meaning of nr_hugepages > > was changed the /sys interfaces were created. Sigh!!! > > Indeed, they were designed to be different and to just leave the /proc > interface alone. > I am not sure if this was the 'design'. The commit to add the sysfs interfaces is a3437870160c from 2008. There is no mention of changing the meaning of nr_hugepages when read/displayed. It matters not if this was by design. It has been this way for 15 years and has become the expected behavior. > > > > In the thread mentioned above, I was in agreement with Hu about changing > > /proc/sys/vm/nr_hugepages to be consistent with other read/show interfaces. > > Now, I am not sure. > > My take would be to just leave /proc/sys/vm/nr_hugepages alone. Maybe > pr_warn_once() when the interface is used to guide people away from that > legacy interface + clarify the docs. Now, I tend to agree that not modifying /proc/sys/vm/nr_hugepages may be the right thing to do. I 'know' of a DB that makes extensive use of this and the corresponding sysctl interface. A pr_warn_once() may help, but I still see the warning "Using mlock ulimits for SHM_HUGETLB is obsolete" in system logs. :( > Your call. :) I REALLY would like it if all these interfaces were consistent and showed the same information. However, this inconsistency has been there for 15+ years. And, I know of users making extensive use of /proc/sys/vm/nr_hugepages. Hu, did you get a report of this inconsistency from a customer/end user? Or, is this something you and other developers noticed? -- Mike Kravetz