From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9A10C001E0 for ; Thu, 10 Aug 2023 16:36:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 630296B0072; Thu, 10 Aug 2023 12:36:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DFD56B0075; Thu, 10 Aug 2023 12:36:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A7196B0078; Thu, 10 Aug 2023 12:36:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3427D6B0072 for ; Thu, 10 Aug 2023 12:36:36 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0642CA06FB for ; Thu, 10 Aug 2023 16:36:36 +0000 (UTC) X-FDA: 81108748392.26.BB3ED0A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf13.hostedemail.com (Postfix) with ESMTP id 07AF420035 for ; Thu, 10 Aug 2023 16:36:33 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JWeB4JaU; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=LJ6qkOJe; dmarc=none; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691685394; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X+E0unmCYoA/5q96uLhFby2/QU/JbMexzKmCXmErmbw=; b=arR1YRk7sekzRHoXvXCQk6hsc5vXNBguL/BkLa6jCejyom8yU282LMJMIVs+KOuUqMU6D+ Wo/BltBLipuISbwiHy7CfjamANaU6Xl2DyYalbSrIfSjpVH0Q/UdvZPu7zvZLEw4Iw0Pd4 Aoa3/OEN5TDl8c3DQBQrnZ8l8IEUhMU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JWeB4JaU; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=LJ6qkOJe; dmarc=none; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691685394; a=rsa-sha256; cv=none; b=YRHWYNGHtm0W7M8/MJuDmbDuD5Z+gYu7KsgZ0dbatJEeCRV0wnvpsVC2fffWK+r66/RtX8 eDguSfU2MoYCIf+/cn6+zmajZPyQdBAPmm0LseaPKPCzrlT8HWWUIE2WxMLnx+I2q5shfm 9OqWiJY6o3hFoVXOVaK10hI6RoGkE+o= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8EF7621873; Thu, 10 Aug 2023 16:36:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1691685392; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X+E0unmCYoA/5q96uLhFby2/QU/JbMexzKmCXmErmbw=; b=JWeB4JaUfgHvZaQeMrzQj2VqCapH0EynaaBfufBlIRxTx2ECYhL9B4n2CuXBu6jHkxgffL uVIy1YZx4Q6tJiGJvsrFSVobLMkg9U3vkSz/at4f5HT90qx28+/qHEIJYIHKswNOLrQsr4 QED/YEf1+onvGmo/vyJGQ/ZssUBn/y0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1691685392; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X+E0unmCYoA/5q96uLhFby2/QU/JbMexzKmCXmErmbw=; b=LJ6qkOJeM0r8nLNtSMjM6Pg9NO37l/Pq3Eu3JIT5fRdJOyJqXGNu1/AgSzrz+6N0a1tK+A kI0gqf+8T9tuSgDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 61C11139D1; Thu, 10 Aug 2023 16:36:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id CIAVFxAS1WSEPQAAMHmgww (envelope-from ); Thu, 10 Aug 2023 16:36:32 +0000 From: Vlastimil Babka To: "Liam R. Howlett" , Matthew Wilcox , Suren Baghdasaryan , Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Vlastimil Babka Subject: [RFC v2 1/7] mm, slub: fix bulk alloc and free stats Date: Thu, 10 Aug 2023 18:36:29 +0200 Message-ID: <20230810163627.6206-10-vbabka@suse.cz> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230810163627.6206-9-vbabka@suse.cz> References: <20230810163627.6206-9-vbabka@suse.cz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 07AF420035 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ohz9o6iboyf56kkx3ertzx4czt9ms94k X-HE-Tag: 1691685393-456110 X-HE-Meta: U2FsdGVkX1/nuVDjkk7g8JbJI3SwFbiQzNgRKCnY48kwMBqWldA3qq5ahCxKR1OrFdhaAKjHqeMdnTt3SnAjdN0HFTzCcXjp34Mn72dfpm6Qr31RN+DN75LbcJnV+/0DS0x0Hh/8lPFMgM6kKcaaUo8EoUCGc7gWrY9K8X05bWd9M7a5tlhd9rMFMviPCusBgb5HQmLHLeQlaX3KdDegNp6xHWTwg2cM4RwKaOa+0LlrIBclaoD1ryLI2zll7egg27KtLqx8NO8UJJgOVDeRWZtJgkxKyIwdwlmVHZoeJNbjInrEMyRPkQAg8GqDtAVjbGRhtZNqcqNKnj+9TKtO4TLa14fyGFOqrR8Cevz99wAvDneU+uaa92/WPB5PdrvBSGb1ydKpgJlhXLIRYYl+dVfZLksI7/nXaSttXXlXXt5KNq7CdTn71u1AtMcYo+qSPmwwu2/sJZ+p1M4ai2llHN+f96vIgdc/rP7rChLZeOdAazTY9fSDO/9k2WoSk9m3FsujOK2p32w/x63sV2AOgeb6vY1QIt4DVTFsX5U2NL98qs6fRhw0s/AXQ9EV+MvUvny1BsYinFb9FvZnCvNtldBIvm6D8ko+ryRCDezIwJgPENFuZ6hjkf9tE9De/pDLLgRNme5Kujk+ba6/gt+e9TbIXpdgJYV2RBBtfCV/U0X4P39GcexbZ5AdRbpBwD9u7KpvZZeQFO+USKlSBum2PAwO9Q7tRIr2YI1eOtgWXD5mScS9AQTF0gvY+yDIiD5T4KZrkVs3MSKoqfRkl5fCASDVdVw02xY2I72cbRazPajdkkwOpCrn3NY2Q+e70mRp/6MRC1tOkCYxDh4/3N2jYzdL/MjUTakMoo7gYx/RTVbx3AGxbCK/5/vlW5VYungVxkd0eoZAwnI0bfq5+Fa3cNq4z9MDQpQWUoc96Tnz40umhQRFy7ur0H9yUJr3csKMYyR/5vJ5UXFrSYuSgvz Aa1Os8B2 MWkxBKkumwqaAr/J3IrEesznZKmj4L/XpOji04TVsQ4v1wNiqSYxs5Ow8ektcc3UgcvlUnyLnqk0VWSUgtDWVhu6HEuesIzUHwDLIhpA1IsfkM7mBVhesXfRKz28b4vJsHRlB1cfmwjzt0w1DSJvK1v9y1Zi9IeWRzEw2RFfYbIH9j0WfXNTLXqGlF3OTjz4TQ9hs/6j3C93sAJQYp/hqKN9fK6gC6cHXNZP+iKOq3w4/wXuiIpHuH/XNq6gn3jyKgnXG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The SLUB sysfs stats enabled CONFIG_SLUB_STATS have two deficiencies identified wrt bulk alloc/free operations: - Bulk allocations from cpu freelist are not counted. Add the ALLOC_FASTPATH counter there. - Bulk fastpath freeing will count a list of multiple objects with a single FREE_FASTPATH inc. Add a stat_add() variant to count them all. Signed-off-by: Vlastimil Babka --- mm/slub.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/mm/slub.c b/mm/slub.c index e3b5d5c0eb3a..a9437d48840c 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -341,6 +341,14 @@ static inline void stat(const struct kmem_cache *s, enum stat_item si) #endif } +static inline void stat_add(const struct kmem_cache *s, enum stat_item si, int v) +{ +#ifdef CONFIG_SLUB_STATS + raw_cpu_add(s->cpu_slab->stat[si], v); +#endif +} + + /* * Tracks for which NUMA nodes we have kmem_cache_nodes allocated. * Corresponds to node_state[N_NORMAL_MEMORY], but can temporarily @@ -3776,7 +3784,7 @@ static __always_inline void do_slab_free(struct kmem_cache *s, local_unlock(&s->cpu_slab->lock); } - stat(s, FREE_FASTPATH); + stat_add(s, FREE_FASTPATH, cnt); } #else /* CONFIG_SLUB_TINY */ static void do_slab_free(struct kmem_cache *s, @@ -3978,6 +3986,7 @@ static inline int __kmem_cache_alloc_bulk(struct kmem_cache *s, gfp_t flags, c->freelist = get_freepointer(s, object); p[i] = object; maybe_wipe_obj_freeptr(s, p[i]); + stat(s, ALLOC_FASTPATH); } c->tid = next_tid(c->tid); local_unlock_irqrestore(&s->cpu_slab->lock, irqflags); -- 2.41.0