linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kemeng Shi <shikemeng@huaweicloud.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, baolin.wang@linux.alibaba.com,
	mgorman@techsingularity.net, david@redhat.com,
	willy@infradead.org
Cc: shikemeng@huaweicloud.com
Subject: [PATCH 3/3] mm/page_alloc: remove unnecessary next_page in break_down_buddy_pages
Date: Thu, 10 Aug 2023 17:53:09 +0800	[thread overview]
Message-ID: <20230810095309.3109107-4-shikemeng@huaweicloud.com> (raw)
In-Reply-To: <20230810095309.3109107-1-shikemeng@huaweicloud.com>

The next_page is only used to forward page in case target is in second
harf range. Move forward page directly to remove unnecessary next_page.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
 mm/page_alloc.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index d0b400733031..e884d3fd0d06 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6544,20 +6544,18 @@ static void break_down_buddy_pages(struct zone *zone, struct page *page,
 				   int migratetype)
 {
 	unsigned long size = 1 << high;
-	struct page *current_buddy, *next_page;
+	struct page *current_buddy;
 
 	while (high > low) {
 		high--;
 		size >>= 1;
 
 		if (target >= &page[size]) {
-			next_page = page + size;
 			current_buddy = page;
+			page = page + size;
 		} else {
-			next_page = page;
 			current_buddy = page + size;
 		}
-		page = next_page;
 
 		if (set_page_guard(zone, current_buddy, high, migratetype))
 			continue;
-- 
2.30.0



      parent reply	other threads:[~2023-08-10  1:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-10  9:53 [PATCH 0/3] Fixes and cleanups to break_down_buddy_pages in Kemeng Shi
2023-08-10  9:53 ` [PATCH 1/3] mm/page_alloc: correct start page when guard page debug is enabled Kemeng Shi
2023-08-10  9:10   ` David Hildenbrand
2023-08-11  3:13     ` Kemeng Shi
2023-08-10  9:53 ` [PATCH 2/3] mm/page_alloc: remove unnecessary check in break_down_buddy_pages Kemeng Shi
2023-08-10  9:53 ` Kemeng Shi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230810095309.3109107-4-shikemeng@huaweicloud.com \
    --to=shikemeng@huaweicloud.com \
    --cc=akpm@linux-foundation.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox