linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kemeng Shi <shikemeng@huaweicloud.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, baolin.wang@linux.alibaba.com,
	mgorman@techsingularity.net, david@redhat.com,
	willy@infradead.org
Cc: shikemeng@huaweicloud.com
Subject: [PATCH 1/3] mm/page_alloc: correct start page when guard page debug is enabled
Date: Thu, 10 Aug 2023 17:53:07 +0800	[thread overview]
Message-ID: <20230810095309.3109107-2-shikemeng@huaweicloud.com> (raw)
In-Reply-To: <20230810095309.3109107-1-shikemeng@huaweicloud.com>

When guard page debug is enabled and set_page_guard returns success, we miss
to forward page to point to start of next split range and we will do split
unexpectedly in page range without target page. Move start page update
before set_page_guard to fix this.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
 mm/page_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 96b7c1a7d1f2..fd93d1396ccd 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6557,6 +6557,7 @@ static void break_down_buddy_pages(struct zone *zone, struct page *page,
 			next_page = page;
 			current_buddy = page + size;
 		}
+		page = next_page;
 
 		if (set_page_guard(zone, current_buddy, high, migratetype))
 			continue;
@@ -6564,7 +6565,6 @@ static void break_down_buddy_pages(struct zone *zone, struct page *page,
 		if (current_buddy != target) {
 			add_to_free_list(current_buddy, zone, high, migratetype);
 			set_buddy_order(current_buddy, high);
-			page = next_page;
 		}
 	}
 }
-- 
2.30.0



  reply	other threads:[~2023-08-10  1:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-10  9:53 [PATCH 0/3] Fixes and cleanups to break_down_buddy_pages in Kemeng Shi
2023-08-10  9:53 ` Kemeng Shi [this message]
2023-08-10  9:10   ` [PATCH 1/3] mm/page_alloc: correct start page when guard page debug is enabled David Hildenbrand
2023-08-11  3:13     ` Kemeng Shi
2023-08-10  9:53 ` [PATCH 2/3] mm/page_alloc: remove unnecessary check in break_down_buddy_pages Kemeng Shi
2023-08-10  9:53 ` [PATCH 3/3] mm/page_alloc: remove unnecessary next_page " Kemeng Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230810095309.3109107-2-shikemeng@huaweicloud.com \
    --to=shikemeng@huaweicloud.com \
    --cc=akpm@linux-foundation.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox