From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F059C001DE for ; Thu, 10 Aug 2023 09:25:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC80F6B007B; Thu, 10 Aug 2023 05:25:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D770F6B007D; Thu, 10 Aug 2023 05:25:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3EFD6B007E; Thu, 10 Aug 2023 05:25:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B76856B007B for ; Thu, 10 Aug 2023 05:25:22 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7EF52C0F10 for ; Thu, 10 Aug 2023 09:25:22 +0000 (UTC) X-FDA: 81107661684.12.3B37832 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by imf02.hostedemail.com (Postfix) with ESMTP id 8EFF480022 for ; Thu, 10 Aug 2023 09:25:20 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ceIK6cDq; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf02.hostedemail.com: domain of yan.y.zhao@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=yan.y.zhao@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691659520; a=rsa-sha256; cv=none; b=TffEswni3JIRPuVNFgaxO1KS9LXEswWTvRVTzCOAReIn4Y4MJwQlN43gAUM4qsRumx7AZv R2kXxZYScxxkRrBdRGanPP9oYF+pKvhErXb1h3b1PRp0xbz7KyV/KZ1NPYYhZqmxHFUf0P zD8rce1TzYJNg11kc++peQQncPet9LA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ceIK6cDq; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf02.hostedemail.com: domain of yan.y.zhao@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=yan.y.zhao@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691659520; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=SxloWDV3h+sdKOmXK4HSVovGWLEgXVGeioIvdwHwjaU=; b=nrrZM3OMWS4ND6020dUL4wnrhA4qyTi1fBkjG1sM2CJY+wNW1Rp72G3cN7ymw7L+OC/cTe S9NOnWz7zxrjwl+UCj3+5Fmxa2N5MqtgNCklJsTQH1gAvwQ7SZRivSXUX2LRGU48tcriV2 lppiHQp4qw74mbOjARR1mKnvfbJAwjE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691659520; x=1723195520; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=n1Msk62xu+U/2i8oJmw01jY05sFs/JrR7DH8MV3GHPs=; b=ceIK6cDqvyv+GURyOlAc/zY7LDELmxSaPySPXvR5npxZAJ5s5GUj1edO Oos3B1Oen+NMfcUCT3VWdmuMzO0mW42mc/d/ieWni4rtRQcn+pllv7s9b yXfxUDEJXwi6LQElGVrbyPv9ZqpeXn2wKKaXsfYi9ii3fP1uPzleu2Jsw 8HAeCtyLNwQ2dau/7sLdsaUfByCL33JQIo1tW1R91kgARH1qLfIEpVRha ZUziNAiZBmhJLPY6NVn/SzUD3KqvQHzGGRG8GWnRtZGi2i5myZRSbGKfO QAa37cFCJ+XY6ezN3n5/JP1SgLaClQF6j39BHdQj5TyhM/jmg7u4wIt2m A==; X-IronPort-AV: E=McAfee;i="6600,9927,10797"; a="374123738" X-IronPort-AV: E=Sophos;i="6.01,161,1684825200"; d="scan'208";a="374123738" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2023 02:25:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10797"; a="855867318" X-IronPort-AV: E=Sophos;i="6.01,161,1684825200"; d="scan'208";a="855867318" Received: from yzhao56-desk.sh.intel.com ([10.239.159.62]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2023 02:25:16 -0700 From: Yan Zhao To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: pbonzini@redhat.com, seanjc@google.com, mike.kravetz@oracle.com, apopple@nvidia.com, jgg@nvidia.com, rppt@kernel.org, akpm@linux-foundation.org, kevin.tian@intel.com, david@redhat.com, Yan Zhao Subject: [RFC PATCH v2 2/5] mm: don't set PROT_NONE to maybe-dma-pinned pages for NUMA-migrate purpose Date: Thu, 10 Aug 2023 16:58:25 +0800 Message-Id: <20230810085825.26038-1-yan.y.zhao@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230810085636.25914-1-yan.y.zhao@intel.com> References: <20230810085636.25914-1-yan.y.zhao@intel.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8EFF480022 X-Stat-Signature: upd848ifunpf5w7aopegcnp4ruem1srf X-HE-Tag: 1691659520-882319 X-HE-Meta: U2FsdGVkX188IJIrTyRPCAYjRf2InE3rfLUD4wMj5UWXWYk6swnFk8I1uturJstz+Cducvl7ofBtACOP+tiAQ9HnybGZyu6AOOBLVOlJ9K6/lyfA5biIXLMGzRTgFOyc4kQCexyfWoiFWH49xrPTE3tGWoZ5SovKRwe+30KHr8x63mpy7Kfgxs/hrq9M9PpkF1obm1MkTEYd2kxR6vIBtYLtLuz4Ksm70ndbVp3d/uWiQP/vk6K3dwy0vUN/VXcLr5juWPU9qTyquIg6fS1IipGbE0zfNAOvsMWqQjrjuixIZL4/fJjQ0p9nwWb45+qGUoERZWkwMUjOgMoQwKjnoRYbJpPXhDUEgGGoGtKqfxwYW6JhiJ6CpmJgNIkKzjw6iWMxdA897AiPvu3IktTxdYvXdexNcDRAVtzyL0IiijMlzbRIqKshCipVtvqOUEyK5lJIHdvlvjgCURax9/RrYSbVyWP6iFoNWJ7JsBLqcEmDbp0rquSWuOXG5F21lFpHjcmVUN7PCr4+fwivryRUVxApu4cbHsxVN93EPU+g/kSgz7OwzS+GdLOi3aevD/FCa5uh5fI1lRwQN+5YSwwCs5TrCxWDVWSa2J2Naa+qldDQSNWTYrgCDgbd2zlOiiHeAV88EjQxMBJj63JhIIYpwraoGJqrViGtcu4OrPbUmMcPIMrV0KKZrSaAa284sYe954NwPvyXgrEOcOcfBSxnD665HSA/dbyF5vSuFnyfACweHaS7dSNJdU6be1c48r854yh7GPqFaXWg9N39fG95oz22ckqL8WWUcDSS+6W0xRNciimhZfMuC/AuYoHYcI6vEDmGYC4VcLIVZ5UU/4EA0CzNGnlFmZvcJLDjTifWVYmqivSNEOUNIYfDPm2unmLY7eaQiWAgSqXKN9fHQ/ZZu9A8aCrvdTS8zg7VziJa6XdAp30rR0XEC4lX+NfSW/Ib0+3rzj096JU7LSOAp3p iHaca4i4 Xx+FxJjP50YQDrHSnJO3DGpZAgHFvzGto27628O87GR12OIZwRBzN0Ki+zk/S7we12VP2zVKAc2U0/yBH2ZpQfJVD3ookNp3yxEu6TaC9YgD0826d35iC9hO00Arl8tfzdapcQajb2Cal/BZNxyY0107IV3N+ZQMlZl4U X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Don't set PROT_NONE for exclusive anonymas and maybe-dma-pinned pages for NUMA migration purpose. For exclusive anonymas and page_maybe_dma_pinned() pages, NUMA-migration will eventually drop migration of those pages in try_to_migrate_one(). (i.e. after -EBUSY returned in page_try_share_anon_rmap()). So, skip setting PROT_NONE to those kind of pages earlier in change_protection_range() phase to avoid later futile page faults, detections, and restoration to original PTEs/PMDs. Signed-off-by: Yan Zhao --- mm/huge_memory.c | 5 +++++ mm/mprotect.c | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index eb3678360b97..a71cf686e3b2 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -1875,6 +1875,11 @@ int change_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, goto unlock; page = pmd_page(*pmd); + + if (PageAnon(page) && PageAnonExclusive(page) && + page_maybe_dma_pinned(page)) + goto unlock; + toptier = node_is_toptier(page_to_nid(page)); /* * Skip scanning top tier node if normal numa diff --git a/mm/mprotect.c b/mm/mprotect.c index cb99a7d66467..a1f63df34b86 100644 --- a/mm/mprotect.c +++ b/mm/mprotect.c @@ -146,6 +146,11 @@ static long change_pte_range(struct mmu_gather *tlb, nid = page_to_nid(page); if (target_node == nid) continue; + + if (PageAnon(page) && PageAnonExclusive(page) && + page_maybe_dma_pinned(page)) + continue; + toptier = node_is_toptier(nid); /* -- 2.17.1