From: Xiaolei Wang <xiaolei.wang@windriver.com>
To: catalin.marinas@arm.com, akpm@linux-foundation.org,
glider@google.com, andreyknvl@gmail.com, vbabka@suse.cz,
zhaoyang.huang@unisoc.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] lib/stackdepot: Bail out in __stack_depot_save() if the stack_table is not allocated
Date: Thu, 10 Aug 2023 15:47:03 +0800 [thread overview]
Message-ID: <20230810074704.2042664-2-xiaolei.wang@windriver.com> (raw)
In-Reply-To: <20230810074704.2042664-1-xiaolei.wang@windriver.com>
The __stack_depot_save() may be used by some subsystems even before
the stack depot is initialized. So add a check of stack_table in
__stack_depot_save() to make sure no oops in this case.
Fixes: 56a61617dd22 ("mm: use stack_depot for recording kmemleak's backtrace")
Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
---
lib/stackdepot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 2f5aa851834e..a0651d013a0d 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -376,7 +376,7 @@ depot_stack_handle_t __stack_depot_save(unsigned long *entries,
*/
nr_entries = filter_irq_stacks(entries, nr_entries);
- if (unlikely(nr_entries == 0) || stack_depot_disabled)
+ if (unlikely(nr_entries == 0) || stack_depot_disabled || unlikely(!stack_table))
goto fast_exit;
hash = hash_stack(entries, nr_entries);
--
2.25.1
next prev parent reply other threads:[~2023-08-10 7:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 7:47 [PATCH 0/2] Bail out in __stack_depot_save() if the stack_table is not allocated and delete the kmemleak_initialized judgment in set_track_prepare() Xiaolei Wang
2023-08-10 7:47 ` Xiaolei Wang [this message]
2023-08-10 9:53 ` [PATCH 1/2] lib/stackdepot: Bail out in __stack_depot_save() if the stack_table is not allocated Vlastimil Babka
2023-08-11 2:02 ` wang xiaolei
2023-08-10 7:47 ` [PATCH 2/2] mm/kmemleak: No need to check kmemleak_initialized in set_track_prepare() Xiaolei Wang
2023-08-10 10:03 ` Vlastimil Babka
2023-08-10 10:16 ` Vlastimil Babka
2023-08-11 2:03 ` wang xiaolei
2023-08-11 8:09 ` Vlastimil Babka
2023-08-14 16:20 ` Catalin Marinas
2023-08-15 2:27 ` wangxiaolei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230810074704.2042664-2-xiaolei.wang@windriver.com \
--to=xiaolei.wang@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox