From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01D94C001DE for ; Thu, 10 Aug 2023 10:08:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 646696B0071; Thu, 10 Aug 2023 06:08:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F6716B0074; Thu, 10 Aug 2023 06:08:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E7776B0075; Thu, 10 Aug 2023 06:08:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3CE946B0071 for ; Thu, 10 Aug 2023 06:08:11 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 141EF16105A for ; Thu, 10 Aug 2023 10:08:11 +0000 (UTC) X-FDA: 81107769582.12.342A216 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 6D39F1C0029 for ; Thu, 10 Aug 2023 10:08:09 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cQ3yqE7H; spf=pass (imf20.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691662089; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MvVQcySHlItuuh0lCGLivoiz3d3Cw4WOQ2sJAPHCqqE=; b=8HeYy2qJT+WLCOA1mGkF8pm/YFsaNbOErtrWLhx1l17h7SEtrZm/+ZjYOMXCy9hynF0y7R WuRMW16hw/gE83CAPDshU+GRKgpJtLk1pJ/VagNTrfHr9yqfv0yz10f7bqqbId7cOaeo1G Zo3flPgvlVL5agV4eNgXXT76I2WaXf0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691662089; a=rsa-sha256; cv=none; b=ijVT9CD9x7Y4wVzuIVjXX9/DfWeT7hiv4LAN//84sb6e+iKQ87XU0FooJ4M94C0FCI5UTG S2cfq7nIM/QaXiAfeURuaLyyVGbo/o9MJ4E+sVEEayQ99WzwJWvSguMt9UZNO6vNJbhmFC lPPFXRQVRBB/nJBLyvVOMjM10s7my+0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cQ3yqE7H; spf=pass (imf20.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6E0F965733; Thu, 10 Aug 2023 10:08:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECF93C433C7; Thu, 10 Aug 2023 10:08:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691662087; bh=hWvKN3wU8wjWbRwA95OgyxSzGrr+vZxnrxqzjfcVxqk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cQ3yqE7HC5zB5nzsSrxpfMxnCdqRhFx2hwtA53uvHkban4uSzCjrq0RZLZUL4aVw1 VhffnZa67oKIrLiI27GZP6prFQZsQ96cEFY4RI9rrnwNv3VVub6nYRKF4UWnutTLsf tIFuXnc7Oyjlf55o5Hg7hsMB/q5O7rda0gxDzISvRecdd8eWuK8PV7gQb4bI+D6/Sy dyCQJ1tfUk8gn9Z/IHTTVlZQ3j13/2PqGQR+PDybqCwVP0tnA6M2kmFEi1AuDOvVLX U1JPUu7yGmwBabE8Fl3aLg+R5SCmhT8DB+hSWctIp4TBYPuOxB5csTLSvxK6POzzWd 7queN6GPqqOFw== Date: Thu, 10 Aug 2023 12:07:56 +0200 From: Christian Brauner To: Hugh Dickins Cc: Andrew Morton , Oleksandr Tymoshenko , Carlos Maiolino , Jeff Layton , Chuck Lever , Jan Kara , Miklos Szeredi , Daniel Xu , Chris Down , Tejun Heo , Greg Kroah-Hartman , Matthew Wilcox , Christoph Hellwig , Pete Zaitcev , Helge Deller , Topi Miettinen , Yu Kuai , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH vfs.tmpfs 0/5] tmpfs: user xattrs and direct IO Message-ID: <20230810-notwehr-denkbar-3be0cc53a87a@brauner> References: <20230809-postkarten-zugute-3cde38456390@brauner> <20230809-leitgedanke-weltumsegelung-55042d9f7177@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 6D39F1C0029 X-Rspam-User: X-Stat-Signature: qwfddo5wt545cnn96wxn6pwg6ao3y5bk X-Rspamd-Server: rspam03 X-HE-Tag: 1691662089-673851 X-HE-Meta: U2FsdGVkX18Po+oKxYvmc+9322xDyf8oJWXTCPiQWRRGxcnqSkFR5OuXvUBSjq1breEhAnM8+AKB7dEJcUpc7dIc/Duz39EPV/2f1Uhz7aAGUU4HVWVg/Kc9pr8b1yUqMFCaJqlQp8P+M5GnqgsH0QImWd71oNDY5hQgW1e/5Qq8x4jq8B06DsgnRXblHW4bAbRwPfoK6Yu7gxw74ne0niv8cKHrJO39MbliSObio11KgoGLUtsWpb4Bvpmum4pO2eO/Lpe/ICym2mk4lj0OoqrkU8Meum8R8Y/Jw0fhSZp3uYIFLRllN2PcZICeWvVp5fIxXc9r8AFzg5ceBiEICQpiM14dTBDeLiPRdr1MPp4Kx9YsKE4i5XWrd1cZegBxL6hNBu2MxgskewWXrgAz2pCc3FQIiElf6T1GL749lYjFSoWrl+W4zJ99tjGcFyj0SHMauGVoLGHcN5fKHUY/JKDzyM4RuNxSfa9JfnQqlh7jeWgAxSBN0lU6iSjMTlWQ5TFNbzXYYvTEf35mCImUBQ/2hMkK/RaL9lnboaiMJVSd9Oly3cpdBl97MmJc3uLDSxTfNntmPF8hJSQidw/2cVA4ex3ah/qjkZ56T+55IyLtd4oTfUZCPIqctGXx1VsHxr5eB5ktQojpvRGCR/+e7kg9OTeyMBFCFfhiRATUE9ulGUszPdl6ZToVeLe/9IT7p9+PTlf22Z5WVGuM6f/5prmwSA5oP4GFPLNEDLiu7pcUXp3bBfeYsiN68XGOuy0qmVIbyh/cvSNhc4XhN4UAG3XIgs2xkieA6JXRPIxTiblayBUd04jrB1tYqbh8Y12BcHoTdp4VW28RCSoyyB6DiuP4N4ctkAMcEiAYfAB2Afa+zn2RdBhxe3wr6TdOPxI2AOEOa3wfTTqc4Zd3ntoxSRiQl71UacA3p8GUfIwf5CACwfb6x5dFbw0eAxiLiB76piGNUpE299+cw3Lkfla sWBLINj7 6H/UhsNCYSRJm02szYezXAUs1NUNHzEJ4uK1cuabnzF5BCzgZ9BDx3FJI1CbQJRmJidXVUaG4KjKjKa6VEo08J/smOqPFbxD1IaNlOyxmWRRjOZceJdfFKU6VTeDk8ZQFIR1bPpeEyJCroR4amR0a+WqX6o0caO12FNDYO6GGQkT9JLGbCQb8rfKuh0nKvs91e0dgNpROaRph6HFzKsK2AaN2bP71LZIbw2UlXKWaCH34eMOzNLe4s7uKCmh+kle6PecR1ACRTeLwVR2AIfE8kJlga37rTil6kaM+NAHlNpMmJHENEge8F8ygzlAGHhix1XDF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 09, 2023 at 10:50:39PM -0700, Hugh Dickins wrote: > On Wed, 9 Aug 2023, Christian Brauner wrote: > > On Wed, Aug 09, 2023 at 08:45:57AM +0200, Christian Brauner wrote: > > > On Tue, Aug 08, 2023 at 09:28:08PM -0700, Hugh Dickins wrote: > > > > This series enables and limits user extended attributes on tmpfs, > > > > and independently provides a trivial direct IO stub for tmpfs. > > > > > > > > It is here based on the vfs.tmpfs branch in vfs.git in next-20230808 > > > > but with a cherry-pick of v6.5-rc4's commit > > > > 253e5df8b8f0 ("tmpfs: fix Documentation of noswap and huge mount options") > > > > first: since the vfs.tmpfs branch is based on v6.5-rc1, but 3/5 in this > > > > series updates tmpfs.rst in a way which depends on that commit. > > > > > > > > IIUC the right thing to do would be to cherry-pick 253e5df8b8f0 into > > > > vfs.tmpfs before applying this series. I'm sorry that the series as > > > > posted does not apply cleanly to any known tree! but I think posting > > > > it against v6.5-rc5 or next-20230808 would be even less helpful. > > > > > > No worries, I'll sort that out. > > > > So, I hemmed and hawed but decided to rebase vfs.tmpfs onto v6.5-rc4 > > which includes that fix as cherry picking is odd. > > Even better, thanks. > > And big thank you to you and Jan and Carlos for the very quick and > welcoming reviews. Happy to. > Needing "freed = 0" in shmem_evict_inode(), as reported by robot: Fixed that. > And I'll send a replacement for 4/5, the direct IO one, following Ah great, thanks!