From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B929C001DE for ; Wed, 9 Aug 2023 23:07:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9AE856B0071; Wed, 9 Aug 2023 19:07:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95EDF6B0074; Wed, 9 Aug 2023 19:07:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 826FA6B0075; Wed, 9 Aug 2023 19:07:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6F9E16B0071 for ; Wed, 9 Aug 2023 19:07:22 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 43B08C0569 for ; Wed, 9 Aug 2023 23:07:22 +0000 (UTC) X-FDA: 81106104324.20.8642EBA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 9B32AC0011 for ; Wed, 9 Aug 2023 23:07:20 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tSILKFd8; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of conor@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=conor@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691622440; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+dEkcrkOf/6DcgjLocwePkEkWflhZSGJZZSQWzBYHGo=; b=GUUo1HFdu3iwHxpLUEWqQ4c09bV/OlNC3BnAlLmr2wzsN6WI1/7/cDmykBVwyU0ZCxJvil NQwlXKI23OAmiqt46p644PpBbiS2KPZtLWyb5vVQsi9g/rVqpR+XKe1Q6l8TNVZGrFeV7P PaGx+MV+CfMoePH89HI50o2bJtWtIwc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tSILKFd8; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of conor@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=conor@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691622440; a=rsa-sha256; cv=none; b=xaVJgSDikebuJS0NE+KGs9h+etE2qtiRBLuEh2LqfGf6nBpyPpodr7uqTkTyeG6oZ5O41+ wAqFGCrHDGdcZiPVB5Mxm7VoMI13xJv3hXMRfkWyedbCfR8vob+v2kToA0HBCjyp0+hK/L 1p6oGOnnv0Z4NoEx/xYp0jmBnqTcnBQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A2C0B64C06; Wed, 9 Aug 2023 23:07:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06029C433C7; Wed, 9 Aug 2023 23:07:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691622439; bh=+dEkcrkOf/6DcgjLocwePkEkWflhZSGJZZSQWzBYHGo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tSILKFd8wS38f4oavtvjQ501JfhIpp5IY8YiqwpIe3vNWWZ08fgrD3X4Xfci6uwtr kMbEfKDegKeeSmHH6Yvfv/CDRFe7fjTZ52gWWxMoCUw5JbXEr2f0aTuKOZRgQj18Bt ZHjAVbcPoXk5wIDMwn3qq4PTXaBS2kkH+5IOlSt6dlrOmcuCKUZ+guEGkg50b3y9rx mEG7UOX56dGTRkST1iQaCam1DJGE/6LH5evYbSRi7XvaRHk6UL2rnjO8D5wC9S2vmn jo/SI1ihD5LMR50r6zClX0VBmWaOJlhlhZZorMWl9uozgeMLUjiEzd/zKvHG/XoFkn RrabOl7AWSTcQ== Date: Thu, 10 Aug 2023 00:07:13 +0100 From: Conor Dooley To: Charlie Jenkins Cc: Conor Dooley , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, paul.walmsley@sifive.com, palmer@rivosinc.com, aou@eecs.berkeley.edu, anup@brainfault.org, konstantin@linuxfoundation.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, mick@ics.forth.gr, jrtc27@jrtc27.com, rdunlap@infradead.org, alexghiti@rivosinc.com Subject: Re: [PATCH v9 0/4] RISC-V: mm: Make SV48 the default address space Message-ID: <20230810-endanger-motive-83096266ab26@spud> References: <20230809015110.3290774-1-charlie@rivosinc.com> <20230809-bobbing-unleaded-c3d5e1c57d96@wendy> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xYlUSbAm7YzipPhu" Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9B32AC0011 X-Stat-Signature: 63h3cgs6bfcb5oms3bneebazdtkc46te X-Rspam-User: X-HE-Tag: 1691622440-538645 X-HE-Meta: U2FsdGVkX1/RDfAcL0naPL1dfumlrL5F9hMmNU9J+doAApYDlVyeQR3UO8puyVWg/sY+adMjhu41z9Rcm0jSnLIU42JrBqREuG3CyLvCxkb723gHZPeP2rJUEtlVYiP8fJUBFJA3AbsGr9g3cXV64X389Sk5ptAYHVczqFl4afd85Xd/blHbEPGffN3WKWj9Fw9gatx0NcZ1w9YTv5V7j/ulZx4QoyehIVPcV8TEzdihX7hQOGkEFazMSytJCFBbunuPHCMkj50j4BnuW/0XceX6Qk9AwmEkgqzWpSXxE6V2qyQW8rpsf1tLkBXr2b4m3dkOBRD+CY3TECRI+DKwkPB77Kt3LL2y+6fwXayoP2gP8RdUYTiFh89f2451cBTSFTTU5YFveaQlS/K6z49ApsD4Sun/E/rrZB9OOk7R/seXO1ULJiONuMDwtfzqyN2EBPuaNKJRAwccKFJUGkRpJ9NKIQR4v1O+fDa/Cwbb2jr8scik574/ZAVNV6vji9d3X5vxBoByV3kUWb93YiSRKX8sldQ8oT+uCedPTHjrNvWcmpvFQNWasc4Fj5Ilmjvfb/Dc8u4frV0dkTYgoc09O26PGW1f0pLzn9eRzyUG9LxwXB/yBxJ7sr7udvXbJ5QNQTE32V5ZAw6BgXdUcapoAgK37rIhXoOC+rOzD56aHoAMS/pMjaMckLjTr44N1RK4ugldwu0gi2gv+S8g/zSMWjLDraK5r14T3dLEokLuOWPlSp5yncLNT3vS4/31ahehz/pkImnsNmEV4I5v448Qtt/gt332562bQvI0GyXQBMXWWgTVE6nFCJJriVIBHUE2rAc/j43J+CrLrbebTXKAzmfPy1wdcZGhdLhF5v12YjYrSTlYOKgewyxyxfVTSZmK0j3rwtDo7/dz2fSS9bgW7uPHi6fWabV62rkKNlmxHMotu0OckR7poOiEU4M60ABVGuRkU5NjV+fGwcf2cX5 JJ/G4MUK b3NO3Jwl+AEgEj4r9vVpnAMBl8KOliZcJX9j5ZvLH66u6wUbkbPoDtCf9k/E7xubU5xt8jzUou8gtGP1HTtma+CWHYnARJ91V3GJ57XQB9X1yv2fDSAsfazYq2+GDt2E9z9bFWl/HUPvO8i50hnyD4gle+kikxMIdC6Wa6xczE4kZcJJ6uTr2IOi+SkuNlcUl3pIUH4nIkoF5VrBBxmhhpUCq+GRwfMF5MKQ9UlR48UoZTtBhv+482Tmt718dTkhdc0Bj42+BcL4LUT+wXDSRDmkPNb2VmbG33Q6uHSpviyZfTNUY4SJ0cP72YD32+nUC7imjotdtdD5yj9dvZEc6/HbJf3ZnfFLf8Hqx5x9mrvnK/q90sRU+2IH5N6NfHc19sKV3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --xYlUSbAm7YzipPhu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 09, 2023 at 03:45:31PM -0700, Charlie Jenkins wrote: > On Wed, Aug 09, 2023 at 08:42:58AM +0100, Conor Dooley wrote: > > On Tue, Aug 08, 2023 at 06:51:06PM -0700, Charlie Jenkins wrote: > > > Make sv48 the default address space for mmap as some applications > > > currently depend on this assumption. Users can now select a > > > desired address space using a non-zero hint address to mmap. Previous= ly, > > > requesting the default address space from mmap by passing zero as the= hint > > > address would result in using the largest address space possible. Some > > > applications depend on empty bits in the virtual address space, like = Go and > > > Java, so this patch provides more flexibility for application develop= ers. > >=20 > > This still does not build: > > ../fs/binfmt_flat.c:900:30: error: call to undeclared function 'is_comp= at_task'; ISO C99 and later do not support implicit function declarations [= -Wimplicit-function-declaration] > >=20 > > Reproduceable with allmodconfig. > >=20 > There is some weird interaction with compat.h. Moving the definitions > in pgtable.h into the #ifndef __ASSEMBLY__ guarded section resolves=20 > the compile error. I will send out another version with this change. Just be sure to run an allmodconfig build this time before doing so ;) --xYlUSbAm7YzipPhu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZNQcIQAKCRB4tDGHoIJi 0gh4AP0ZHirwBgSAjTZzsYgQWx0puWLpButSxiuoRHlyGjJHRwD8C6jANtDOeMif IiUgQCa5S8zKtEanNEt/wf4f6auvfgY= =E3pw -----END PGP SIGNATURE----- --xYlUSbAm7YzipPhu--