From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B839C0015E for ; Wed, 9 Aug 2023 10:28:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E02736B0075; Wed, 9 Aug 2023 06:28:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB3A96B0078; Wed, 9 Aug 2023 06:28:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7A478E0001; Wed, 9 Aug 2023 06:28:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BA5526B0075 for ; Wed, 9 Aug 2023 06:28:39 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8B831140376 for ; Wed, 9 Aug 2023 10:28:39 +0000 (UTC) X-FDA: 81104192358.14.F8C7526 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by imf01.hostedemail.com (Postfix) with ESMTP id A5E1A40012 for ; Wed, 9 Aug 2023 10:28:36 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SOcwuO0q; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf01.hostedemail.com: domain of lkp@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691576916; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=7BkdXzMbe8E7HjeOen5tIgMpm/gSnXnfLgzhZuxstWM=; b=cjBcUyZdYYWYuYzwAI1qCxhrh2G6/8Bg8RMjvteRQhulnFUjVg7p4t0ylyQ6p35CcfGaxr YklUwIojJMmdRa4qRpO8Xwvyy/JcqHFe86ehc9YVBdYaULJPBIidGEQtAyjvnK+Yt8wYk0 QlLv+MHRccCVNTOTheK9b8IiqkVVK38= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SOcwuO0q; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf01.hostedemail.com: domain of lkp@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691576916; a=rsa-sha256; cv=none; b=cbOXSkfePaNrsyNnl8wIRKelW4JRS2q6dyz+BM0qL4JNouNqSteuh3w+2aFyR0jVZBRk0s 8De2kqSnropNgwY7ukwUzz2+hPbafwsfptTible/cV7hZ/t8muSO8Btos2dihLv/fF7vyK OMO94vTgqtEYSKKlsuK3cov3h1f8PNg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691576916; x=1723112916; h=date:from:to:cc:subject:message-id:mime-version; bh=yeOT0cS6QMPvAXxUJ9nK2LD91TvI/FtdDjHmYUtB1Zg=; b=SOcwuO0qqZAzoQjzjrAil8ris65MeKVo+zfqMucyGPd2ZABBMOH2tq70 wXGcsMrEqD2kS8xjbS1kxL91+Hq8CSTISOfStRNOLRhCtMBwkELPF1oVp aFszlJz/tpuV4fm9tToYlUjl+AamKxqRC4EG8ScEOzwunlg86I6DoIdca k9xWNPSLBMim1MSNqmYFuSWVcDHMon8FobVgsJamdMZ7CoqrThXOZ47QB GhF/KfP60ORePDKPWm3Z0trbyMjLSOcNlnCKtox3XxdNKu5R1sSTVY6d6 x7Wdha56U4aOJVqLb0iAGJdTmJbsFak2dMZZWsIjez2OUPTn64sdTlihx A==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="373867946" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="373867946" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2023 03:28:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="875188410" Received: from lkp-server01.sh.intel.com (HELO d1ccc7e87e8f) ([10.239.97.150]) by fmsmga001.fm.intel.com with ESMTP; 09 Aug 2023 03:28:32 -0700 Received: from kbuild by d1ccc7e87e8f with local (Exim 4.96) (envelope-from ) id 1qTgQW-00060Y-1K; Wed, 09 Aug 2023 10:28:28 +0000 Date: Wed, 9 Aug 2023 18:27:48 +0800 From: kernel test robot To: Artur Weber Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Lee Jones , Daniel Thompson Subject: [linux-next:master 4727/8441] drivers/video/backlight/lp855x_bl.c:252:7: warning: variable 'ret' is used uninitialized whenever 'if' condition is false Message-ID: <202308091728.NEJhgUPP-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: A5E1A40012 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: z97zpmewg7sf6ars7zuetswswnsmc3nh X-HE-Tag: 1691576916-65153 X-HE-Meta: U2FsdGVkX1+ovEnDWWfVWC1WfgopuGUKLJE57QD+teK12vCZ6jhNuvwggpth62OYOZQ7cbgvhBK7y19g1ehhDg9+2KtVndIRBmWFloq04TOnrUuHf73+Js6xSWAyg4RGM0jwrmneQx76XVTlMQuSii/TowaY4leLpo+jxZgiVtMGMm/MAr0JFGCojjRtqZDNv6FnbxO+EmhS2jRa3wgkoz/sbhTuBf26Nd5QoqJO89no4fIpuILvWQ8kbr0EvPY3KuQjduIVQRxJ3BcvJJjRGEwCg/FUPGxhhAt4pQevNtr2vcmNeqUcqleA+4SZo8/JREPZgHsVfA5iASn9pLNOaJZDFjVtg79ey+ifCxgdlJKcbS6Lvx3NTeZnj4hTE5Q/hhN5peMgX+myTy4Jiibx/nIGwxp7QfA7Stn1jH02fmI246DLPMjgY4jq8FaLTDKdxRX5TW3crY6JOajdbIBzQ0fi31Em/KZ2luEgC1ml4KOsEypWVLRFRMuzY6VgYqj97wOtcrncQ5P+akGSGFCMH4MgA59s2jXcLjfGNOKuZGmOY1mkAW2dWGICvxqWFqIfFV0jvX6Zvh0D0F9UDl661bOZzMLBwddwjjr1YajgP5t2l9x+/3ZiHeh4UzreXDmy4O1UT4tHPEWTBaw/cN2OEogem+/5bsztP7b6vDEZRbVwSCinsnx6/Nblagt0HeoGNv4MzuYGr/V6DK9UnHGeudZo0xABodEyaarPO/EA1JEqBcRNsYJZDczSsLCgk1n5QcYPb1c7ikPpZdqlwHEKHZDuGhJNqO3eWqqOsKVQiEr/ndYfBZF2oERSi0iEKcqyMDCDNsxRAtAF1A1btHX7lWET1iw5L96aUtaEjwTTFl5Jl5xKm6VVsfVl0x9kJUQvaflVvObDufNZnNUZyehBpPrwK5ibBdIQqOIbZr0scGJYSvCmpsrg0puqnwNqYmcIoB7zBsiwBftuRkp2iSs SF0Cb6kM uu5z703kRmiKdVXhYojfR6Dq6c6VxfDLqS04AGuMeeZYLJTD2lw68oJvwkk8jVF+UAvCqTx2lhJqpgzogT4jmE1/sgaCdqXtHFdsLkJXN+QIOAS2EUriRv8gc07nJAX0L3wKsDtlqGnIn5OV6C1lH0WtTFVY1oso35ffFUN2fGys/3qxwFViLTkWlT+YBvSdMmibUNZ+HLWWaDACgqVx91amdr3n2Vx7fj+oqvvI0FIl8DL4GMNJdldeazkM02w3CLBZBjs0tuWxGJbEhZ7yHilY47dGTLPPBxraWWbZXEuq1XkCRY1D544xN+DhGid4v5iPzlaYHm+/PRuq/7QceNj/9fw4NcsuKoRabMLZlZZwNJhs/OSPhQoxEKCXVzOgPUYOBzh7T8aKL5VYW80zkwIRYx5cF9X/tIs4oKuD0nuhxwxTOGIuKHFjHLpa33tvyxpzuBvCG5TXz4XBE7sJEJw/vvnrKcBBorPZWcdtKK0lyUII5HWWe+SU0Q3yhbRhy8I3qXHnZJR3kjczqMnLC5gxOcoB6srok6Ggv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 21ef7b1e17d039053edaeaf41142423810572741 commit: 5145531be5fbad0e914d1dc1cbd392d7b756abaa [4727/8441] backlight: lp855x: Catch errors when changing brightness config: x86_64-buildonly-randconfig-r002-20230808 (https://download.01.org/0day-ci/archive/20230809/202308091728.NEJhgUPP-lkp@intel.com/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce: (https://download.01.org/0day-ci/archive/20230809/202308091728.NEJhgUPP-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202308091728.NEJhgUPP-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/video/backlight/lp855x_bl.c:252:7: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] else if (lp->mode == REGISTER_BASED) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/compiler.h:55:28: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/compiler.h:57:30: note: expanded from macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/video/backlight/lp855x_bl.c:256:9: note: uninitialized use occurs here return ret; ^~~ drivers/video/backlight/lp855x_bl.c:252:7: note: remove the 'if' if its condition is always true else if (lp->mode == REGISTER_BASED) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/compiler.h:55:23: note: expanded from macro 'if' #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) ^ drivers/video/backlight/lp855x_bl.c:244:9: note: initialize the variable 'ret' to silence this warning int ret; ^ = 0 1 warning generated. vim +252 drivers/video/backlight/lp855x_bl.c 8cc9764c9c7d01 Kim, Milo 2012-12-17 239 7be865ab8634d4 Kim, Milo 2012-03-23 240 static int lp855x_bl_update_status(struct backlight_device *bl) 7be865ab8634d4 Kim, Milo 2012-03-23 241 { 7be865ab8634d4 Kim, Milo 2012-03-23 242 struct lp855x *lp = bl_get_data(bl); 61c1c6147f69d8 Sean Paul 2015-05-11 243 int brightness = bl->props.brightness; 5145531be5fbad Artur Weber 2023-07-14 244 int ret; 7be865ab8634d4 Kim, Milo 2012-03-23 245 9f0a511f4a227c Shingo Nakao 2013-07-02 246 if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK)) 61c1c6147f69d8 Sean Paul 2015-05-11 247 brightness = 0; 7be865ab8634d4 Kim, Milo 2012-03-23 248 61c1c6147f69d8 Sean Paul 2015-05-11 249 if (lp->mode == PWM_BASED) 5145531be5fbad Artur Weber 2023-07-14 250 ret = lp855x_pwm_ctrl(lp, brightness, 5145531be5fbad Artur Weber 2023-07-14 251 bl->props.max_brightness); 61c1c6147f69d8 Sean Paul 2015-05-11 @252 else if (lp->mode == REGISTER_BASED) 5145531be5fbad Artur Weber 2023-07-14 253 ret = lp855x_write_byte(lp, lp->cfg->reg_brightness, 5145531be5fbad Artur Weber 2023-07-14 254 (u8)brightness); 7be865ab8634d4 Kim, Milo 2012-03-23 255 5145531be5fbad Artur Weber 2023-07-14 256 return ret; 7be865ab8634d4 Kim, Milo 2012-03-23 257 } 7be865ab8634d4 Kim, Milo 2012-03-23 258 :::::: The code at line 252 was first introduced by commit :::::: 61c1c6147f69d8dea31fd133d2ec0b1594c9a3eb backlight: lp855x: Don't clear level on suspend/blank :::::: TO: Sean Paul :::::: CC: Lee Jones -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki