From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AD1AC04FE1 for ; Wed, 9 Aug 2023 15:58:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7294E6B0071; Wed, 9 Aug 2023 11:58:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7008A6B0074; Wed, 9 Aug 2023 11:58:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C87B6B0075; Wed, 9 Aug 2023 11:58:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4DA496B0071 for ; Wed, 9 Aug 2023 11:58:00 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2905C120F2E for ; Wed, 9 Aug 2023 15:58:00 +0000 (UTC) X-FDA: 81105022320.23.F9FE862 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 53AEF40019 for ; Wed, 9 Aug 2023 15:57:58 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AFE0tJAC; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691596678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ltztflm5uh3qzayYTwLS8Tgqv2vBfXKuJ/QAANgymoQ=; b=3yMBEHvsQZMsniq9Frnkdox2x+Z1aBnreLlZkqoPCEosEHR++NX8mH0Hw1z96VHZuOjtLp aYTjBjOapuDL24ESy0Fwg3Dhb6qwL4lb/8VUm3+RsY0MwGP9MNLeaYaPq/McAR9kKusAao xxi/N51dbcM/2O4HAt2WGXVuzi/49NU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AFE0tJAC; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691596678; a=rsa-sha256; cv=none; b=e97oUH3BBXMM1FzDzqDYZjlv9mTAv54FKyvxhZvdzZXJlUgF+TJhoRGS6i2rn5aI8MMA+V KAE/sw7ysIOXZc0WJpiegAN33vdxtaZzqg8dSe1t60wIGhuOS6yJw8oOOabwYKivPlNWF1 Bj4/YfnSBIqbEo9XApSaM3Z4tQK+yeU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5FF5363FB2; Wed, 9 Aug 2023 15:57:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEE8CC433C8; Wed, 9 Aug 2023 15:57:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691596676; bh=BLJ8BG9cjda67FtOFMSOw2lof21Rwgd62y3h6CJUJXI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AFE0tJAC1VN3lHwsywzTvQMCtTkKwH+fzaHay423Nn8U4BvgbFPhFlDGPhv+CSPLy dFQ0xVpMhQ3C2M5foD/fbgkNjIR7VMHxas0FwdgXCZ4RBZmNRoRBLtdmPfwP64p4CR L1KLFjlwnPyYmvJ9g5BmRhxInIEwBnrizZouBo3g6eX8F8ZAnH1hnfnSPD6lrGk5TK 9rNGMty4rm4EuDy1vedzHwVAPS2NqLbaLW0knF3RHZVQHqjJb96V1TtEusFyVz0K14 VuLDs1Rym4oqY/gmU++wX3w7TKa1AFDz9Dgv9eLPqBx47m/DAmODVEOpJWGSAeViqX g//bmjx4l6oPA== Date: Wed, 9 Aug 2023 08:57:56 -0700 From: "Darrick J. Wong" To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , Benjamin Coddington , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v7 07/13] xfs: have xfs_vn_update_time gets its own timestamp Message-ID: <20230809155756.GV11352@frogsfrogsfrogs> References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230807-mgctime-v7-7-d1dec143a704@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230807-mgctime-v7-7-d1dec143a704@kernel.org> X-Rspam-User: X-Stat-Signature: faf7afbuaciggh5twwxoo1k3frff7br5 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 53AEF40019 X-HE-Tag: 1691596678-29705 X-HE-Meta: U2FsdGVkX1/8s1zXh7+/qcjvFcABQH+u2DxLrUT55UMrKpVKoqw4mDdw6mg3p703reWOiGlgSn1S8g6GbnIB70+tAic6lvuMSRJeBQYJDPqsPCWFOshSZZtbU+C0kvGpT7Ca/+vVdhAFqscaPdIulNmveM6GxylYh3HtJVio+eTCOSmQ9lmUhbr9RKrybFzqRTuzRDWOl5vB70DRUeihsqnTFH5/jipp07dMhtRV6p2DT9DtZchWpPCp9/PswxWdF7ibHOWZpaKnbJtlrDOtdu7TGgK60Mp3vEGrdPjkINC+r926sFmhBsz4Gil8EVYxks4XYNKFCTPFq5OvgSvxbjhTLdGz5TiXr2UI+DF4qfBVhJE2CyTJ/siTy5Cc1nFNFguz/jEvIHJm4lFYa6ISa/1dosAgiapE/dDT/ESLC4F+iOB9EeG7QS17qFgPYF0HtBNyMRsSNQLEX7Lltdt6Y8EFuyMEKh9zu+sfL78JhGyXQJqLeE+2k+ckiFr4j60vX3e35JXCgir61Q1yI/pWVDeiLfOddfx8m1vvnVZnG5FK8gYMkBW3+mV4EjKTljVgNMeXz3yClfaVf+t1s4QFzMP2w6yakNKyAndMzDyqFLn8OfIwQM5jgmOtpJ1MZ2bPQfz5OxiYKr14C7x9cNJMFXm7R/AFddC24FvTVKfJUy3NtyymBUOHfslK46Z4BBYcbXj34PBaswKG6Rg3yM7DRCI39hcxshUcs8YHEOekr7irHfz5jbilO7riN+Z/5PrMykNqjEMGcBj+tcEGAfFXiCe7zIJK8IxcVrn6e1v/JyBcJeFCoJPx7CW1d6AGrRqIio/r424w2csAgZHRHUu0NX4iBnk3UV2WKf+z2RvBU9KFi2BwFz0fWmVHHXzPMtYJagVAadig+tnLsOjUKS+FYK6+TlUZckP4B6ew7qBJPRELufbxIDo9vsrIG/m6df33cKXh4A948R53qBp/POY D8bG479v h1vEU9RGXeRFuqrWYFRk2oPk2mF7PEH9iOCdbAWENJfIoROfQVu8Teu/pXz6q0tea7Hn3HXaEIVa8MUmekYFO0SQMHnUdlNcVVYYLO4fpJ8pRdHrvFfz60aA7XWXTOZOkH2RYxTw+PeDEyjd3oRtGreULgtoVu35ryiWR7K72yn6gRVXOyp9Z7Bpa/T+ca4QctBCuDBjIiqzj4CxWJWymUKoVQ+dDz/bhw97czRGQngqGQdJuVsCF/HwFTZOO3ZSChY95mBJMW9tlszwcJ1j6VHfK/bOBqX/dy2iT3u1KmW/vXN1Jp44yJC1fPY+6HrKT0WeLDydrOqSXaLKEfxTij/AU1b4WmIreJS8YtGrKpGDudwb44/2Iz6AjlArdVVxg2bJNYiKM5Jx5byg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 07, 2023 at 03:38:38PM -0400, Jeff Layton wrote: > In later patches we're going to drop the "now" parameter from the > update_time operation. Prepare XFS for this by reworking how it fetches > timestamps and sets them in the inode. Ensure that we update the ctime > even if only S_MTIME is set. > > Signed-off-by: Jeff Layton > --- > fs/xfs/xfs_iops.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > index 731f45391baa..72d18e7840f5 100644 > --- a/fs/xfs/xfs_iops.c > +++ b/fs/xfs/xfs_iops.c > @@ -1037,6 +1037,7 @@ xfs_vn_update_time( > int log_flags = XFS_ILOG_TIMESTAMP; > struct xfs_trans *tp; > int error; > + struct timespec64 now = current_time(inode); > > trace_xfs_update_time(ip); > > @@ -1056,12 +1057,15 @@ xfs_vn_update_time( > return error; > > xfs_ilock(ip, XFS_ILOCK_EXCL); > - if (flags & S_CTIME) > - inode_set_ctime_to_ts(inode, *now); > + if (flags & (S_CTIME|S_MTIME)) Minor nit: spaces around ^ the operator. Otherwise looks ok to me... Acked-by: Darrick J. Wong --D > + now = inode_set_ctime_current(inode); > + else > + now = current_time(inode); > + > if (flags & S_MTIME) > - inode->i_mtime = *now; > + inode->i_mtime = now; > if (flags & S_ATIME) > - inode->i_atime = *now; > + inode->i_atime = now; > > xfs_trans_ijoin(tp, ip, XFS_ILOCK_EXCL); > xfs_trans_log_inode(tp, ip, log_flags); > > -- > 2.41.0 >