From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61639EB64DD for ; Wed, 9 Aug 2023 12:40:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 008778E0002; Wed, 9 Aug 2023 08:40:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFB0E8E0001; Wed, 9 Aug 2023 08:40:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEA368E0002; Wed, 9 Aug 2023 08:40:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D1A778E0001 for ; Wed, 9 Aug 2023 08:40:49 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9B43D160E5B for ; Wed, 9 Aug 2023 12:40:49 +0000 (UTC) X-FDA: 81104525418.03.6EABB6A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id C6EA7160027 for ; Wed, 9 Aug 2023 12:40:47 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=a0vBC+6i; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691584847; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C8Y2o5AzhkhI8DEQpFJUqsvj+6pKuaTsxAp8br6fZ+s=; b=KVf1yt7QG7s4r0uNnYB5Mw43pSya0ys1fzhqknhg3Q75ofPfoYbotQrB5yB3nmO8peQzYs 9hkHkb/+adj76/UIGdZFpsmxMABNNo8XIYXniDkE83Z6/lApmjORG5TdHmEShA3oTbG5kr wOwoSijt77x8KRi1JEHeG7lv6WDiQok= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=a0vBC+6i; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691584847; a=rsa-sha256; cv=none; b=ZCFUf7VX6bcue4bDbsKBdoKyr1VIA0O6/W7XDWJZWIzhcuvWwfO35Ft1p1l8sx5B7RUm6c /mUvUP/ESgclRtkcLm6DwdmqWOXWKTvGg5tSCJ+RVKrSR8FJZhHqrrtHOjTTh+b6kQ/poz B2VOym9WspqJ8+aQ3n/Gz1Ea7YyCqTg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ABC8463248; Wed, 9 Aug 2023 12:40:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3645C433C8; Wed, 9 Aug 2023 12:40:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691584846; bh=qkN4hCfczhkVGSFHRn3lAEAKDnEVv6B1jgLozsEWEqY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a0vBC+6ieEcnyA5uNIRNHO+91hD1X8GUNViLzSjtyRwkAN1arAXA24SpDU40Yhymt GN8zNpND43HrjlblgvK/VXtTia1wyhVTSX5uYQemANd8ScmrfcTaWWQ7CvZOQkCcij 0YZaHS8jxP+AeuGxmBgDD0MQSF1gfMQJzhMyR1HIZG2WlJRbEIB1HPQ2J4R/XDxzlY 4rSb8KCOk9O3vvMc8jPyqWM4c93LvOknSzBQsL6xFSmqfJt4H9/j/Ao8SrgprJ3W4q zdFfrly18GUz/BWNYZZo6PwJtX9DmMHXTYsloIGq7AkaPbLoqkWAKv1N9LKwerXlLZ gg/bZ55/SvQaQ== Date: Wed, 9 Aug 2023 15:39:51 +0300 From: Mike Rapoport To: Kefeng Wang Cc: Andrew Morton , Tomas Mudrunka , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, willy@infradead.org Subject: Re: [PATCH v2] mm: memtest: convert to memtest_report_meminfo() Message-ID: <20230809123951.GL2607694@kernel.org> References: <20230808033359.174986-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230808033359.174986-1-wangkefeng.wang@huawei.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C6EA7160027 X-Stat-Signature: xjgsa1967pafpmbo7ck4m5zju6dfnfd3 X-Rspam-User: X-HE-Tag: 1691584847-38866 X-HE-Meta: U2FsdGVkX19FmJOZld6bsz6swTz1MhsTU93MevuT1I1mX4uheG/X48cqPhjsLWbg7tOHAvcUgExeTxIhIrkaOyQZ1GGCE30Xk0oBDClqNhfbnjD0F3Yy8f0P1GT+gMhQEoN8Wil2Sj13S2OOuCIRErkWdDOLH6+BEwlDL4NX53GhPTgPblFhv8ZF7uRrnQxjWCkd/TD0eb9Q/TITkV610lO8rLXfxr1+JtgfHf+Y09D4HmV/JrQDymdVYP2KCJIQX2LfbZMpD6hlUv1ntIJsBXLhI7Wa8l9rTz99Sl1W+tcLPWGsrJVy/3aO5gdbzsUAOeX0r1piOwpZH55+Tpjagpjfix2awg5UsbnzHGYA4n5xN0nQhv+Qa4J98K0dpYP13gQMpRFe6pP1ZjFvMLhMawKHaFTRtqrnr0nmElfTaZAJwpAwLG8uzSrspEa7smMFLT/ODbOJTOmdKez+Q3ycUcvSfxRrV0Uny6b0ytp5XD5a504fUR0eSBqH+vgP1wD4QrSXYKAuc1rw0EiYf1g8URzK4qmE870SeczweO+y8DzOA2cOPG5R5zNDWK7I+RsjG+3+rRUjh3c2ZPVi2hsWDb93DaKe6+Qxdqva0Kf9q1+O9jwpdnW8QKmpjlL3uCKZaHZw9GLIx39iqD1elPexA32wmKkoRPr7P/d6lodsDO8K5W40EFtQryo3T/qzF4WaA0wE4w9RZUZ+eRo8IfrGLnZRNoQQ2rqlpXicsrr+vw9Y3CgM3fnd3ApCwGWTB0pI2cNDr3ozdfcf1oPjJ8hna58lkQ68+piem1wrysrrZ+a9makGA1irElyYXvX7VHoJom1YbpUVo4inX7PPYNxf4d1bwqyCAlN/tLUGp8JB9Ut2Z82dW8Ji7xVqifwCsFJhIFRDWH26WFO1t2BMu/yK1mZ9NFnVLJe/jLrZlKchDTYey27apHfh1sdd6qMSPxyGfN21+PfBfHOBphvFNBv AlDdSswu IfOFhgsk0qGttLissP6C6ttQ4M7MC6cIMnfTuD8sL3LZkKa2oMo/BzQK0js1Kq9LzCKmCtq4J/V1I/HVbzIHU2gQqF6qMpwgyH91bkpm9cpvxJhrXlUls7eommfvHttDB/YvNDoJ00X6W6EQG3rn2MwT/9d2JkAA24jh/7gO9f1/oKoFzr63P4FI2Ew8B1h3SNmNmP0JL9WgjoniRPfLKd0U+bB4BjAQt8ULOqjxKV9EDfZND/oRoKRyG4uOjKKDV8uXQinnWKr15cGOXHmGQ1ojiaCpki2sikwARI5vcNk2g/qf6/MpRem4x53goViCBL8d9FNyb6sspxunu8WK6u2FQuVBdJrTsprDjhNgTnsxoVGbJG30NHj1LuRwBDnLBtT1bJ1/HebzFGDcrQWMu6kDid77z5qGJ7oM7xJDD4jC070PomTyqTjBOJ8Gb4AcpriO7RPGScPofaT0O4LnfBbJcrIDJ/LLXrThLi6q2+fiPDtY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 08, 2023 at 11:33:59AM +0800, Kefeng Wang wrote: > It is better to not expose too many internal variables of memtest, > add a helper memtest_report_meminfo() to show memtest results. > > Signed-off-by: Kefeng Wang Acked-by: Mike Rapoport (IBM) > --- > v2: add CONFIG_PROC_FS check, per Matthew > > fs/proc/meminfo.c | 12 +----------- > include/linux/memblock.h | 10 ++++------ > mm/memtest.c | 22 ++++++++++++++++++++-- > 3 files changed, 25 insertions(+), 19 deletions(-) > > diff --git a/fs/proc/meminfo.c b/fs/proc/meminfo.c > index 74e3c3815696..45af9a989d40 100644 > --- a/fs/proc/meminfo.c > +++ b/fs/proc/meminfo.c > @@ -133,17 +133,7 @@ static int meminfo_proc_show(struct seq_file *m, void *v) > show_val_kb(m, "VmallocChunk: ", 0ul); > show_val_kb(m, "Percpu: ", pcpu_nr_pages()); > > -#ifdef CONFIG_MEMTEST > - if (early_memtest_done) { > - unsigned long early_memtest_bad_size_kb; > - > - early_memtest_bad_size_kb = early_memtest_bad_size>>10; > - if (early_memtest_bad_size && !early_memtest_bad_size_kb) > - early_memtest_bad_size_kb = 1; > - /* When 0 is reported, it means there actually was a successful test */ > - seq_printf(m, "EarlyMemtestBad: %5lu kB\n", early_memtest_bad_size_kb); > - } > -#endif > + memtest_report_meminfo(m); > > #ifdef CONFIG_MEMORY_FAILURE > seq_printf(m, "HardwareCorrupted: %5lu kB\n", > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index 0d031fbfea25..1c1072e3ca06 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -594,13 +594,11 @@ extern int hashdist; /* Distribute hashes across NUMA nodes? */ > #endif > > #ifdef CONFIG_MEMTEST > -extern phys_addr_t early_memtest_bad_size; /* Size of faulty ram found by memtest */ > -extern bool early_memtest_done; /* Was early memtest done? */ > -extern void early_memtest(phys_addr_t start, phys_addr_t end); > +void early_memtest(phys_addr_t start, phys_addr_t end); > +void memtest_report_meminfo(struct seq_file *m); > #else > -static inline void early_memtest(phys_addr_t start, phys_addr_t end) > -{ > -} > +static inline void early_memtest(phys_addr_t start, phys_addr_t end) { } > +static inline void memtest_report_meminfo(struct seq_file *m) { } > #endif > > > diff --git a/mm/memtest.c b/mm/memtest.c > index 57149dfee438..32f3e9dda837 100644 > --- a/mm/memtest.c > +++ b/mm/memtest.c > @@ -3,9 +3,10 @@ > #include > #include > #include > +#include > > -bool early_memtest_done; > -phys_addr_t early_memtest_bad_size; > +static bool early_memtest_done; > +static phys_addr_t early_memtest_bad_size; > > static u64 patterns[] __initdata = { > /* The first entry has to be 0 to leave memtest with zeroed memory */ > @@ -117,3 +118,20 @@ void __init early_memtest(phys_addr_t start, phys_addr_t end) > do_one_pass(patterns[idx], start, end); > } > } > + > +void memtest_report_meminfo(struct seq_file *m) > +{ > + unsigned long early_memtest_bad_size_kb; > + > + if (!IS_ENABLED(CONFIG_PROC_FS)) > + return; > + > + if (!early_memtest_done) > + return; > + > + early_memtest_bad_size_kb = early_memtest_bad_size >> 10; > + if (early_memtest_bad_size && !early_memtest_bad_size_kb) > + early_memtest_bad_size_kb = 1; > + /* When 0 is reported, it means there actually was a successful test */ > + seq_printf(m, "EarlyMemtestBad: %5lu kB\n", early_memtest_bad_size_kb); > +} > -- > 2.41.0 > -- Sincerely yours, Mike.