From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 598F1EB64DD for ; Wed, 9 Aug 2023 07:06:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0C5C6B0075; Wed, 9 Aug 2023 03:06:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B95EB6B0078; Wed, 9 Aug 2023 03:06:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0F228D0001; Wed, 9 Aug 2023 03:06:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8D5126B0075 for ; Wed, 9 Aug 2023 03:06:55 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 53E51A0E43 for ; Wed, 9 Aug 2023 07:06:55 +0000 (UTC) X-FDA: 81103683990.15.F7151DA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 816C3140014 for ; Wed, 9 Aug 2023 07:06:53 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bD7f0dTI; spf=pass (imf09.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691564813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bpR6NrRrv+px6P4RAp9BUFvi3teg78SPomSPPQq/HRw=; b=1q8Y9YY2J58lEymYbrOv7h9xX3pc32JQv/xxdLF/uCpyzXbGjloUShOql9yJLnOJvmVySb UIepf1/dICE91M/7NGYAnYU2WEzLzd7ZMragtwNr56dYFNaNi1mwPA5UPXOe70tANSVDkm 4zz9IIVZzKXZwd2tgS5TNrQ5v1EHt9k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691564813; a=rsa-sha256; cv=none; b=vv3Znq700FXaFlrAPd/lQNYciEy2QhmlHw6JkOYnICJr9oF37mOmmSFGhlcKxvcBoH7orD ZmYLXcfEIFdt24o3P7L5jDmw1TYTC4Ih19E4k5niCI0s3JFYDfH/6juxttcDsOuknt0Noi 1C7f8pyoHD1/dv/hkj8No8t445XsOeY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bD7f0dTI; spf=pass (imf09.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9B61A62FBF; Wed, 9 Aug 2023 07:06:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46BD8C433C7; Wed, 9 Aug 2023 07:06:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691564812; bh=LyptcIlHZJMPRLgCQdT8M5vqzNKCvVA2tglx+SSzKhk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bD7f0dTITrbaEv4ks9HGhx0VVGQl2go0/eu1op4nP82j4N7TgX5btWqWiaSGoe8jp i6+z7Q/Jk2DuDRVzKbPo4bN2rJnb7ZSAdXE4Z0xYd+h6nr/dULJQsuanMXc8U/mPWC durewToMDZYiugVbqFDpM/vlNxIknI7IjiKj4iWyBj6wWmzWhg0/t+ygbJ1TK6LZ+2 DAg/4gaYUGbCnyrWc2K3wnSswvzR8b++oY6In8hF21Owe2spxR27o2A1Ew8ijOuuN3 Wo+4rLZHSLxhk9EzIXmcSquBg+Bnp2nKOE70h2bjG7fT6iPfQRAHqxOjlzas9G4WAl a1bfUfvPCKxNg== Date: Wed, 9 Aug 2023 09:06:34 +0200 From: Christian Brauner To: Jan Kara Cc: Jeff Layton , Alexander Viro , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v7 06/13] ubifs: have ubifs_update_time use inode_update_timestamps Message-ID: <20230809-handreichung-umgearbeitet-951eebed4d61@brauner> References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230807-mgctime-v7-6-d1dec143a704@kernel.org> <20230808093701.ggyj7tyqonivl7tb@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230808093701.ggyj7tyqonivl7tb@quack3> X-Rspamd-Queue-Id: 816C3140014 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: q9fwhzozoppxjnc85nki1z315q9hdfco X-HE-Tag: 1691564813-906169 X-HE-Meta: U2FsdGVkX1/IcRfg72l/YUbIWY0NAQqIROkPFDKfl3cAVNsnCGYQsI/clG+kfML/QmFsscZAUd1J0IPmr7Ov4ZL1qCemjsUox5nD28sxW30bwkGVUZBnJb9XE7ra5qUbVTkpLsBQAgfWl9M9jrbgr+amk+WkfsoErhp1JhK8XdjQKdr+dXCimYkaAMhNRwTnAht0LUMkd9mis+Z87JDi7hVB1m1wBBA8ogsZkyslRC8nxfXzBlXtHHvGDm7Nrdi/k3WQj+J8QTiZ5K3VVSBsL33IM8XUjBOSXKmL5cik3KogyWyouBFbA+2kqq3X/gZxAwcWcK+ruMyImkIUi/DRaoJjB8PPbvN6ydkYaRAKC0bPbnZ7XhIyYOtZhJON619XswbTYyv9TKpAEn6QmLDHsb2mbGzo7Q5jRsg1p3ZeUhC8CJnVEdEjQF1Fo0ko8WVSlRfTjWo1rR4xC2uxiSjEB8pHXmWNFTe2SUA25uWiaKo70rZKT6nmmh54MZ6KxMH3MdjShh3c6jGthxMXqYHaRiF+/HKS22Ldyg6BZsTdnEssNx7Lcb5XdU+iGMR4oKoYGgwSynUZRrrXiu2x5mE3dLyahANVoBJNbaIUxmQKelBVdH+R2iwWJ9vTCH402za8kv2Yb0Q90Hl9aNi/MV2gh85K7sRlhKwkme9SPorhbsXyjccvfEiIIfOVCKg+8LWG56w0XhFmAUSvV19419rSgylCPSkQigUPQGlvnUND8R72LAqi/cEqN/oJ1w8yROrGVLVMlNmhRU1mHfuBTzASDpIh9jHDoKZvywIjPMZbjk+8kLQGZw0F5rHEb5bXVMrM8+1hjxDz8MRQ7VR5uGD88W4oXJRQTZi8edoK7pOqrxt1oJ6RE+2iuIexRj215TaUZNIbLWCA2ItPAxVkO5cqGjGDjDrCo3tt0WG8SD0QvKEr0wS9/3Y8BWGKbXYV2dVDIsAOQVGTXTfuagY6kbY 8Yw1J+ft 5eaCw3IFrbwS7hy5ixpSXL9zgFN4RxcZx5UVYs32yRztvGp4IKeANGQ6WS0t4Xkkv/i85QlcLmDz1iLbbScilRk011Z4TKN0HUoDYaEfIb8AbycxHHZuUr2yuL2Ko5USJQ8aXowxm87UFQMebhLwRPhe1NGLXNLvXYY1St8tMDARnFLGC82uJSYYLhp298bKFqE4pymg8roDtIQgH19MVyneGNY/OWWXHedG//GJjclRvb4TI6sELalfT2OuGUp6U208H93EcdPOlLW2e6ksGKE9DXObS7Y7Tuam8hAgxMJkyYWbkZmhauR1mLjxLbHsOjCH/jF7JDxB4nxv3bmVTDeeaGPIMI5zezXBrv/ygml0EGff0xbb47f5eabnVn2qnUREbLcyvWWYCB1k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 08, 2023 at 11:37:01AM +0200, Jan Kara wrote: > On Mon 07-08-23 15:38:37, Jeff Layton wrote: > > In later patches, we're going to drop the "now" parameter from the > > update_time operation. Prepare ubifs for this, by having it use the new > > inode_update_timestamps helper. > > > > Signed-off-by: Jeff Layton > > One comment below: > > > diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c > > index df9086b19cd0..2d0178922e19 100644 > > --- a/fs/ubifs/file.c > > +++ b/fs/ubifs/file.c > > @@ -1397,15 +1397,9 @@ int ubifs_update_time(struct inode *inode, struct timespec64 *time, > > return err; > > > > mutex_lock(&ui->ui_mutex); > > - if (flags & S_ATIME) > > - inode->i_atime = *time; > > - if (flags & S_CTIME) > > - inode_set_ctime_to_ts(inode, *time); > > - if (flags & S_MTIME) > > - inode->i_mtime = *time; > > - > > - release = ui->dirty; > > + inode_update_timestamps(inode, flags); > > __mark_inode_dirty(inode, I_DIRTY_SYNC); > > + release = ui->dirty; > > mutex_unlock(&ui->ui_mutex); > > I think this is wrong. You need to keep sampling ui->dirty before calling > __mark_inode_dirty(). Otherwise you could release budget for inode update > you really need... Fixed in-tree.