From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19623EB64DD for ; Wed, 9 Aug 2023 11:37:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 582B16B0071; Wed, 9 Aug 2023 07:37:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50BE06B0074; Wed, 9 Aug 2023 07:37:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D36F8E0001; Wed, 9 Aug 2023 07:37:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 301D26B0071 for ; Wed, 9 Aug 2023 07:37:40 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D8221160D82 for ; Wed, 9 Aug 2023 11:37:39 +0000 (UTC) X-FDA: 81104366238.02.2BDE3BD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id 200D01A0024 for ; Wed, 9 Aug 2023 11:37:37 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nrzJgK9G; spf=pass (imf19.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691581058; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wVI2oamnAPooVwfMulS+xkRGHcm+/QA5/yozlwWPwEc=; b=Bkh2/OwnAoL5/11h3vvUZbsFxhIEgYUrFlVyDp+bAwLXmnKOO/OhDkrtJgESWhC6f2+wZ8 7FWGAu/Tj8JbS1nrBjjEZ2zSDyMsidCdD4TSmZ11plV2cPQzTbcd13svAibdjPNTUUdMCV 7G6OsDVvh0WLYwsewkXDC6yVVeUkauw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691581058; a=rsa-sha256; cv=none; b=BEE08uF7pD+ZdYLP+7IVo/YWz0ehyhMN/rBrjkVtqeX0BzSjlpYnaJGbKPsJCVNAyVENlQ rEZxNQgOWNdTdY5jNhwbacH5Cfh+TySpfD0LCGkPnQc07+EQesgmer7mBFhu27D0/Ci4fv J2bufOxm4zXeBIwiAMqt+eNoBnB1Z5Y= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nrzJgK9G; spf=pass (imf19.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2C87363577; Wed, 9 Aug 2023 11:37:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A193DC433CC; Wed, 9 Aug 2023 11:37:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691581056; bh=FJoooeg67aJXJ8sAVmKmUGj9XYVpvc9JajYCjM5Bi7g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nrzJgK9G81CHt7hGXMFo5ihY80acXwrKdKHgIKVPWAQbJjH468Az5Wnc6YkmJvfiW PnbOBOfth+0IqNCdMzVP2PSa62X1vQWb3loqsYgkkNFMI/k/ucmeAC5BFMIAa5xZeP V68HUgZR5F6Xxa59UXj/Bt2Z7/Z8bi3+svuDOToxUyy+WFRE8PYL/+BCd9z7AsuY30 vSZDM7R2rjgm1ohWWQtCRNfH4K/MysnbMUTbTuoVnxCTGFQrb2DbfCY0epFfM6gIuW jS4Gox3BHI61SrCp8PHjUaSuDiSox1gc71h3tppcVJ+Rnhr5PsxxiPkFTQlu9ESj29 97nn65CCuUs8w== Date: Wed, 9 Aug 2023 13:37:29 +0200 From: Christian Brauner To: Hugh Dickins Cc: Andrew Morton , Oleksandr Tymoshenko , Carlos Maiolino , Jeff Layton , Chuck Lever , Jan Kara , Miklos Szeredi , Daniel Xu , Chris Down , Tejun Heo , Greg Kroah-Hartman , Matthew Wilcox , Christoph Hellwig , Pete Zaitcev , Helge Deller , Topi Miettinen , Yu Kuai , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH vfs.tmpfs 1/5] xattr: simple_xattr_set() return old_xattr to be freed Message-ID: <20230809-freuden-genom-9a00d6e5158d@brauner> References: <158c6585-2aa7-d4aa-90ff-f7c3f8fe407c@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <158c6585-2aa7-d4aa-90ff-f7c3f8fe407c@google.com> X-Rspamd-Queue-Id: 200D01A0024 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: rqo3nkj17jezf88odw7eyx6u3psfdi7i X-HE-Tag: 1691581057-124673 X-HE-Meta: U2FsdGVkX19U8LXFl08xV6twj5e98DjG/xh5XrzEWipJQmWsNfv3xUuQmS76kgvviB3pu8pcq7LVdR6T4JJvuyZ1YC+WeowfOaHuBgz9JnVkU5XuE5y6ru3+5M/395T0BO3LI+cpB5jtEmhtzoec9OpPi6pP5TQh2ST3JRHfX7YRER1vOp9HCaF1a49IkY1G1ueK8ScP1h+uv3Lniu6XZSE4IRM4IX/UAqLyCpRN5lCz7ZJRqgn0JJxtXTeWez9LQDwG0xUkuvYipjb9FFfbkPbhWfKSbaXWN71nSjnHOxlHNLTTyXZcmYMieJ4vxG1ifVJZcPHOctglmL+stlEwJ+3g//BX5TaaRhlgMfs5WCep6lO+GpNKhdt9KGW89G9jiYDdOFVd/21Mi5R6NDBbQuepO1Z5cQJ+xPDkOV3MXEUAfXIhKdHTy73KUj8yY/tCXyXHic4typJGfEnwmmwMW+anP6Nh9tplWFNbiKfPUiVODceVG55IBFKv2VY4dtfLoeHcBsh+1BaZSk09GoDxFAcuyMRfzRcMsrTwV6ci0AvGKD5WSHpbKl5u3S55nT8fVZ+JgZS+LPGR1C1aOikYlGojWmPUZKhflMn861yolVG+wiO55zOaE9NDWU8md8xQ6jG9KuSrrFs1D2Lscuasc0bcz86xFPkO6nwkSOQftR7QWvpFaSLJktdLW0bUmWeWvaN/BPmbIGchhsozqVy35Tot64D9Yh+kY2ZXIvXkDYKV2LgexfgpakjpxAa+F3fuajiBlDBk3etcTE44MRktOkqry3F548XjyLTKfBqbSmFZSl4blSfHickQnXb99IrQJrd9KqsgpLHtcE5cxWoqRMjbvIUFXAP4wRTmv4PdQEKi2sP0sem6fMboQZcFiUfTjyDg0dlpbe/oEEdJaJzZIvDEui6DJ+dI/UKDyp63lH77CIttAvNArjTYZNzZBohHStuYCdJO0LfRFMK/iuu p/hMTw7x w5y3Naa1s/b31hSHYctg3W43IgVvQgQzP9ND4GhgHTxWrtaV13ZShCNIVzdT4SPIbvo/yhIfHfFgzcNMzMB9S7TPGFsP1GwIIe/BjTTafSk0yVHGTQGsC3qj/qaRu8nc7CbMiOynyy3pAFI6rX1RJ+9YflFNinmhQUd37lNkJ6GirCCyVmMrDCOmAu5M5rCYxSwmj+emV23JIsNimF+putQvBwEeLIkzX8hwiwMPhwAI54+0rgmBFpI1C+qj5IR/4/5LlBFk8IobYTbB62dF2mkApYLhAtD5eiF7i4wQFYwNBkO3Eop02Uq2ciuiGDqwntYZxEe04ojj0/yixbv4DcpLVhB5ghoL9/h9BuJUqQRkxBAqqRz0SqUyh+omaNjgg019vPCEBE8t/69aJcjpWEUbUcnS4itiPkYOm1B85FKMnFqO8CGW0FmTsTdxd4l9h+vDRB6gGvi24dYl/gXLdAQadJGLFU+SDJ633 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 08, 2023 at 09:30:59PM -0700, Hugh Dickins wrote: > tmpfs wants to support limited user extended attributes, but kernfs > (or cgroupfs, the only kernfs with KERNFS_ROOT_SUPPORT_USER_XATTR) > already supports user extended attributes through simple xattrs: but > limited by a policy (128KiB per inode) too liberal to be used on tmpfs. > > To allow a different limiting policy for tmpfs, without affecting the > policy for kernfs, change simple_xattr_set() to return the replaced or > removed xattr (if any), leaving the caller to update their accounting > then free the xattr (by simple_xattr_free(), renamed from the static > free_simple_xattr()). > > Signed-off-by: Hugh Dickins > --- Seems good enough, Reviewed-by: Christian Brauner