From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6411C001B0 for ; Wed, 9 Aug 2023 07:04:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A5326B0071; Wed, 9 Aug 2023 03:04:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32DD08D0001; Wed, 9 Aug 2023 03:04:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A78A6B0075; Wed, 9 Aug 2023 03:04:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 065296B0071 for ; Wed, 9 Aug 2023 03:04:34 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9C6001A0E79 for ; Wed, 9 Aug 2023 07:04:33 +0000 (UTC) X-FDA: 81103678026.25.91CE120 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id E177C180013 for ; Wed, 9 Aug 2023 07:04:31 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dm1BfYtz; spf=pass (imf06.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691564672; a=rsa-sha256; cv=none; b=Ui9+AYyWHn9ypkJhvUDeqMkVYgawlb7sFxEoQRVHga7rk5lK1/C7zYw9HqBe5JYqr686dE JiX++8jFn4YmLYVFS0CXShYQTQ9Tcw9eLWxyoTt7mjwNm92DaDcw9Taoh9J64ChdIeUNq4 F64X9fHjfuIVllVG1NvCbPlcxPQr3r4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dm1BfYtz; spf=pass (imf06.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691564672; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DH4ItoPl4t9BDzY4p84Kc5DS/kvp/4jxDQStke3yeoI=; b=vHgNSzTNKF1tpPWf0zg25c4NgcAumIUfroZiJUHcQ7Z+udtVr7SxhVqQLkbC0vrZIfmgDM ANR5vuVqqbkBX/+q+yUTBFJXf803g16m37+qmClmh7fdiuFn71OcQVqVVigljRfXzZNN6E riGFTgPeK8TeQJWcVhilLR/StBtudAA= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 012D462FB3; Wed, 9 Aug 2023 07:04:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF415C433C8; Wed, 9 Aug 2023 07:04:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691564670; bh=mNaI4yIhrZSJhUwcMni6JCN62HgxRgb2ToogP2H4jFU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dm1BfYtz2dqQMxa4y4K1DetMu3X3Ln+bwz+2jEemWCBc68DqnWDXfI9TyuC86JRyc OV6+7i/vF54n6ROMNvy+VNt+3Tcbr5mPPxWG7+kZZzvdk1l5Y2fXqdyi4kiTIEHp6R c+NokRM5ch22ngFHcUfi3IxiA2Hed3py0L00cGbjgid38+MsphBbYkHDRv8n5kfv6l 165HU85tqTN8dPjx7l1xQ1d3Tv6OZoFdRY/kHWh7X900UpXqc/s3kp4a/FPaL7/Rze xRv3G8HkDEWg3uieFtEQ8pvVu174WnaDQBFW7zKSqu+mNZR7+LKPBNsWLcV/CsHS/4 sOc78sTonZdgw== Date: Wed, 9 Aug 2023 09:04:12 +0200 From: Christian Brauner To: Jan Kara Cc: Jeff Layton , Alexander Viro , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v7 07/13] xfs: have xfs_vn_update_time gets its own timestamp Message-ID: <20230809-abartig-lachen-df1965c6b37a@brauner> References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230807-mgctime-v7-7-d1dec143a704@kernel.org> <20230808093903.2cg5wwbwbvflkeph@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230808093903.2cg5wwbwbvflkeph@quack3> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E177C180013 X-Stat-Signature: uzwqqout854kon1m453m4as8k3e96ip3 X-Rspam-User: X-HE-Tag: 1691564671-168134 X-HE-Meta: U2FsdGVkX19DOczV6Ev44hUCXtvrUeJQWDvBcF7eFiI5qrUdLkpv4mReaiPuVEAMuNGb/V3Dl41+Ommyk2Hqu7NNq4HzqnR017zmLfDJAivSfTVM9pnjULB+j4DYz7NckhvAya9cRmgDn1Ae7nqpgryS7bUmr/tVCWwZ/U/6Cb0WzyI8vZGyAzSn9sNVb2erqI8CUbHqSSZGRBqtTJimdvUyWXPB72HnxcoZrdQwZGxCIIS7zF/QXmiXV+Uwpc12Mc8xmo184kRdA63k3VrFIR4xZ9C4SCppoyYzwPt3KjUEhTFalDtsn7bWULgsBo9VH3v4PirnmP24d9rKO7VHkP9y6yL8dh2dNn3VUgCHKRzyl1lKJI3Ku82AU2KsUq3jB/ynD4EkuiutOHNdLKmo73fUT0Ol0vfXb/smnUFIb/vDsKge2v5RnbakicbzcRx977fh4q1p0ltDUYGoNRlfxqmmzC1XhnwC+Qea+dusfNsjRqu1TpxqGSc57vxFbpl0kWeLUlX9GtCoJx/MXs78jupUsZ7Z4qjXZoNdaidX5aNrwn+8J09gj9llwmnF7TFBH+CNbhBVluvKpZRpHIkR856guKkcNA0QB+4ZkKUOHZHtB+laS5aEEeruwCTpDNsoVmhvwGLCpp+gqnI8c0zqiyGcNdL4VXmPWneSbGgDvWtvnVr9Kikp6SOnsbouFCopNmuFT/HRJTtH7XQjDQ3yL0wXHpCRwvWbZNXTrTOHFrbLeaDBx9UEIJGDjSAY2OUMV49pOgU9MDX+bKEFpruftp5sLFvYQFd95rCzYx2ztqDEHeNd8MMu44PVh9DUzrEMYg2v7E1z67k8VmURfkzhCdjH9GUr8mmvuw8TOfHfI1g+592OPoLwrODRyZpEPZCVRoQOoeCnCI6D9Q85OarWviDviuHTs6fEKcMmnDELuJ20tfom+abweyefEsik+2VkukJLBqGr+HHH0z+ycix owR+uLC4 BRlfIZSiTHTNX7lxzlvkMSFJ+58bbHyWnNQxfICNFfSzV7CS93jqM6cr7Edtno4Lh1oaOOtoMbK6TYiqnKGwEF+5gPuT+S2LIJhRbC+6ScATSLRK6p/awezJmdDsYNgtXk0QEfYTgXT8sW4EnYr/4MU0m6EdIRT1C3BERBxC4xf0GJlVW8eDOPTr8OCoe2sX31zval0RV+bqvaHLFQ/KdWFhzyU0fPbDIP3B0xN7+yaGiJ7qaA+pI/LyUwircbymC8ssgiAiqKwsC6DwyE9T/Caan2UfyW5mxPlTiMA9Nf23x3zke+c/lrH1QCU3pdTZDQY1+yMQC8AN/vJdXKIkVGtp/FUVagbgTBIxBrFnZqpArYV3lc6Z6cv7hVYrNCyeCQzYI247tzjF3CgU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 08, 2023 at 11:39:03AM +0200, Jan Kara wrote: > On Mon 07-08-23 15:38:38, Jeff Layton wrote: > > In later patches we're going to drop the "now" parameter from the > > update_time operation. Prepare XFS for this by reworking how it fetches > > timestamps and sets them in the inode. Ensure that we update the ctime > > even if only S_MTIME is set. > > > > Signed-off-by: Jeff Layton > > --- > > fs/xfs/xfs_iops.c | 12 ++++++++---- > > 1 file changed, 8 insertions(+), 4 deletions(-) > > > > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > > index 731f45391baa..72d18e7840f5 100644 > > --- a/fs/xfs/xfs_iops.c > > +++ b/fs/xfs/xfs_iops.c > > @@ -1037,6 +1037,7 @@ xfs_vn_update_time( > > int log_flags = XFS_ILOG_TIMESTAMP; > > struct xfs_trans *tp; > > int error; > > + struct timespec64 now = current_time(inode); > > No need to fetch current_time() here where you overwrite it just a bit > later... It also shadows the @now parameter of that function. Since that function parameter is dropped in follow-up patches I simply s/now/time/g it here. In any case, fixed in-tree.