From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6FE5C001DF for ; Tue, 8 Aug 2023 10:06:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5256F6B0075; Tue, 8 Aug 2023 06:06:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D6888D0002; Tue, 8 Aug 2023 06:06:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34FDC8D0001; Tue, 8 Aug 2023 06:06:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 274136B0075 for ; Tue, 8 Aug 2023 06:06:03 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E6509160C25 for ; Tue, 8 Aug 2023 10:06:02 +0000 (UTC) X-FDA: 81100506564.25.26C3306 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf27.hostedemail.com (Postfix) with ESMTP id ABA0B4001B for ; Tue, 8 Aug 2023 10:06:00 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=RYwrn0fd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3BwMkd6c; spf=pass (imf27.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691489161; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cOTJYjkBLnwjV/lxEVtUyReuFAMisDvl/3KW3rcsa80=; b=dTEijbXZTGBHqOVVSQgI1gJF2w0kHHuWp8b5IC1zhyzgBBMfBLqmmzD+/kP4dlNohNw+Cu bs/6xo45Giy7PgO8SVcfzbgeN4jFUlIdLOOn6vynwWlb4m5rcYXWKO3dmVpKd1cluIk0Wi iz6eApbiI+DTNYKMlaLgWeml2kny/1w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691489161; a=rsa-sha256; cv=none; b=8e3FTDArOhDrOiWrWqmEcurVKIAjhzUz6O9o9PqUb9TA/Skpjos9/zO773RtkAlETqMuoG dchn6s+OvDsETAM81+IcsnAyqlMAU5+tT9WIqX09th3oi4gebtdBN+iGEpRZz8L88H9KFs gSl1B9aY7FO10WXdZPSWfbP/T9Tso84= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=RYwrn0fd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3BwMkd6c; spf=pass (imf27.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 48E552031C; Tue, 8 Aug 2023 10:05:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1691489158; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cOTJYjkBLnwjV/lxEVtUyReuFAMisDvl/3KW3rcsa80=; b=RYwrn0fdjwhhRR7l27SfhU6sEIZlfDKsRmqY6BlBC/mbMQlEPGtvhbIdRr7h8egn/oN8yh Oz6U9UuTleHENrCE1avR3NSOn0guqcLSLu7iBXijjb70nxn/BQDxhjUWhk7QvvA5/v4PB8 VNLrqst7KIs78O2ejOjXiqcNSNVttFQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1691489158; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cOTJYjkBLnwjV/lxEVtUyReuFAMisDvl/3KW3rcsa80=; b=3BwMkd6c3zAZ5/EGX3xW7irKJimW+k7SoacxDa/XvD8/WW5BAqfXsGAeW7PnSgHdphBpnB 7inqEIuyeW8nM7Cw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2CBE0139E9; Tue, 8 Aug 2023 10:05:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id riV+CoYT0mRzKwAAMHmgww (envelope-from ); Tue, 08 Aug 2023 10:05:58 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 9F18AA0769; Tue, 8 Aug 2023 12:05:57 +0200 (CEST) Date: Tue, 8 Aug 2023 12:05:57 +0200 From: Jan Kara To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v7 13/13] btrfs: convert to multigrain timestamps Message-ID: <20230808100557.dowlxz2destpseqr@quack3> References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230807-mgctime-v7-13-d1dec143a704@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230807-mgctime-v7-13-d1dec143a704@kernel.org> X-Stat-Signature: pbh53uttnyktfdhoqowizmrkwwzcg5op X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: ABA0B4001B X-Rspam-User: X-HE-Tag: 1691489160-228041 X-HE-Meta: U2FsdGVkX19JlkY1qnpgytPIaMJjvoKaTgJRRt5O8T0wwgZnxZ3qp4c4gXbuK4jjm4JtCVYbep3Frt8OPqCGEDEARDORSQpD21lsY3m87V792IBQjcd6KkyuulIvoyZ22JR5hEGwUS4i9oWqMhwSSZZ02bFl/HmiUuC97zle+WnLtxvN6oq0s4CqmhNHqy4X/n7NPkpnCQ4c+mvk8belAAZoMAsN9mAs165IrX1QU43NFxKGLIHZguEn9pgqViqRBDKlAJ6l8zpL6e+ELoYoxc9ueWNfS0gzA/ghCbvzU/bXYvMfOPvI3+6Gc+/ODyg0OhLaY/nHZto8Ud1+9uTiXckd/Kqpyqd87UnsXzw2HYOgeWwQX8Z1BcXeycNjR0raWMuiC9r5NWwh93PvYqCdnrXdbOMKqAncPBlsssuYYMdd9eTdgRYxMJQ/fvelYqRkG2RGamZcs4hIk8WW69IkPwfxkB5F7UD5pVniSG0YmPxbModOWEHbTXv435iRPAEpW1EvnK2uw6TsP+RtxjYacxNHxclM5Xvs90JdC9doXZT2vXoRF36cc9qNtCWWBPJgMA7EdnadI5c+mMwZ4S01HZ7ZqbtI8jAGAv0rbkdgs6uWFPuVjazjvwtB0iX44uXv65s9Owlvjo597xWZKE1oxkNGVHeCqm3mBvfmsi+40xoxLZUWjv6g7CzZPMZhpwLCgST47nyemlUsK1NrOyfj6ZvjWNlB5uGJrQm8ov5C5Sz9ILTQ5Ug/e+dxv52Pa8hdklEN+ilL9ftbNTNg1Rh4mMk7oVHM4DWBBe6Qp3wR4Ga+gu1RQx5Drc0F39xM8vqYHna/w+GQYJ0ay/rDwznvh/fUX4Ie0xrucKTvYE94GAQetXO80w9Y+WEO5Hc504UNZM8txGwnRaf+S8zs9GmJ482/JtF2UvO3OIwMgkZXDkJBHa7/fRC7i4O9s4SK+BlN7UJjjh9h/B8QrFJ6mWm B/pSueGW bISC30seVRm2LiB6Fa4tJJxRpkkpSroSxOgqgA9Wt4+L40/pExCPcPMsRyqoiLyvriR77OoSRrWhcQ9z0c8xB3wFvFzuXL4tQS2/N7eZEZIq9ZoWQjkLmXXd7sS14f1scmmliWKO9sT5FY3oM5O8FRraSd6UGR+DVzXxPxIf3nG1CacDH8/2nXCxALMKtZje5nU1bkmHf3FV8mJeWv98LI+HQbvZ6Rls7+Aq04SRUsHYnvOCg7XIQpvpMtZnsdx9AAnWcAupsuqshJmgMYC8yp5vsaAQSzXe6da/zy2EorgXyQlB3o6FmV8gDOA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 07-08-23 15:38:44, Jeff Layton wrote: > Enable multigrain timestamps, which should ensure that there is an > apparent change to the timestamp whenever it has been written after > being actively observed via getattr. > > Beyond enabling the FS_MGTIME flag, this patch eliminates > update_time_for_write, which goes to great pains to avoid in-memory > stores. Just have it overwrite the timestamps unconditionally. > > Signed-off-by: Jeff Layton > Acked-by: David Sterba Looks good to me. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/btrfs/file.c | 24 ++++-------------------- > fs/btrfs/super.c | 5 +++-- > 2 files changed, 7 insertions(+), 22 deletions(-) > > diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c > index d7a9ece7a40b..b9e75c9f95ac 100644 > --- a/fs/btrfs/file.c > +++ b/fs/btrfs/file.c > @@ -1106,25 +1106,6 @@ void btrfs_check_nocow_unlock(struct btrfs_inode *inode) > btrfs_drew_write_unlock(&inode->root->snapshot_lock); > } > > -static void update_time_for_write(struct inode *inode) > -{ > - struct timespec64 now, ctime; > - > - if (IS_NOCMTIME(inode)) > - return; > - > - now = current_time(inode); > - if (!timespec64_equal(&inode->i_mtime, &now)) > - inode->i_mtime = now; > - > - ctime = inode_get_ctime(inode); > - if (!timespec64_equal(&ctime, &now)) > - inode_set_ctime_to_ts(inode, now); > - > - if (IS_I_VERSION(inode)) > - inode_inc_iversion(inode); > -} > - > static int btrfs_write_check(struct kiocb *iocb, struct iov_iter *from, > size_t count) > { > @@ -1156,7 +1137,10 @@ static int btrfs_write_check(struct kiocb *iocb, struct iov_iter *from, > * need to start yet another transaction to update the inode as we will > * update the inode when we finish writing whatever data we write. > */ > - update_time_for_write(inode); > + if (!IS_NOCMTIME(inode)) { > + inode->i_mtime = inode_set_ctime_current(inode); > + inode_inc_iversion(inode); > + } > > start_pos = round_down(pos, fs_info->sectorsize); > oldsize = i_size_read(inode); > diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c > index f1dd172d8d5b..8eda51b095c9 100644 > --- a/fs/btrfs/super.c > +++ b/fs/btrfs/super.c > @@ -2144,7 +2144,7 @@ static struct file_system_type btrfs_fs_type = { > .name = "btrfs", > .mount = btrfs_mount, > .kill_sb = btrfs_kill_super, > - .fs_flags = FS_REQUIRES_DEV | FS_BINARY_MOUNTDATA, > + .fs_flags = FS_REQUIRES_DEV | FS_BINARY_MOUNTDATA | FS_MGTIME, > }; > > static struct file_system_type btrfs_root_fs_type = { > @@ -2152,7 +2152,8 @@ static struct file_system_type btrfs_root_fs_type = { > .name = "btrfs", > .mount = btrfs_mount_root, > .kill_sb = btrfs_kill_super, > - .fs_flags = FS_REQUIRES_DEV | FS_BINARY_MOUNTDATA | FS_ALLOW_IDMAP, > + .fs_flags = FS_REQUIRES_DEV | FS_BINARY_MOUNTDATA | > + FS_ALLOW_IDMAP | FS_MGTIME, > }; > > MODULE_ALIAS_FS("btrfs"); > > -- > 2.41.0 > -- Jan Kara SUSE Labs, CR