From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF10BC001B0 for ; Tue, 8 Aug 2023 09:37:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 780C36B0074; Tue, 8 Aug 2023 05:37:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 730876B0075; Tue, 8 Aug 2023 05:37:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5ACDC8D0001; Tue, 8 Aug 2023 05:37:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 47EF86B0074 for ; Tue, 8 Aug 2023 05:37:06 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0ACC4A0C6C for ; Tue, 8 Aug 2023 09:37:06 +0000 (UTC) X-FDA: 81100433652.24.4CCBCA7 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf10.hostedemail.com (Postfix) with ESMTP id E1D9BC0006 for ; Tue, 8 Aug 2023 09:37:03 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=xNkmZedH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=C9mvCUPa; dmarc=none; spf=pass (imf10.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691487424; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+dwojIKMsZIfKNojdAYP/LpuQmw+6rqqzdeGXh9OKdQ=; b=oE4KTW9UggpSNeS+BngcmGoRt1szUl980QnQYwrfVcnAHkIWOIX3is0omUfBJqimPzzVKP b0e7FnbxUZvBXb7/SWam/W+ucZodnhLZc8BoQ6H2kwGrw71zEjYDC/WFsoJ7s1+ftfu0qS cwDsTraUaq6MxnWEPOTaXMfpJEfuS+o= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=xNkmZedH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=C9mvCUPa; dmarc=none; spf=pass (imf10.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691487424; a=rsa-sha256; cv=none; b=D/12Ahbej1YGLRknKTH45K//2emsmw/3a41zRpIHz04kQ0IRIULGUqYoXUNEthj4IaTiqN 1gnZPJKNg2eFMhnBWIOZmIwBcPDkKQPPBP6MgnUbcfufcqf6umvB7wk/Pbcgp/8ARbE+8H pTUCUkiK29hT9RIdL/MGG8Z48sAqRQg= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 40FDE22487; Tue, 8 Aug 2023 09:37:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1691487422; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+dwojIKMsZIfKNojdAYP/LpuQmw+6rqqzdeGXh9OKdQ=; b=xNkmZedHCH4JfPl5aI/7jFcoHvCmU2Ei7iO7owXcuJIhPHMXaR9JIDbudRkrv+OpRvBT78 QcY9S7zG3KilNTQJsdlbMzoPhbFYNRjSDo58qiEL/KKnRHAz06+KLjpoPEh0KdB8jKpl0d Paghc7ScJ479EYrBJsHB5zKlYU4EE1o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1691487422; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+dwojIKMsZIfKNojdAYP/LpuQmw+6rqqzdeGXh9OKdQ=; b=C9mvCUPaAa2cOnSGsmSgpsXVt5ts05YWI0vruOwxYGEk08U30pxAruMbAfjG0JtSrXhSu+ h+OsL5aeMUqW5DAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 20CE1139E9; Tue, 8 Aug 2023 09:37:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id pmr0B74M0mRlHQAAMHmgww (envelope-from ); Tue, 08 Aug 2023 09:37:02 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 9F88DA0769; Tue, 8 Aug 2023 11:37:01 +0200 (CEST) Date: Tue, 8 Aug 2023 11:37:01 +0200 From: Jan Kara To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v7 06/13] ubifs: have ubifs_update_time use inode_update_timestamps Message-ID: <20230808093701.ggyj7tyqonivl7tb@quack3> References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230807-mgctime-v7-6-d1dec143a704@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230807-mgctime-v7-6-d1dec143a704@kernel.org> X-Rspamd-Queue-Id: E1D9BC0006 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 4ion4ybj1t1b5d6xrafnswigoq1hnjfd X-HE-Tag: 1691487423-828281 X-HE-Meta: U2FsdGVkX19zBti7oa+OSLzFIlmBMBgef1YzdLyUk6T9yGkeZ/o47wyw/2lRBJlRDK7ZIcTcAHmEw5q2Xx7MdXKie3xhaFxHKjetMZvb59DDOPicbDzG84YlpmubYbE87zYD+B2TwFMzKj0F3HnE89PaeDdYPgVZDgLId41r0NL2Jg5HCEU3YcUhbFy84GJzIHFEpGlKHYKE3Xo9tpnvai0QlE/MdCkolN8xFUFLYiCa6I4OXmZsdYv1mzd1DFLj+HNqjDvyMHMuSiQUuhpa++dQuhDP3DyJSw4kC4vbolsBmn2KU/VeaRZLSNli9L47me5EukgWzILXw6jyQFZcTyGMcgTAuv+UPyzlFNQLSWyBzc1uQLzgB/MGLGboYYb3jEebudXPncCok3lEyJBtX+ynf+oB24jnRH/7RNHBI4IM4PcgeMgJZiLiqgCKyKZAiO1YORz/6yMYM5akiWw5zeO/UmMNplaPXK0BrVdUrIu/45/RlnX1do7AuBWx6Hk7VNnQNOL2efhmeEmcO1aLX8aB1/nDx1V3Uvu9kiCngb7xoj7RnS/wordcjeN3ZlPFV6oTY5f3SIxsH5nVjlWrNWdAQGEChHgFtZT7cELaIMUIUUp49ep82/XI5+pqHR50TAYm97iCFV1C/wJShO4FesHQNcFShePkMQdDBp0dik2Y48sQmg5piwBGVlnpD6B3u5MhgCY5mbXDq6gr68bNnn3RRO66CdIsbGIz4OpMxe96jsYBSa3A33ItGxb5j1z8dD33YyhRiaQ7Z8zNzswWvsXzwwIQTmogzl6teiCHcyMYRiHIe7A6TQTa7ieVmKmZGhMo/ss7Uwk2i/8T5zJEePZ7tChVW09yBtNDR1bu5qKiZ0J9XeaNI530/HQvOTz631QPWoEuwURk71C/OolxBeSt5ycSw/x92etHqMY7UGwMzoQdb+Fyenq4yCN2FM8GXDmkLp0UcxwsLUrbLg6 LQ3D/QI+ clVPgYNvWxzedx8tAEb2VZg0gKa0BqDiz9DqpuxlzM5ObeTRd91KWxkADhhj09jxZlR4sf7wAIBndK82df43m9AimMhjvW8zoNABc0VZrOr5O5Tb8SZ1u3HlXP1LDFaWXKvfAyf0bdFlOT2W6KBL06sEo8nlHStEUzDSaisx6eAvZp/GIZmc+qopYuZccvB+/SftYKohc+DB6QPWtQUFM7kL32OqBgsxvdMtJCkrcslSFovG4ZaumjL5Xp3wCyj2lyTitiJ67KVuuNRSv/+PY29HvKVXSNcRrtrdkwVGFeBC4cL4OVb7RYD9LApHh/0Jr40yCdeq57fCK+t+RXzKUfWYoMgaUcDIm95JQfT+Jav4jNaI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 07-08-23 15:38:37, Jeff Layton wrote: > In later patches, we're going to drop the "now" parameter from the > update_time operation. Prepare ubifs for this, by having it use the new > inode_update_timestamps helper. > > Signed-off-by: Jeff Layton One comment below: > diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c > index df9086b19cd0..2d0178922e19 100644 > --- a/fs/ubifs/file.c > +++ b/fs/ubifs/file.c > @@ -1397,15 +1397,9 @@ int ubifs_update_time(struct inode *inode, struct timespec64 *time, > return err; > > mutex_lock(&ui->ui_mutex); > - if (flags & S_ATIME) > - inode->i_atime = *time; > - if (flags & S_CTIME) > - inode_set_ctime_to_ts(inode, *time); > - if (flags & S_MTIME) > - inode->i_mtime = *time; > - > - release = ui->dirty; > + inode_update_timestamps(inode, flags); > __mark_inode_dirty(inode, I_DIRTY_SYNC); > + release = ui->dirty; > mutex_unlock(&ui->ui_mutex); I think this is wrong. You need to keep sampling ui->dirty before calling __mark_inode_dirty(). Otherwise you could release budget for inode update you really need... > if (release) > ubifs_release_budget(c, &req); Honza -- Jan Kara SUSE Labs, CR