From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28BD4C001B0 for ; Tue, 8 Aug 2023 09:32:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72E936B0071; Tue, 8 Aug 2023 05:32:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DF466B0074; Tue, 8 Aug 2023 05:32:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5813F8D0001; Tue, 8 Aug 2023 05:32:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 450476B0071 for ; Tue, 8 Aug 2023 05:32:32 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 034EFC0C34 for ; Tue, 8 Aug 2023 09:32:31 +0000 (UTC) X-FDA: 81100422144.06.FE0B375 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf15.hostedemail.com (Postfix) with ESMTP id CAB0CA0014 for ; Tue, 8 Aug 2023 09:32:28 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="kAP4/qU3"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=zakAo2cW; dmarc=none; spf=pass (imf15.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691487149; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=URemeKpdb8J18iMONbqIB4P02haKyRX6mS8Xu4Mgmc8=; b=TsYbjhr6chy76C9jQe/DGIAnmu7lA/GveKpoD4H0qSzsLw6WxZR4JKL1is6ENGp6oHgRr/ A2RFW1+cYISSTO1oV3mEfd/uoCcBAq8r0yi2Y69Xp1qfrSchDdnZQCa4u7GL4slT6WjXKq eHQAXogA2ToRsKfX2/eCe/nj+E0UrrU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="kAP4/qU3"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=zakAo2cW; dmarc=none; spf=pass (imf15.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691487149; a=rsa-sha256; cv=none; b=b6W5pUfIQIqPQJsqUpJgYPPHeUcbgwX1n8ySNv7t3Uq4EUYZLgR/zFU0RnIH8a859mbjpw Dx25XQNxoHDKeTleOh674+liPnpw1bGSCZEPfqQ2f60UUeRMVMgSAWLdjrtpkHKORLZEmY RaGLIeHiWJnch4lTFLDrVA4wfa2sv9g= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 43D5822487; Tue, 8 Aug 2023 09:32:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1691487147; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=URemeKpdb8J18iMONbqIB4P02haKyRX6mS8Xu4Mgmc8=; b=kAP4/qU3eebbLi9EbGgoNiblqEAMz2n9d8dDZjEU/zYHxmh4xQUAW4aRmDsDFAo1LDW4XS Jz3jziQyqFQJ2OS6XJQCmcd5h9qdcD3Byn8qpddgol9CAV8ew1WhVYDKOVKgTmZrEM14u3 +VucJ+n1ddguqczAaW5Ki56KFXcMMvI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1691487147; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=URemeKpdb8J18iMONbqIB4P02haKyRX6mS8Xu4Mgmc8=; b=zakAo2cWrWyYBcipF4rIUwLGrOqm5ZeFyaCmUH+fTkQWLNKyEQyre7V0L+jFNWPtWdDjYF EO0z/Yllpo+E3ODA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 28DCC139E9; Tue, 8 Aug 2023 09:32:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id K7T5CasL0mR9GwAAMHmgww (envelope-from ); Tue, 08 Aug 2023 09:32:27 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 82443A0769; Tue, 8 Aug 2023 11:32:26 +0200 (CEST) Date: Tue, 8 Aug 2023 11:32:26 +0200 From: Jan Kara To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v7 05/13] fat: make fat_update_time get its own timestamp Message-ID: <20230808093226.bq2qfxv5npckk643@quack3> References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230807-mgctime-v7-5-d1dec143a704@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230807-mgctime-v7-5-d1dec143a704@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CAB0CA0014 X-Stat-Signature: ictssrf1wuro7wms8nqa1ki7whi8497r X-HE-Tag: 1691487148-418044 X-HE-Meta: U2FsdGVkX1/oTSP+A5M2Ll8wxyfp2/EK0kpIpqOo7Tqz7R6j4kRJI5JkzUbo285EJ+Sc3NqtQBn5jS1Y6TUz2qQcA+t36gLHtQ9Sxno9FVLa0Fp1MThL1oKJfF78h06KaCmjhnwKyW+TS2bQTXlJwJYaOfWixZARya6luSrHZ0plg5iN5flkhsAl0fVHn7pSNb1naZbf3eI8EYbEf/M4MSlNikDGs/zzr9kS7cRZDbNYHq+WkP7Wsxt0Y+vhaXnut/WZlG1xaTnvBmXi8TqvIxwkzVKOZ1ejDIYCYKHWCTrTi1Qp9FJ29IECXD7ijIVTa5d9YX/0Hbrbl9uiCwSfcn/aH35zEghwTaS3sLEC90kjN5tUD0ELKxSsJEbYCzb/M59ePdCCqTfz2koPJCyj9exKR/NGZU0tcwol0MRve9JdlzdvIVI7s6M9oj+BHdGDAGaI1wA2beGEInzsn6uSiWZCKsLXhYqXs1W6RUovbqdcinFjvuqykDdu8jNGdagbsO6qB+y5Ubwg43PEoEMeT31bPj8HWCQnY2pDqMrEjTu+8937Y90aTOPzlNrBc8zebuuIcvpsJblpXo04Ua9Blepk7ynMSe1EDKIaABwG50kHi2NabAmVVa8C/pIAfNDouJ0GDve56AGQaCVol+uKUNWPrWuqmIJNTmEUlxRuCnyRL7exAXF/8O5o8S+1vP6O+oMHxVKXmmdRThJLqnYm0H2SLYqwNuh1MdLIm7FGz5mhLA2XyZACoCYaMR+Q7P4IaM4vto+O1xi9tn0+Lu0kDCguK6H/O02e8Y7MqWZa02Tqp9F5WcpADAUseHx/bJgVKrMHJzGoNjyOuVfJPqNRj9gEMRfDbwNV0mRTO/1yZXhrCRAQIkXqCCfCB9LHWLzvlKRsBXJ30HpRfoT6t6f+dmZvGKHQNkPs8drOBBWsODvgj2lfXhlLLToDhUkzgYjV+tVfafC/MDo24KGueGc 53k4B1aR LVLyiwvT3kRwYku+e9ARZxPMYjV1rT7PzejMQ9a19nC2uJM2CMTBbp4+5UtNzIsP/SC6yH19g1oDGsobrv1JAYPKNWyn+g/wE4JK1Rs/wT37HavaOL1e1miFVOibz3q1fwvpwXXBBEJ40UhPboDR6paa47Kf4fpdWPmHi9J7Abf5D4OaW+BZFg+jCAsmabOBbgWG7fUcFm6Yf9W5w80h70/Jk3vAYXY+NWOXlNNb5822XQ6ADEMjMFNuoW9D1Fy1dSwYraer8mtm2+VKvS3VKDybyHX13DFYj+Pb2p7d8OwnJf98ZCPr/xTaUXVwtYYGfvxob7/vc+WmSrcegLv/YQFgLen6TdeidI0DdpDUcXGD1oCM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 07-08-23 15:38:36, Jeff Layton wrote: > In later patches, we're going to drop the "now" parameter from the > update_time operation. Fix fat_update_time to fetch its own timestamp. > It turns out that this is easily done by just passing a NULL timestamp > pointer to fat_update_time. ^^^ fat_truncate_time() > Also, it may be that things have changed by the time we get to calling > fat_update_time after checking inode_needs_update_time. Ensure that we > attempt the i_version bump if any of the S_* flags besides S_ATIME are > set. > > Signed-off-by: Jeff Layton Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/fat/misc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/fat/misc.c b/fs/fat/misc.c > index 67006ea08db6..8cab87145d63 100644 > --- a/fs/fat/misc.c > +++ b/fs/fat/misc.c > @@ -347,14 +347,14 @@ int fat_update_time(struct inode *inode, struct timespec64 *now, int flags) > return 0; > > if (flags & (S_ATIME | S_CTIME | S_MTIME)) { > - fat_truncate_time(inode, now, flags); > + fat_truncate_time(inode, NULL, flags); > if (inode->i_sb->s_flags & SB_LAZYTIME) > dirty_flags |= I_DIRTY_TIME; > else > dirty_flags |= I_DIRTY_SYNC; > } > > - if ((flags & S_VERSION) && inode_maybe_inc_iversion(inode, false)) > + if ((flags & (S_VERSION|S_CTIME|S_MTIME)) && inode_maybe_inc_iversion(inode, false)) > dirty_flags |= I_DIRTY_SYNC; > > __mark_inode_dirty(inode, dirty_flags); > > -- > 2.41.0 > -- Jan Kara SUSE Labs, CR