From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80D00C001B0 for ; Tue, 8 Aug 2023 09:26:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1B4A6B0071; Tue, 8 Aug 2023 05:26:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ECA1B6B0074; Tue, 8 Aug 2023 05:26:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D43AD8D0001; Tue, 8 Aug 2023 05:26:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C2D7A6B0071 for ; Tue, 8 Aug 2023 05:26:57 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 96B7D1A05E5 for ; Tue, 8 Aug 2023 09:26:57 +0000 (UTC) X-FDA: 81100408074.11.CA635D6 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf14.hostedemail.com (Postfix) with ESMTP id 847A3100011 for ; Tue, 8 Aug 2023 09:26:55 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AoaZr4oK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="fxL/rpYw"; spf=pass (imf14.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691486815; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b3NxAQUEhhiHtmalxt25UQpIEh3A8DobG2qOMrP77WQ=; b=a4Vi70j7AH5Ip0Xepjj0a09kWTstOqtljvexujTYBig7cJk7rF+QcRTQyHgLxuf1ZvdXim 6icvJxm5JMDdljnaV2cS8xz4fnmp0L3zBZL/SpRqob7DmaqUYD22HDirm3rPQegI09/gj4 acA6Ibj5nT1iOzjzyUpSy5t/xoiFfPE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691486815; a=rsa-sha256; cv=none; b=q/Ajh8vmX7Gn3M3nsm8zfSSjUvSniyU/WxnVd4lmKdiPXDOPYt4ZMC5f8mEiKoGye+hJAH Aw6Kj6FCljj4WepeTWnQMNr4VRQgpgCr6FhYWvST5DJMsOdpqOoAT7Xneko7WnxaPxYTPU E20hckVG16hu0qoYaINydFA2t/73v0c= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AoaZr4oK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="fxL/rpYw"; spf=pass (imf14.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C51A520316; Tue, 8 Aug 2023 09:26:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1691486813; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b3NxAQUEhhiHtmalxt25UQpIEh3A8DobG2qOMrP77WQ=; b=AoaZr4oK+uPjgRe+H1N/P4OqdxMzaLQwACpyg7af2LxycPofpRJURn7+dS209wAPqvb2Pa pyguefJyN0BETiXosk+qeiLcs65x2b42r4Xs2kf58Hhxb2lmpsj3DMEMMNaki6d405++FY 0hRnLs55sh8fmVIdow8NkLHWnHGd+BI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1691486813; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b3NxAQUEhhiHtmalxt25UQpIEh3A8DobG2qOMrP77WQ=; b=fxL/rpYwL46zGUX+wz6hOBohbpcZSktGMd5XhY0mnCjlb5Vurz5pFf3PTuD19V4sOSJ9Wo YCByPZ22Ze/c5AAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9677713451; Tue, 8 Aug 2023 09:26:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rxmpJF0K0mRqGAAAMHmgww (envelope-from ); Tue, 08 Aug 2023 09:26:53 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 1DB1BA0769; Tue, 8 Aug 2023 11:26:53 +0200 (CEST) Date: Tue, 8 Aug 2023 11:26:53 +0200 From: Jan Kara To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v7 04/13] btrfs: have it use inode_update_timestamps Message-ID: <20230808092653.ma6d72b4xwa3jk3f@quack3> References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230807-mgctime-v7-4-d1dec143a704@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230807-mgctime-v7-4-d1dec143a704@kernel.org> X-Rspamd-Queue-Id: 847A3100011 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: fycnzt73wo1pyongokkncorfrwquqgoy X-HE-Tag: 1691486815-961714 X-HE-Meta: U2FsdGVkX1/O3WyvUrAfrhCc/Oufi4/gSliFwaJn2ht/v+YkSLfCHHFY5dq5GYl8Ob6WpL9Us541ahHJLTQIRlyettpiHLcps5QKS0RJhxCwKQEU9kvA9CJkwd+evJ/mUNuQxN7DD4Of1xAE/yTp+6+7wMGFeJ3PXsKPotvHLgJFzIsCBtyPSaZcEgO/CpHMLbWWrxq/vHmZGQx7SpDZcBeMG1l9fTqWbtvzpPXnTKpqHDVUUx4U81y99jR6ARisQ+FzGZzBMnQLQvHSSOnnh/CY8dc4WVwhfuaVzgQVzkXvSHe/Uy5+7ulpk9HI7b9OdRVUyM8TJSm5Hw5D/bn86Na47EdL5C+e0XmdCFm4dVWid+xNOTqM3/4zVLEMNORj+PgujOUbxWWIANL0HGhwcu9PoCvfzufYBsIRCwkKPPvEIS/pc7ZQwfQvupJHu/vbjlvxfKngRetJWpHct4nGHsbLX68oSrFMk4BnG1tDlgIUHn3rvHTXYPVWoCilL2ximPWEToUWF7Qc+fLPtPGJJZyuuZBJfpngJa+L1z0ijeoVCWJ2G+44uuOzE+qZAkubVPSyN7TAP5X91yhjl80WxEX4Yv8vnI5qIGpoG/QCD7cyWpHlYDDbIu5XEyuGppDx3I2Cae5QYFgtkMdByjfRdoq7Yj8OcRcAYql5178dRMCpZFgIaOBvMIjaMtb9L/BA3I29jVYixsR1b2zisgLH8sxwGtJAFMGP+ff2JS//lQfnJxf5T4qibGlSx/MZty/RiCxy+7KjIhGUiUjZUEmJusZLw/EX2hSQo8J1RGDtIMzLmtVrkrqeAbYkS1rkFtSasKuTv/IYZZKeKlovkCgy8t8SaS1o7Qreoc6UMdntWsANsjBq101F6vlBBqCjCljcnSqON7i3IL1Yhw4Y6cMKTz68Jp6P72zTIGz1YUBMpLFYdxo2oEv7draSmqufttuFmZD3q3zfW5zlCrM3pfC uNtLHV0M KSFPFwg8SsmhI4Jk27PaP5rULaSM18J2W8Ukke3a6PB3X6QpU2CMatsB1N5TZ1bYyDG9TzrA5yd2Rtl6ZRUp3s72fDKnV8L7eZjGI3QjQgWML7IfeHTybTYCkAAzdElSRbDPu46IyMKLjv8wA++CYGhXQTtZxz5Fzq6TYav3PTeY3beEMALxuZUy6kGqlrJ24k4UbJyjbYLYW6GzWf0u/DvyWNQPkJbNEkTqycoCvC6/+hcy7QZw9QYp8YIXNZLoT6UKSvnXkzdrOymaUIvOqbL11qKzA9Wqu2BzbuBKrdV0Ywsyu94wmdEeSJCDLM0GXKrvb2S7pIYB0juwmHveEowYj8bHwT58ihUQetk2qME2iKsk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 07-08-23 15:38:35, Jeff Layton wrote: > In later patches, we're going to drop the "now" argument from the > update_time operation. Have btrfs_update_time use the new > inode_update_timestamps helper to fetch a new timestamp and update it > properly. > > Signed-off-by: Jeff Layton Nice cleanup! Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/btrfs/inode.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c > index 29a20f828dda..d52e7d64570a 100644 > --- a/fs/btrfs/inode.c > +++ b/fs/btrfs/inode.c > @@ -6068,14 +6068,7 @@ static int btrfs_update_time(struct inode *inode, struct timespec64 *now, > if (btrfs_root_readonly(root)) > return -EROFS; > > - if (flags & S_VERSION) > - dirty |= inode_maybe_inc_iversion(inode, dirty); > - if (flags & S_CTIME) > - inode_set_ctime_to_ts(inode, *now); > - if (flags & S_MTIME) > - inode->i_mtime = *now; > - if (flags & S_ATIME) > - inode->i_atime = *now; > + dirty = inode_update_timestamps(inode, flags); > return dirty ? btrfs_dirty_inode(BTRFS_I(inode)) : 0; > } > > > -- > 2.41.0 > -- Jan Kara SUSE Labs, CR