From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6393C001DB for ; Tue, 8 Aug 2023 09:05:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45AB58D0003; Tue, 8 Aug 2023 05:05:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40C278D0001; Tue, 8 Aug 2023 05:05:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 284718D0003; Tue, 8 Aug 2023 05:05:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 19C7D8D0001 for ; Tue, 8 Aug 2023 05:05:33 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DB01C120C32 for ; Tue, 8 Aug 2023 09:05:32 +0000 (UTC) X-FDA: 81100354104.01.8F8BAC2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf14.hostedemail.com (Postfix) with ESMTP id 477AF100003 for ; Tue, 8 Aug 2023 09:05:30 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ltvgN98j; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NtHl8v8f; spf=pass (imf14.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691485530; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wcZ0MvDWAvHGz+Tvz5BQspV1+Y90atrQ/21gTPDSJ5A=; b=IPWFJxl4/gmsAqkdSgHxY9PUw52GRLann0Bn/olcKjA6uqAoFrj/IUfs44zY+7h+2OsKf+ MLeiBkHP/UjVlNkDtDzF/GMFOS6SXiEBYu8xQ1LhM/J2CNuZ5mwtERuLTmL2tBAvEHT+3i 1buoT8cMvQ/c8qMCLQ2X27NuSYiSjOI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691485530; a=rsa-sha256; cv=none; b=jWaEWHGjROZ9lFy6GTOn+HR3zBDqflS8pOAd0PBVDxTrsI3fSSir33uC0aN5Ba8jT1wo8c dLK6uZK0tWVcEHoDHrS2hNpwixsGATY8J0sMsWPNbNgUDJ62qHGFGiNKS20qnQhXCPseZk zrFSxCnoktNky5n3Zcyre1b/CRPcch0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ltvgN98j; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NtHl8v8f; spf=pass (imf14.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 95DB722467; Tue, 8 Aug 2023 09:05:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1691485527; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wcZ0MvDWAvHGz+Tvz5BQspV1+Y90atrQ/21gTPDSJ5A=; b=ltvgN98jUPLfVGzwkX2IMCxL1+gt7mU2eMGWerKExKXl9rFxELcQOOu6LDPvkVgELBTWMM RPR+CvNDbp+v8nhbcYMs5NsoZ+s9OQ/UvQVEgQ88doFw/btLczZrQg2i1eZV1+ZBjvbv6d v//UiKTWiNGL8LuYIfEW5snVicPsNCw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1691485527; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wcZ0MvDWAvHGz+Tvz5BQspV1+Y90atrQ/21gTPDSJ5A=; b=NtHl8v8fs0QRleiCInWaMqHlp3B+YiNNeUD28RUprosc+RMkGA1oFQ5OJqyi3S1c2mho42 UGYfjYfTqGY9zJAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 818AE13451; Tue, 8 Aug 2023 09:05:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id XtCQH1cF0mRUDgAAMHmgww (envelope-from ); Tue, 08 Aug 2023 09:05:27 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 215FCA0769; Tue, 8 Aug 2023 11:05:27 +0200 (CEST) Date: Tue, 8 Aug 2023 11:05:27 +0200 From: Jan Kara To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v7 01/13] fs: remove silly warning from current_time Message-ID: <20230808090527.nvn6vd5wdw4o5b2m@quack3> References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230807-mgctime-v7-1-d1dec143a704@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230807-mgctime-v7-1-d1dec143a704@kernel.org> X-Rspamd-Queue-Id: 477AF100003 X-Rspam-User: X-Stat-Signature: w15zapzb6k9rqjbo6q5gac1hiaxnyufi X-Rspamd-Server: rspam03 X-HE-Tag: 1691485530-342775 X-HE-Meta: U2FsdGVkX1/z1lu1HiNhf/n3cHvXBovlIprZJb/vReOajHdkukn64jqei5dWF2sO0pXmpdbgilepVvoZ3CAFaWbmY7RvDNgryoVavCAe/iqU64VrytOAYyceOdD/geZK6fv7quecnyXT8VVyWbTNCPuWaAxMOdaVbM6DkQGG2F04umBTAyIGKhK88VYZvwCDi7OXz9iwbSZ0ol2DwrrNe36dctmawbOChHXltCcQWvCdTeNUPKTlAB6oaEllDzZ9Eu1dIbgGIwXETeSJLsrsWiNy5NuVQeLzyinFgJ7heai6M7jhg3JS/cq61IWiU4h/+7ghtAsZDbW0NS9b3J+nGv6XvCokODDsYzhySfpnt68t2b+XslUWUaaJKrjrAC2gego5SP9nQw2QmF5P/FNnHNvPxrRRf8mSzxcH5gKABb+pUXHS+8qLknufEyXwcLyr5qSOo1a1vVjZbUJcP8RLf1SBhSZTfgSSlgEvOKmnTTq6SBNwo8304Axl76TUx1KdwSpkXIgbEzzrNThyqg8wl7q59DDktjwL+Lh4oeKM67Suxs0GkdJw1RT6WkQ8pvC1Ik2c7W9UhPG8FfmLVikQr67IQggRM/0Kgc4KPFE4LaY1w8VksZtpGj3ysqbIXN1V206Hy3jwT8rXow/LevFfZfkXBUG2vbzAGxZF/sa5+Q4q8zZ5Ln41jxOF0yLl5fO7taqpcgOf9V0cKWvlB3C3aoM9arzBqTBXwTg2axW3iOjALR1b/Wp2RUcmyay/LseX57Lf1l1Ab1uPazDMBph0lvZvb8LHJVXFih1SQchbKr8VJiwiBewvUXZIHZRWYBZJ+lNyh8gpTHY+aXTv1ZKBL5tu0PQItZbWtbFlB3SJw/uz+LnSKf4AFl7KBlh2zaWj7/Lbx6qDUD2ZmrVdw9BhhFZVSuZDAerJ75ReuIPTMTcx4O+myqDdyqRE/Mzv2WnznHfFAau4Ms5Rgizh0+z KJIAPo+J BSRIQu46rFyizjURmIt90gtTBRhitArGvyyaohS+XGCWURnniOV5DtHdo69hHp2N2VDuvbuO+44SUSLJ2OjoxlDvOc29DkNu2co3RKajdS1yhCo1w8ZSgot0D0Dqzak0BzjQbzlN3HeHl+PglCTYMbjHrYfBX0DWLMVWdtTYe9z8i9IDhMjy7ssR9EkmgJy+P5HmVA1pMWyUv08l+kx1SKIwnVIWophtUJJnI1cQTMBDvKBAO+mSx8blAJtDR9K1xIWwXwQwD2otI/o34D+E+cCFsaSUpC7NySggf5gcTujG1JsTvUPjVld0fHrsnFERkP0Cy2MomYzpNa04R5j+qdA1GeMr38mDy4e/HT8mPsJ0rQU4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 07-08-23 15:38:32, Jeff Layton wrote: > An inode with no superblock? Unpossible! > > Signed-off-by: Jeff Layton Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/inode.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/fs/inode.c b/fs/inode.c > index d4ab92233062..3fc251bfaf73 100644 > --- a/fs/inode.c > +++ b/fs/inode.c > @@ -2495,12 +2495,6 @@ struct timespec64 current_time(struct inode *inode) > struct timespec64 now; > > ktime_get_coarse_real_ts64(&now); > - > - if (unlikely(!inode->i_sb)) { > - WARN(1, "current_time() called with uninitialized super_block in the inode"); > - return now; > - } > - > return timestamp_truncate(now, inode); > } > EXPORT_SYMBOL(current_time); > > -- > 2.41.0 > -- Jan Kara SUSE Labs, CR