From: Yan Zhao <yan.y.zhao@intel.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: pbonzini@redhat.com, seanjc@google.com, mike.kravetz@oracle.com,
apopple@nvidia.com, jgg@nvidia.com, rppt@kernel.org,
akpm@linux-foundation.org, kevin.tian@intel.com,
Yan Zhao <yan.y.zhao@intel.com>
Subject: [RFC PATCH 2/3] mm: don't set PROT_NONE to maybe-dma-pinned pages for NUMA-migrate purpose
Date: Tue, 8 Aug 2023 15:15:46 +0800 [thread overview]
Message-ID: <20230808071546.20173-1-yan.y.zhao@intel.com> (raw)
In-Reply-To: <20230808071329.19995-1-yan.y.zhao@intel.com>
Don't set PROT_NONE for exclusive anonymas and maybe-dma-pinned pages for
NUMA migration purpose.
For exclusive anonymas and page_maybe_dma_pinned() pages, NUMA-migration
will eventually drop migration of those pages in try_to_migrate_one().
(i.e. after -EBUSY returned in page_try_share_anon_rmap()).
So, skip setting PROT_NONE to those kind of pages earlier in
change_protection_range() phase to avoid later futile page faults,
detections, and restoration to original PTEs/PMDs.
Signed-off-by: Yan Zhao <yan.y.zhao@intel.com>
---
mm/huge_memory.c | 5 +++++
mm/mprotect.c | 5 +++++
2 files changed, 10 insertions(+)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index eb3678360b97..a71cf686e3b2 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -1875,6 +1875,11 @@ int change_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma,
goto unlock;
page = pmd_page(*pmd);
+
+ if (PageAnon(page) && PageAnonExclusive(page) &&
+ page_maybe_dma_pinned(page))
+ goto unlock;
+
toptier = node_is_toptier(page_to_nid(page));
/*
* Skip scanning top tier node if normal numa
diff --git a/mm/mprotect.c b/mm/mprotect.c
index cb99a7d66467..a1f63df34b86 100644
--- a/mm/mprotect.c
+++ b/mm/mprotect.c
@@ -146,6 +146,11 @@ static long change_pte_range(struct mmu_gather *tlb,
nid = page_to_nid(page);
if (target_node == nid)
continue;
+
+ if (PageAnon(page) && PageAnonExclusive(page) &&
+ page_maybe_dma_pinned(page))
+ continue;
+
toptier = node_is_toptier(nid);
/*
--
2.17.1
next prev parent reply other threads:[~2023-08-08 7:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 7:13 [RFC PATCH 0/3] Reduce NUMA balance caused TLB-shootdowns in a VM Yan Zhao
2023-08-08 7:14 ` [RFC PATCH 1/3] mm/mmu_notifier: introduce a new mmu notifier flag MMU_NOTIFIER_RANGE_NUMA Yan Zhao
2023-08-08 7:15 ` Yan Zhao [this message]
2023-08-08 7:17 ` [RFC PATCH 3/3] KVM: x86/mmu: skip zap maybe-dma-pinned pages for NUMA migration Yan Zhao
2023-08-08 12:32 ` Jason Gunthorpe
2023-08-08 14:26 ` Sean Christopherson
2023-08-08 14:32 ` Jason Gunthorpe
2023-08-08 23:56 ` Sean Christopherson
2023-08-09 0:11 ` Yan Zhao
2023-08-09 11:59 ` Jason Gunthorpe
2023-08-10 9:08 ` Yan Zhao
2023-08-09 5:06 ` Yan Zhao
2023-08-09 2:58 ` Yan Zhao
2023-08-09 0:29 ` Yan Zhao
2023-08-26 6:39 ` liulongfang
2023-09-04 7:03 ` Yan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230808071546.20173-1-yan.y.zhao@intel.com \
--to=yan.y.zhao@intel.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=jgg@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=pbonzini@redhat.com \
--cc=rppt@kernel.org \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox