linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Xiu Jianfeng <xiujianfeng@huaweicloud.com>
To: sjenning@redhat.com, ddstreet@ieee.org,
	akpm@linux-foundation.org, vitaly.wool@konsulko.com
Cc: linux-mm@kvack.org, xiujianfeng@huawei.com
Subject: [PATCH -next v2] mm: zswap: update comment for struct zswap_entry
Date: Tue,  8 Aug 2023 06:20:56 +0000	[thread overview]
Message-ID: <20230808062056.292950-1-xiujianfeng@huaweicloud.com> (raw)

From: Xiu Jianfeng <xiujianfeng@huawei.com>

Since commit 0bb488498c98 ("mm: zswap: remove zswap_header"), the
'offset' has been replaced by swpentry, update the comment for it,
and also add comment for 'objcg'.

Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>

---
v2: reword the comment
---
 mm/zswap.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/zswap.c b/mm/zswap.c
index 5b56d38e7339..1e17f11a7896 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -182,7 +182,7 @@ struct zswap_pool {
  * page within zswap.
  *
  * rbnode - links the entry into red-black tree for the appropriate swap type
- * offset - the swap offset for the entry.  Index into the red-black tree.
+ * swpentry - associated swap entry, the offset indexes into the red-black tree
  * refcount - the number of outstanding reference to the entry. This is needed
  *            to protect against premature freeing of the entry by code
  *            concurrent calls to load, invalidate, and writeback.  The lock
@@ -195,6 +195,7 @@ struct zswap_pool {
  * pool - the zswap_pool the entry's data is in
  * handle - zpool allocation handle that stores the compressed page data
  * value - value of the same-value filled pages which have same content
+ * objcg - the obj_cgroup that the compressed memory is charged to
  * lru - handle to the pool's lru used to evict pages.
  */
 struct zswap_entry {
-- 
2.34.1



             reply	other threads:[~2023-08-08  6:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08  6:20 Xiu Jianfeng [this message]
2023-08-08  6:37 ` Yosry Ahmed
2023-08-08 17:01 ` Nhat Pham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230808062056.292950-1-xiujianfeng@huaweicloud.com \
    --to=xiujianfeng@huaweicloud.com \
    --cc=akpm@linux-foundation.org \
    --cc=ddstreet@ieee.org \
    --cc=linux-mm@kvack.org \
    --cc=sjenning@redhat.com \
    --cc=vitaly.wool@konsulko.com \
    --cc=xiujianfeng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox