From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB93C001B0 for ; Mon, 7 Aug 2023 19:15:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC29B6B0072; Mon, 7 Aug 2023 15:15:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C70DE6B0074; Mon, 7 Aug 2023 15:15:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3A0B6B0075; Mon, 7 Aug 2023 15:15:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A1D5A6B0072 for ; Mon, 7 Aug 2023 15:15:06 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6BD8DA0794 for ; Mon, 7 Aug 2023 19:15:06 +0000 (UTC) X-FDA: 81098261412.04.395C3B2 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by imf24.hostedemail.com (Postfix) with ESMTP id 2DFAB180005 for ; Mon, 7 Aug 2023 19:15:03 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=bootlin.com header.s=gm1 header.b=e7NedBUz; dmarc=pass (policy=reject) header.from=bootlin.com; spf=pass (imf24.hostedemail.com: domain of miquel.raynal@bootlin.com designates 217.70.183.200 as permitted sender) smtp.mailfrom=miquel.raynal@bootlin.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691435704; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yRj+biPMMEewkac6Mh9a3dsWTbsGp7QJKvi4ppoOr4E=; b=3lKJeyO9uxe/8exbBDTkJnZHAWpdXgjPZq0MMLqvgHVt6+84ochB8paQ55QFGzR1HpNVf+ PjOtWNxyyvZ3rQPOwEhn5C1g2EuxSZp7obxreK1H20AJ/hQOP4Jn5u8ggjhA4HGwz+8XAK US5HumsyYDXxfarOZ548LGFEz2m48hE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=bootlin.com header.s=gm1 header.b=e7NedBUz; dmarc=pass (policy=reject) header.from=bootlin.com; spf=pass (imf24.hostedemail.com: domain of miquel.raynal@bootlin.com designates 217.70.183.200 as permitted sender) smtp.mailfrom=miquel.raynal@bootlin.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691435704; a=rsa-sha256; cv=none; b=fA9pKk5PvbL090jz4Z6Di3/Qa9AAjCrYmD2ecS0URv7m+yrHLWnZ9MDa2G1MbdDvQ2q5UP wozOLikhQnao2jwoFTUBT8DU6lE01UIy5DZlADuDB2FQ/MTTE36JfV2mouABHqdyHgaOjL vEa/aFrG2lgwM61/VJnbueX1/JXNTpk= Received: by mail.gandi.net (Postfix) with ESMTPSA id 56C7D20003; Mon, 7 Aug 2023 19:15:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1691435702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yRj+biPMMEewkac6Mh9a3dsWTbsGp7QJKvi4ppoOr4E=; b=e7NedBUz8FCKyn34LBafArR+xm10mVJf1SCtEIdVi7y/spS2KC83Lhirwvo21f7Z9Zit+p QS0O7spXvHzkVxORccCm4/neMeVHTyt2HIrlRZx1AGyqIDNvtwqFuWzO6toul7RrNvkVKK fYthc6uWWSWHz++PugRhl+Xxgi8ocDUKVt2GNVcFXke1gWSlavGYBtiGUEJ/sXQkPe/jDc lKLWfPcFhAC3eL7lahNAFTFPWtl8Lvxtd82ch+WoMlS5n4SL1zVJZ+0hMu0YQtGIw8otFY ikTEhTohN4frpXRf4Ks5uAOD9JPWwCyXAR++0x0L0+jUcV5vOIqnO3Iug/khCA== Date: Mon, 7 Aug 2023 21:14:58 +0200 From: Miquel Raynal To: Sricharan Ramabadhran Cc: Manivannan Sadhasivam , Dan Carpenter , , "Md Sadre Alam" , , , Linux Memory Management List Subject: Re: [linux-next:master 1937/6910] drivers/mtd/nand/raw/qcom_nandc.c:2941 qcom_op_cmd_mapping() error: uninitialized symbol 'ret'. Message-ID: <20230807211458.3de7c627@xps-13> In-Reply-To: <908ee5e8-6213-5685-7094-8c4b1282015c@quicinc.com> References: <7ad1160b-5f8c-47af-a1c5-51b34f656fab@kadam.mountain> <20230804184550.0cb12369@xps-13> <3604e2ed-8d30-4f7b-9e56-7af5b23b2ac5@kadam.mountain> <20230804190750.3367a044@xps-13> <20230805065510.GA18650@thinkpad> <908ee5e8-6213-5685-7094-8c4b1282015c@quicinc.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2DFAB180005 X-Stat-Signature: aouoxye3x3wsqe6nuhqbs8m8nigw9wi6 X-Rspam-User: X-HE-Tag: 1691435703-709115 X-HE-Meta: U2FsdGVkX1+ityP5rBNS9OSaqmaFiN7BaU161CqkvaUKZ1aJkdGUJYowvqIseTB0O3h0Hjms7INuwbwJ28/X0spcSIfbCVZ+sQw7yx+pljk6X5Bw/E0ykD4yqrUhK3Ywhyq81iuJwI/SrZ0rVd5fh+KG3qJuCmyKb2KbmsfFPo1iXfNbdMlEa40aqlmAGcXZD+8mmW8/xzvHdXPTq0uBLjy7O60O0eekeKRnLB1RrqiNiZW2JbDfIfr9fA+L8x3JewMNrGGFj+2VVnkxS04N0+Px43Ykd9se8eSC/EzDQC9NUR/ENwuCgrMsnTJtqDR05RUib0odDv16gdNWqgMPbwnagjYV3nJJM1CyEPS8zvGB1+zsYzek+DUCfN03eWsslBSPCMyV0kDFZ5bEIwU7RuTK9PXX1qZAzloUoxs9LFBMdT/HQB+QopOMzdxCFp48S8Z3VB7Q5g7qc0AaLFSO2MXVV3vvEtrRwiFMHEBc42CHfGAluPJmvRNgN4C0OhxHGChZNIEaYr51zapt19ymrvny49MqTkDyCH8glmy2phGjhq2hEjbolI+e68Ne7YZCetv1tzHl74ZLL99Wvqt3U06nJlyJ+2IVkki5Zjm/oxuZYcUDW0soZ/Su3F/c8qoSrKqyqMjoyfvkb6VPVEV+5NQBGNCLzhFyYJ1m6VF12seb3+2zYHtdFqc0kMPlbucOaYaU0o7WLo3DfczfbsBuU55nc9hIT9RIsK/4k2db4Kq2IH6CUx+bUKKRscaeHbEEqMN9EGwM50IX+EvUySx3qBAukC7lI/A+qIAN44y4EE9XiQMFNQOGTGndoi8To8XCaBgsToQVXzVz0yWOrk8QYi4UR5gcQGpIyo/HqKb2+wsc7Wex8mfXYYAOwLK6yEq2zo5pfjIpBEIeqRMQQefSALsjfmHW0GiFlhAtTJ56CI/mbKgH+HrbPXzoQwO00JANkmj1lRlD25NmO6nJlII K2n6bDeA ZqNGuibNh+VHd8xZ/GnwQ3FkzGZg7E+u89VFJtcU7eeYm8Vpno1E3oAWmpB59eQnIwt3fzOZ/5gG1Dplo6i2H2R5/Gv2haEFhZey/7rKcp/bnEeTbXFhWV+bsDI60HMszwtj1ds86iYc24LzTDghcqRPd4HkCrxOByq9y7vLlrkvKxjyvw+1QizOh4nsdXUfpv0/Yd8WPa8vyS9Xqjb/NKwLyhQ+YKJPA7jhy8JOJV6RGSbmeO45crEzqCXPdgvd10/9YtkFOWF/e/4dVAsX9AM66dtPJnFDgRayG5oAynsEkBCW3JHgXwo8W1dza5bQYdxZ8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Sricharan, quic_srichara@quicinc.com wrote on Tue, 8 Aug 2023 00:24:08 +0530: > Hi Mani/Miquel, >=20 > On 8/6/2023 1:28 PM, Sricharan Ramabadhran wrote: > > Hi Miquel/Mani/Dan, > >=20 > > <..> > >=20 > >>>>> The || should be &&, otherwise it cannot work, or am I missing > >>>>> something? > >>>> > >>>> Yeah.=C2=A0 That's how this bug normally looks like.=C2=A0 NAND_OP_C= MD_INSTR > >>>> always returns -ENOTSUPP. > >>>> > >> > >> Yes, this is a bug. > >> > >> I didn't get a chance to review the exec_op conversion series (blame >= > myself). > >> Now I see scope for a cleaup series :/ > >> > >> Let me spin something by the end of today. > >> > > =C2=A0 Thanks a lot Mani for the quick fixes. Will test it. > > =C2=A0 Sorry it was a holiday for us past few days, so just checked th= is. > >=20 > > Regards, > > =C2=A0Sricharan >=20 > With this series applied on linux-next, started seeing the below > messages flooded on console while doing mtd r/w. > "xxx "Opcode not supported: 0" >=20 > opcode '0' corresponds to NAND_CMD_READ0. This command inturn was > invoked from qcom_nandc.c driver from below places. For read/write_page > driver does not use the exec ops. Hence these calls just ends up > being -ENOTSUPP and ignored. So removed their invocations. > If this is fine, can this be added to your series ? (will send > git-format patch to add to your cleanup series). So far, tested > mtd raw/block read/writes and all works fine. Will do further tests > as well. Unless I really don't understand the controller, this is non sense. nand_read_page_op() is precisely what allows your NAND to perform a read. Removing this call cannot work. What you need is a proper ->exec_op() implementation, and repeating this becomes slightly annoying.=20 Look at your qcom_op_cmd_mapping, you don't even have a path for reads. I bet something along: CMD_READ0: ret =3D XXX_OPCODE_READ; break; will make it work. Please fix the driver and test with nandbiterrs -i. If this test works, it is encouraging. Otherwise it is still broken. =20 > --- a/drivers/mtd/nand/raw/qcom_nandc.c > +++ b/drivers/mtd/nand/raw/qcom_nandc.c > @@ -1470,7 +1470,6 @@ qcom_nandc_read_cw_raw(struct mtd_info *mtd, struct= nand_chip *chip, > int ret, reg_off =3D FLASH_BUF_ACC, read_loc =3D 0; > int raw_cw =3D cw; >=20 > - nand_read_page_op(chip, page, 0, NULL, 0); > host->use_ecc =3D false; >=20 > if (nandc->props->qpic_v2) > @@ -1890,7 +1889,6 @@ static int qcom_nandc_read_page(struct nand_chip *c= hip, u8 *buf, > if (host->nr_boot_partitions) > qcom_nandc_codeword_fixup(host, page); >=20 > - nand_read_page_op(chip, page, 0, NULL, 0); > nandc->buf_count =3D 0; > nandc->buf_start =3D 0; > host->use_ecc =3D true; > @@ -1965,8 +1963,6 @@ static int qcom_nandc_write_page(struct nand_chip *= chip, const u8 *buf, > if (host->nr_boot_partitions) > qcom_nandc_codeword_fixup(host, page); >=20 > - nand_prog_page_begin_op(chip, page, 0, NULL, 0); > - > set_address(host, 0, page); > nandc->buf_count =3D 0; > nandc->buf_start =3D 0; > @@ -2039,7 +2035,6 @@ static int qcom_nandc_write_page_raw(struct nand_ch= ip *chip, > if (host->nr_boot_partitions) > qcom_nandc_codeword_fixup(host, page); >=20 > - nand_prog_page_begin_op(chip, page, 0, NULL, 0); > clear_read_regs(nandc); > clear_bam_transaction(nandc); >=20 >=20 > Regards, > Sricharan Miqu=C3=A8l