From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B496EB64DD for ; Mon, 7 Aug 2023 05:32:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A5F006B0072; Mon, 7 Aug 2023 01:32:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A0F306B0074; Mon, 7 Aug 2023 01:32:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FDA68D0001; Mon, 7 Aug 2023 01:32:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 802AF6B0072 for ; Mon, 7 Aug 2023 01:32:16 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 50265120588 for ; Mon, 7 Aug 2023 05:32:16 +0000 (UTC) X-FDA: 81096187872.13.7B3E97B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 7906240005 for ; Mon, 7 Aug 2023 05:32:14 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MiUVl9Ps; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691386334; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZisOrxyI729GqhsMT5DDFaYjbV5LYsuwwLcqAK1ju3w=; b=ZDnwEAHH8P7GVnx4V00WFy5sFJ2sy+RbHvfBJ6B+Xk3yETNVwGtV+05UOtxGhM5vu3pUp5 liM2fEwYMb18bZ5EqUMCBgLMAX6yfcP3kP2Ket8tYNnEjBgh4GdFqCdFNnyTb1Zu64dfM3 hv+d4Xdop+yRQwFoedFcwEOwHx/HMNI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MiUVl9Ps; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691386334; a=rsa-sha256; cv=none; b=RxBs8N6Sr77Ti7joBsoLWUAA/GeE/JzsapcSQ+fD8Pbs1sDFc9BHejyCLf2Fta2KBmTp7w GjkZQgKlXwtVdtRJjgsetmNsx5bPlxTw+2O7Jwguugyo0avEm6LQR0dtDFQN7/O7exXsKO g2xJPFASBZPEyVRIvYXKFQLS1CN8iCQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 713A06146F; Mon, 7 Aug 2023 05:32:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60E15C433C8; Mon, 7 Aug 2023 05:32:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691386332; bh=Nx33dZHqYps2LYUm/QBXsjpmf7uARmP1F3mLqF1K4lg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MiUVl9PsDHH/Ak6HhKuKR0mNY0qc0g6L6J05y1ZwVpcmaPuxjZQ7uxFIKZhhrunhL +mZMMAlyKNIoGfndfUNW7yoCIGRZyhcPcIY7yRZpqz4BlYZHnUJ+fN6TAUV33dNMft yzMWmyRFAOrp1ifPMbb0IucPe6pGmRPipXLEXi5QSP6OFJlY/nplFpdIhyUU9zag0i aaQO0DsBGCjN4KpLWQqzAtIetv8kJQ4RZLsE4m4GCltVzDArn3Sa1Ij8bpuii6GvSN BwFx0oFE/D+u9b9ncSRDfE6JZPOdBLBnqguktESDdaJMzybj6T8iFG5ji5fY5Pr9sP VI/8xxWNFkpgw== Date: Mon, 7 Aug 2023 08:31:23 +0300 From: Mike Rapoport To: Miaohe Lin Cc: akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND v2] mm/mm_init: use helper macro BITS_PER_LONG and BITS_PER_BYTE Message-ID: <20230807053123.GJ2607694@kernel.org> References: <20230807023528.325191-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230807023528.325191-1-linmiaohe@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7906240005 X-Stat-Signature: tjbmh37oxc44w5sz6wcjq5ryq4y7rdxb X-HE-Tag: 1691386334-954212 X-HE-Meta: U2FsdGVkX1+R4F7UxWrwI2147t9y7fd7qy99EEu3IJ0NgSZ4a/ZKtoQMqHnxXZVA6JWay3NL8TMNGhS7RJdmc4mvbpz2u5/9KrQaXkvV7ONgQo3iCHrRN4bk3G6EayCp/M/oYE0+4mgRG6QOGq1v8rHsCCFVsfa/UL6aJxs+n6fNLzjxPwvK8g3oQ+Q08BCYEyaOa5lunPGzvB5ZEnF2OsepNXL/Puj7aB65YVmWUHIiLwgfm4VrmsiNVdeVk3UMi8IvxZRwGDInx13rp46t02ADCeOmBR/1unu3MIpFs2e8BskeuXkEaritCY+kEgfs1HGb7ehoyrB2YHDicvoypUasT6lZ83g/R48CamA7GIfle24e3M1v+gA47uL/OHctd3xKdeXath1Eg9XygkHR7ItyzTpAL3KYrUw/yh/Mhnz/IrTmNk35RkpshYaZmEtzfwLOlYy7R0J4JpopMmDwxk4d1MzLF+KGvAW77gDpMxljJx2cEasgGKIFziu0SlEAS+yxNnuCQyxc0p6eYlKOCSCDETDZvujBaoAAuk8E16ke0SdxqACuJ97k5+p49ZUnr1KfO9Qy/CLHfVk1EBY9FmzZ2tF8DhEHXD7BewSqlwxwowOkz5OxZ9KuMIzeCsrY2SU1le8iz1TN+k2GUitu6ZR+aLZB/T3bGs4RnBt3d2krwwrnFvxIwLZs5ioBIA+h8K0sGs7SfqLpsveSwDj0uC/nK9ongdEb2mz7pzDQHwiABeo0B7YW/KK8eI95JaiO4iDU9V76G1ruBsz9ERumu8na9gjqPINvQUQBXW5W44AwcZ+o7Z1Q2CfQ/ybYz0EwsTvYK7lE+hFeQT5I7j9thMECK+fY9WGm29GqQTI15iFQ/kZk90D4zPriN9SOVB2rdp+iAiOjV90c1cs8stn89M7mN2LZOVAgXP8OBXbaJYmKM16IilJgNXFIb3LInkOWpzOAaRp+BRzoidVazic JA4EvzP9 RBmGhqES9jzx4s9zyU1CZTdvDuECqbIkOFkXjT/zcbCt2oqYgbEfLK6oE+yiE+BvivrVg6iCkf+Me0/kV5OFBiEP4+gOyTcde9Wmo3kU39U8ztU37egUf5cXA32HIAeLo9euLFqEFZGblFCcPYpAtuMjE9TgbgXRINl2GItttDrDUlHzDSARmmEQAL6LzdulB3Xj60T5oIyjdKgGE4GbTYQLLKyyoQgPfWVH017s3zYFMfykg65bEudLBeLddQPsELLYBMTS5vL7INS6F1A9dOqT8NfPcJ0cRH9WDL7Hb7QJQCXv3F/Nqv5O0n9mDEuoiHfXhCIwUb7I4Pf703Cpn0IliHsW+SJnypPnXqV5NwLa2IlqC5FJgw4uCmiuVvwcuhH8d2d1AV9oVg8yIvvjr4YT5rdilxDc1QKF0ev65u43vNpYM1+SUdY1QTUFukO7zkQTL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 07, 2023 at 10:35:28AM +0800, Miaohe Lin wrote: > It's more readable to use helper macro BITS_PER_LONG and BITS_PER_BYTE. > No functional change intended. > > Signed-off-by: Miaohe Lin > Reviewed-by: David Hildenbrand Reviewed-by: Mike Rapoport (IBM) > --- > v2: > use BITS_PER_BYTE per Mike. > Collect Reviewed-by tag per David. > Thanks both. > --- > mm/mm_init.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 66aca3f6accd..93b1febd4a32 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -79,7 +79,7 @@ void __init mminit_verify_pageflags_layout(void) > int shift, width; > unsigned long or_mask, add_mask; > > - shift = 8 * sizeof(unsigned long); > + shift = BITS_PER_LONG; > width = shift - SECTIONS_WIDTH - NODES_WIDTH - ZONES_WIDTH > - LAST_CPUPID_SHIFT - KASAN_TAG_WIDTH - LRU_GEN_WIDTH - LRU_REFS_WIDTH; > mminit_dprintk(MMINIT_TRACE, "pageflags_layout_widths", > @@ -1431,9 +1431,9 @@ static unsigned long __init usemap_size(unsigned long zone_start_pfn, unsigned l > usemapsize = roundup(zonesize, pageblock_nr_pages); > usemapsize = usemapsize >> pageblock_order; > usemapsize *= NR_PAGEBLOCK_BITS; > - usemapsize = roundup(usemapsize, 8 * sizeof(unsigned long)); > + usemapsize = roundup(usemapsize, BITS_PER_LONG); > > - return usemapsize / 8; > + return usemapsize / BITS_PER_BYTE; > } > > static void __ref setup_usemap(struct zone *zone) > -- > 2.33.0 > -- Sincerely yours, Mike.