From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7430EC04A6A for ; Mon, 7 Aug 2023 05:08:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE83A6B0072; Mon, 7 Aug 2023 01:08:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A98C56B0074; Mon, 7 Aug 2023 01:08:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95FA08D0001; Mon, 7 Aug 2023 01:08:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 89AD66B0072 for ; Mon, 7 Aug 2023 01:08:17 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 57DAA1C8FDE for ; Mon, 7 Aug 2023 05:08:17 +0000 (UTC) X-FDA: 81096127434.30.D31BDD2 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf01.hostedemail.com (Postfix) with ESMTP id 9C74540016 for ; Mon, 7 Aug 2023 05:08:14 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691384895; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wBeyCtY1bXLiisRJCG9PLR0qcRdf25xzqxIDsAZ9EZw=; b=WQ4Z+oJmeyuhsqSN0yDHs8VAGXGuGurb9lG1OYOfL6On/NwXXbShk+N1XHvfO/Oo/9vpO/ D6iaGnktIEKI64xKs6cqptLUC9/I4m2cbvC4N7bxK0If3WZIkFaFS1G4mPAk6Q0OWGOZix V4mp2Vg+LWXB6vu7w8WeRqnsCpITmB0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691384895; a=rsa-sha256; cv=none; b=JQ5qcrmZChXhovKPnUDWKpryHdmBd2UYTmlRtrXrqScbSHar4eEip1pvzMQ2nV7aFAOcxx P3GNooHMuo0L8T1WqCHi/dvG8DFWdAxkxOwyuv4EIdg9S+W+w/kMcnMNkfpnb/8fJBtfeG +NMYtXGDmrPrEdTOdxaEgvWdrEu3UZo= X-AuditID: a67dfc5b-d6dff70000001748-47-64d07c3b9fd9 Date: Mon, 7 Aug 2023 14:05:31 +0900 From: Byungchul Park To: Nadav Amit Cc: Linux Kernel Mailing List , linux-mm , "kernel_team@skhynix.com" , Andrew Morton , "ying.huang@intel.com" , "xhao@linux.alibaba.com" , "mgorman@techsingularity.net" , Hugh Dickins , Matthew Wilcox , David Hildenbrand , Peter Zijlstra , Andy Lutomirski , Dave Hansen Subject: Re: [RFC 2/2] mm: Defer TLB flush by keeping both src and dst folios at migration Message-ID: <20230807050531.GB49200@system.software.com> References: <20230804061850.21498-1-byungchul@sk.com> <20230804061850.21498-3-byungchul@sk.com> <7023C1AF-6C9B-4544-8EC4-0BB790C1E338@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7023C1AF-6C9B-4544-8EC4-0BB790C1E338@vmware.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJIsWRmVeSWpSXmKPExsXC9ZZnoa5NzYUUg70zWSzmrF/DZvFiQzuj xdf1v5gtnn7qY7G4vGsOm8W9Nf9ZLc7vWstqsWPpPiaL67seMloc7z3AZPH7B1B2zhQri5Oz JrM48Hos2FTqsXmFlsfiPS+ZPDat6mTz2PRpErvHiRm/WTx2PrT0mHcy0OP9vqtsHlt/2Xl8 3iTn8W7+W7YAnigum5TUnMyy1CJ9uwSujOcbTrAWLGep+La+kamBcTtzFyMHh4SAicS9Q/Zd jJxgZkvfOkYQm0VAReL08a8sIDabgLrEjRs/mUFsEQFFiUP774HVMAtcYZH4Oo8PxBYWiJE4 seUzE4jNK2Ah8XbyeqB6Lg4hgamMEje6b0MlBCVOznzCAtGsLvFn3iWwG5gFpCWW/+OACMtL NG+dDbaLU8BOYu7Wy2CtogLKEge2HWcCmSkh0M8u0br+BjvE0ZISB1fcYJnAKDgLyYpZSFbM QlgxC8mKBYwsqxiFMvPKchMzc0z0MirzMiv0kvNzNzECI3BZ7Z/oHYyfLgQfYhTgYFTi4W04 fD5FiDWxrLgy9xCjBAezkgjvvCdAId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rxG38pThATSE0tS s1NTC1KLYLJMHJxSDYwLzmalnNw73+ta+XS3QBE57ZZHr3+Y1l9/G+zH/Ef6Q+S97EyB4K2T vxw4s0JDsTEr1DJxKrezpNmdQrUJ9Yf5Xuz/vc04uVcm4J7kqjslD7/8PPZh/v3cFw6aM/cd WPG9c/eriQE9XssqdYPma3puUi5zL9O98ZRFOzboj6Cg3xy1ayeyc1KVWIozEg21mIuKEwFN 4viIvAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIIsWRmVeSWpSXmKPExsXC5WfdrGtdcyHF4P92E4s569ewWbzY0M5o 8XX9L2aLp5/6WCwOzz3JanF51xw2i3tr/rNanN+1ltVix9J9TBbXdz1ktDjee4DJ4vcPoOyc KVYWJ2dNZnHg81iwqdRj8wotj8V7XjJ5bFrVyeax6dMkdo8TM36zeOx8aOkx72Sgx/t9V9k8 Fr/4wOSx9Zedx+dNch7v5r9lC+CN4rJJSc3JLEst0rdL4Mp4vuEEa8Fylopv6xuZGhi3M3cx cnJICJhItPStYwSxWQRUJE4f/8oCYrMJqEvcuPETrEZEQFHi0P57YDXMAldYJL7O4wOxhQVi JE5s+cwEYvMKWEi8nbweqJ6LQ0hgKqPEje7bUAlBiZMzn7BANKtL/Jl3CaiIA8iWllj+jwMi LC/RvHU22C5OATuJuVsvg7WKCihLHNh2nGkCI98sJJNmIZk0C2HSLCSTFjCyrGIUycwry03M zDHVK87OqMzLrNBLzs/dxAiMqGW1fybuYPxy2f0QowAHoxIPb8Ph8ylCrIllxZW5hxglOJiV RHjnPQEK8aYkVlalFuXHF5XmpBYfYpTmYFES5/UKT00QEkhPLEnNTk0tSC2CyTJxcEo1MB79 EW614ZDPpZP9z8uj5VglLs579PDZqz4JS5b326Xa5xe+tXGTTDdeOWPrsucXPVdxX1V4OjHk OMuuc1vfTFSe0hnmmpF1tzF/3v6n6lp3M9T4j3K07o+veqH/2tdyr1n4BCavOyl3A5ao+txd 51THf7TObIpodYJmyWzN62pJkqfXaj961anEUpyRaKjFXFScCAAKeW/NpAIAAA== X-CFilter-Loop: Reflected X-Rspam-User: X-Stat-Signature: fxf6wn3jgc65fi5ri6p7xapqkqe4m1ts X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9C74540016 X-HE-Tag: 1691384894-227038 X-HE-Meta: U2FsdGVkX1/9g5vcX640MgwJHqDOxujBWvUtCObmdyj0LaRwjkI2Ph6hSE91J8h2LrJKjM3vtmJBFdj5wTY1TFXHHFuOsRsJ9hfZO50aPvmLHzANP2uSBueNkwLegUxc9Upqpm+boYe/6MD58+0aI9ZCeDYN+j5v8DUBw+fphbv2eG6EQLNY3KEKrXf/yb/bIeIZwmfnTAEKPqqmsa53wzzMtkiv39N2hbYif1VhFO9wDHxBlHvryBgxGad0v/GoWjmWrbxgmEeDoAJAEuzD1QzjpQjLKzr+P2R/7Xr9SpQJQrqEL0n14xyDD1g7UloqeeIyBQ1n9zRDRWC5bNMb4CX1Zi36WN66nuXoRdCFjqRnffkemdEIDIy+Y6+y2IEfY83Uj/ua+bfsB02+/9l7xXP9K8vwPSrm9oTNsgx50xyEA6zBw34AjsAKG30Ac/GJdU03M8u7I5TygKy2zaqwBCiLsP8i8Ks8+y2dULzspqaiKnv4XU0lZQqXqYU2OiRvhDkmV7r4JMqWmP0mOJdRFYctQBrNgHjPOB/45IGfKm1Jyte6G/WULnkP66gE6zPA57UgD9bWlD//+rG5KsltGHNtsJfT17KoYcl1m3dyhSsjGxnd3NTEBOlGSTBau67Div55Szg+6sNPwUy5YvaxsRfjL6Uiu6lIKtAZsK0RkERyixzR4F00DLKfDyT6qZsgu6r6+a6t8pxDFPDnAd7GhaL3Y1zf81wJz0TeRyOGy0X3vASswA1UHz0FTeROq7BlJnHY1P3JbgnZNh1eNw0hNosR24wIq2HunHxfkLe6y5+br8f/LI+qTlQ8gaf8zdsmo1TMymquLSSvgqS56q36+pDkxfQFzwW7BEnTlt8NMAyX1I2N1/xPGlDeqtdPNNgvWOsneyiSzOKMl+QWhwU0jNrSJHe6U6IMxUpQlGSwu5S3jUa/vvZnFC1eBk9yt8MXHhBurcDxO4I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 04, 2023 at 05:32:30PM +0000, Nadav Amit wrote: > The patch in its current form, I am afraid, is very very hard to review. > It is way too big and is missing comments. Having CONFIG_MIGRC makes no > sense (I guess it is intended to be a “chicken-bit”). Variable and > function names are not informative. The memory barriers are handle > improperly (please check again the smp_mb__after_atomic() rules). I checked it. I found what I was wrong at. Thank you for pointing it out. I will fix it from the next spin. Byungchul