From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2049FC001DE for ; Mon, 7 Aug 2023 09:34:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 877D16B0074; Mon, 7 Aug 2023 05:34:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8286A6B0075; Mon, 7 Aug 2023 05:34:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EFD58D0002; Mon, 7 Aug 2023 05:34:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5C1616B0074 for ; Mon, 7 Aug 2023 05:34:41 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1E77814071C for ; Mon, 7 Aug 2023 09:34:41 +0000 (UTC) X-FDA: 81096798762.18.1FD0740 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 710041C001A for ; Mon, 7 Aug 2023 09:34:39 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="J0VCkR6/"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691400879; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+aQwET61FK2XgWybyK/tMPbg15vI+gQYVutWs2lVi20=; b=GIe34SPpCSpAvo1qzhMHIjbDfoRHP7FDvoOxuU2n8VwSeAajsI2bUutxmBj2JwqH9y7fSa zmX3pgOj0JjwmidXLaj14Ys7oAuQLjEP1gObV/oUx3kyKTO9hOhUTwCm5AwlsMxJnzOx3G clR3QONpha+guEhq/c0+I77aPR0qj+U= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="J0VCkR6/"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691400879; a=rsa-sha256; cv=none; b=7TxwJ8XbMeknLgcrn0Pa9VMHNvjRY3F69Bf9ioEdC5Yq/Xy+CM/ajkoCcuCyGCvHh3SUtb xB/CHcYVmyQ2D2eEytY4rIik6uBzY8O8Nz1jJwiaBxCH6E+LLshchVcCbvz4Lk5gHh+bLb i6x55p/Ksjqgrs0Mp2EEZg7zWybjy6Y= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A8502614F9; Mon, 7 Aug 2023 09:34:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7281EC433C8; Mon, 7 Aug 2023 09:34:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691400878; bh=v8Y3H4khCX0WxHBuKfcC45Vawb/clen1V7JGX+PMtv0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J0VCkR6/jXHfsvifgTcTnTJFAI23sbPvMrD2xNVLYqlzCV5UUBRuaquQ093BQ3Y5c krIKPseWsjk/IJ/Ci9aqZRLDQYPkoAlEU97zNUBYYM5TYYBcU0q4HAySllUzMWYFSk flo1AHtIeTivGZKK+7AdYEP0aJf1GLhZpX6tAbu5zFUhwkWhDrwS6zAS0tk+bMNIqX injp+JPgbbCKH5Ixi2z4O4hiJ9U4YQHGQNKh8JmSJ6u/pWLdoKsmEejYGb69xV5IFO wBEUVjzPwimCtqqF118+lrDi2Ei+HzS0V0erHKPYmmTLcuswGFJQTXPiTy9dvSik42 4Z1dY7LaWc6gA== Date: Mon, 7 Aug 2023 11:34:28 +0200 From: Christian Brauner To: Carlos Maiolino Cc: Hugh Dickins , Jan Kara , Dan Carpenter , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH vfs.tmpfs] shmem: move spinlock into shmem_recalc_inode() to fix quota support Message-ID: <20230807-haartracht-sammeln-fbc99df8aa33@brauner> References: <29f48045-2cb5-7db-ecf1-72462f1bef5@google.com> <20230804-legalisieren-neukonzeption-97314400abbd@brauner> <20230807093222.o46d7kexapywe5jl@andromeda> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230807093222.o46d7kexapywe5jl@andromeda> X-Rspamd-Queue-Id: 710041C001A X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: huyzz7a171zefgm5mj5cj31eh4bdj67o X-HE-Tag: 1691400879-364515 X-HE-Meta: U2FsdGVkX18TWLHGUr1ygfq00UBYeazyGUJsAze3T8NpduXV+l/knOhvC/mGTYAek4YdYGgUeA3SoiCuzBWIdB74xEPtkswx1+l6tOEFIBGZaN9rAYNNQnyKj0Moi8oE8D9rAmTcLWQXO9A/vv+v1OWrGh4TLriDlFjl8hCDWbtEpwe6lI+xjPNCkpfTvzU2DS22pdcOF+YX/FsQkVE1FL5r3BUNLaXsdELhy2SjSl7emdm1Midno1d92CTO6rRFpZ6Ni9ui76G/FUtgBzc0fdIaqyjXVtj6yLhVQYmAhca9Fd7+F5e/6GpgNQei1d//H7p7HEFkRsqNvCNsxRs1d11GFTOYSHx4C8MjYtvB4yFrlroWyqN+yQOtjnZ3HxPBJJfnADm9cCRx608e6onmQVztDPmgIY9GNDL/eYsVC4YlJTADGOJy7j+y1TXS+njSs4AlgvYmJt3dtxpjZpQWtjs7ArvoLFmauSOQcY/hd4mSFspEkUSfXx3TXdsMZW4k4UAir9TinEZnuEJNAce5wFPHokSGVH+Apb+RdVW09ZHFL0zu9h8piVG2sKjymFxNfCyiEM7ZsqobIvWf/0tAwzDGa3Rkfs2dF9mnzOhSDQiD5s9MPUxTXqAQMbwceEj0VF268jkC6dh1Twi/QrBGoGIUYAwfW8pP0pEUI+ym+Jd9s08OmUtKEHZ6QmqWzIMvzwqhXo563/ucgl5gfCT0m36YnCOXmfXxB7GcLoSfQBg5xiyMZ13IWz6HpFW9NpRuazEvxXVPoRLgGJ893/6gfVzC0+MyJVOKrmSIz7BMTV9Snh+MiCH1tQ2iL1tB4syWEuWFkoYBectEpCuNsSNT5YqXnT8NtvtpnbvyLcyikYWJBAy7VFwThF44txS8L8Pc4D94s4SpeMFjvt6qv6cIMGmgYGnhKMyRQ3jk/LqG0wGWeo7C8JWtU8EKXp4JETUxyo2A5i6kW+SuIwuKZJa TMir1ivo H3cEPLmDBCAnsFWQ9YG7rRdCubV8IDR6+ZmBEN+6jrtkyJ8eNSGPjwl4dvnSC3CgNJNfVWnt566xdfgFDKWHC5aEqcKksjd0giN/d/M71YRKvzINjpqg7YZUfelLWBeL7q9dguLC7CQVIkcfRnMwPjNBSWyQYH8La/XiNflu1D84NOHGILFHSHoyVAP/TFF7slL+xUEwhKwFQl7KbGbB3+G4xvmw+RFj86MqMiwaEl2KC8lpjCloIax1SVz+RAVEx/GPrRp75TcA08UIs3jgus/tp/36h5FbnJc4MHdvcHuvKMlwydmri+DrYmxKP8TWldRmAsDfbS0d0hrDsRuUEYWiHb2FzJOe7ozLbXbc5CYtmuBrHgwa5mNPbn85gOXJjrzwgXSNjEuebeDQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 07, 2023 at 11:32:22AM +0200, Carlos Maiolino wrote: > On Fri, Aug 04, 2023 at 11:31:33AM +0200, Christian Brauner wrote: > > On Thu, 03 Aug 2023 22:46:11 -0700, Hugh Dickins wrote: > > > Commit "shmem: fix quota lock nesting in huge hole handling" was not so > > > good: Smatch caught shmem_recalc_inode()'s shmem_inode_unacct_blocks() > > > descending into quota_send_warning(): where blocking GFP_NOFS is used, > > > yet shmem_recalc_inode() is called holding the shmem inode's info->lock. > > > > > > Yes, both __dquot_alloc_space() and __dquot_free_space() are commented > > > "This operation can block, but only after everything is updated" - when > > > calling flush_warnings() at the end - both its print_warning() and its > > > quota_send_warning() may block. > > > > > > [...] > > > > Applied to the vfs.tmpfs branch of the vfs/vfs.git tree. > > Patches in the vfs.tmpfs branch should appear in linux-next soon. > > > > Please report any outstanding bugs that were missed during review in a > > new review to the original patch series allowing us to drop it. > > > > It's encouraged to provide Acked-bys and Reviewed-bys even though the > > patch has now been applied. If possible patch trailers will be updated. > > > > Note that commit hashes shown below are subject to change due to rebase, > > trailer updates or similar. If in doubt, please check the listed branch. > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git > > branch: vfs.tmpfs > > > > [1/1] shmem: move spinlock into shmem_recalc_inode() to fix quota support > > https://git.kernel.org/vfs/vfs/c/f384c361c99e > > Once Hugh patch fixes the issue Dan reported, I believe I don't need to resubmit > my series? I've applied it and it should already show up in -next so yeah, no need to resend.