From: Kemeng Shi <shikemeng@huaweicloud.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, baolin.wang@linux.alibaba.com,
mgorman@techsingularity.net, david@redhat.com
Cc: shikemeng@huaweicloud.com
Subject: [PATCH 9/9] mm/compaction: call compaction_suit_allocation_order in kcompactd_do_work
Date: Sat, 5 Aug 2023 19:07:11 +0800 [thread overview]
Message-ID: <20230805110711.2975149-10-shikemeng@huaweicloud.com> (raw)
In-Reply-To: <20230805110711.2975149-1-shikemeng@huaweicloud.com>
Use compaction_suit_allocation_order helper in kcompactd_do_work to remove
repeat code.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
mm/compaction.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index f4b6c520038a..05c27a1ef68a 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -2963,12 +2963,8 @@ static void kcompactd_do_work(pg_data_t *pgdat)
if (compaction_deferred(zone, cc.order))
continue;
- /* Allocation can already succeed, nothing to do */
- if (zone_watermark_ok(zone, cc.order,
- min_wmark_pages(zone), zoneid, 0))
- continue;
-
- if (!compaction_suitable(zone, cc.order, zoneid))
+ if (compaction_suit_allocation_order(zone,
+ cc.order, zoneid, 0) != COMPACT_CONTINUE)
continue;
if (kthread_should_stop())
--
2.30.0
next prev parent reply other threads:[~2023-08-05 3:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-05 11:07 [PATCH 0/9] Fixes and cleanups to compaction Kemeng Shi
2023-08-05 3:14 ` Matthew Wilcox
2023-08-05 4:07 ` Kemeng Shi
2023-08-05 11:07 ` [PATCH 2/9] mm/compaction: call list_is_{first}/{last} more intuitively in move_freelist_{head}/{tail} Kemeng Shi
2023-08-15 7:49 ` Baolin Wang
2023-08-05 11:07 ` [PATCH 5/9] mm/compaction: remove repeat compact_blockskip_flush check in reset_isolation_suitable Kemeng Shi
2023-08-15 8:42 ` Baolin Wang
2023-08-05 11:07 ` [PATCH 6/9] mm/compaction: rename is_via_compact_memory to compaction_with_allocation_order Kemeng Shi
2023-08-15 8:58 ` Baolin Wang
2023-08-15 12:04 ` Kemeng Shi
2023-08-19 12:14 ` Baolin Wang
2023-08-22 1:51 ` Kemeng Shi
2023-08-24 2:20 ` Baolin Wang
2023-08-05 11:07 ` [PATCH 7/9] mm/compaction: factor out code to test if we should run compaction for target order Kemeng Shi
2023-08-15 8:53 ` Baolin Wang
2023-08-15 12:10 ` Kemeng Shi
2023-08-19 12:27 ` Baolin Wang
2023-08-22 1:57 ` Kemeng Shi
2023-08-24 2:25 ` Baolin Wang
2023-08-24 2:59 ` Kemeng Shi
2023-08-05 11:07 ` Kemeng Shi [this message]
[not found] ` <20230805110711.2975149-2-shikemeng@huaweicloud.com>
2023-08-05 17:11 ` [PATCH 1/9] mm/compaction: use correct list in move_freelist_{head}/{tail} Andrew Morton
2023-08-07 0:37 ` Kemeng Shi
2023-08-15 7:16 ` Baolin Wang
[not found] ` <20230805110711.2975149-4-shikemeng@huaweicloud.com>
2023-08-15 8:28 ` [PATCH 3/9] mm/compaction: correctly return failure with bogus compound_order in strict mode Baolin Wang
2023-08-15 9:22 ` Kemeng Shi
[not found] ` <20230805110711.2975149-5-shikemeng@huaweicloud.com>
2023-08-15 8:38 ` [PATCH 4/9] mm/compaction: simplify pfn iteration in isolate_freepages_range Baolin Wang
2023-08-15 9:32 ` Kemeng Shi
2023-08-15 10:07 ` Baolin Wang
2023-08-15 10:37 ` Kemeng Shi
2023-08-19 11:58 ` Baolin Wang
2023-08-22 1:37 ` Kemeng Shi
2023-08-24 2:19 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230805110711.2975149-10-shikemeng@huaweicloud.com \
--to=shikemeng@huaweicloud.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox