From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48794C0015E for ; Sat, 5 Aug 2023 17:11:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C03FF8D0002; Sat, 5 Aug 2023 13:11:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB13D8D0001; Sat, 5 Aug 2023 13:11:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A78F68D0002; Sat, 5 Aug 2023 13:11:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9722A8D0001 for ; Sat, 5 Aug 2023 13:11:14 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6FCE7B21B0 for ; Sat, 5 Aug 2023 17:11:14 +0000 (UTC) X-FDA: 81090691668.18.C66DF7C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id B32A680020 for ; Sat, 5 Aug 2023 17:11:12 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=2XN9wsHU; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691255472; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e7eb3W2pUVEgDFBu6KHqbVI7rDpFgwtfUVmf2p1ECPA=; b=vh9MQL9BHr8AlpfmdWH9YJR41WwPy+G7rN1Xzn0WMJin+ZPJS98o9WZQF+AgJ/An96DMer do2ke1yJg0mXD8S9zqbeejKbtkSqoGtoyHyRFVOQr6PYDWzts47sLToJ2O4oSr6NcpqyRe zzxWqMYpoWHf3RWbWDcKfiLEF8/0qw8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691255472; a=rsa-sha256; cv=none; b=bMAMgIzfHNJSH2JcFLp1x+zj4e7OgsQLpIQAa+jK0avemehLMFhcIvcI2qim9JPqggyAUE HB+orS5VrLdKiong7zFFG17jFS12sPkTweyWIBr3eFu9MFz8T3f3fvC1ye4+RgD7KO4SIw QwVe0oTZ6rAblLWsrNQ0QvaLsQ+D3FI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=2XN9wsHU; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C41D360C5C; Sat, 5 Aug 2023 17:11:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCF1CC433C8; Sat, 5 Aug 2023 17:11:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1691255471; bh=kIW2ToFnM5JhLxQbr+hFkYlTARFnsrqMHbJ+6K7FJDU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2XN9wsHU0mB5AAZhW+OTNCDcQ0xanRYZHpbgozUxdNJ2zOBGHeKQ8lXBaHEH9Kj5k Ozp1an1x6HFCggQayOPNoQ3aU+2QP5uX+mm3VRL5FVjfe6Ol1ec7DxRVEjBSl/jqQ1 cuAakzhvsk2U1YWTCde+RradwvVF8dVaZHleZqxs= Date: Sat, 5 Aug 2023 10:11:09 -0700 From: Andrew Morton To: Kemeng Shi Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, david@redhat.com Subject: Re: [PATCH 1/9] mm/compaction: use correct list in move_freelist_{head}/{tail} Message-Id: <20230805101109.740fdc21418d0753c4658df1@linux-foundation.org> In-Reply-To: <20230805110711.2975149-2-shikemeng@huaweicloud.com> References: <20230805110711.2975149-1-shikemeng@huaweicloud.com> <20230805110711.2975149-2-shikemeng@huaweicloud.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B32A680020 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: yeo348b8xgf8htucekriaaztpnwd4jdo X-HE-Tag: 1691255472-33959 X-HE-Meta: U2FsdGVkX1+G/aclX/A93E+hR9UH/m3pUn0aCwh1sWR6KVcKTq9KPVLIodfTCwke6vXwUIewIFImoUUfo3MyV00omTeePfQWBAy891l6HGrX+GfQwXBA/UsL5bMh2bNoz2XluwlNYs2teiNhbdQizMKiDYieC1EhIwy4BkmwKGzaJHLkIMMXEnuncv5/aNrFOYEDBQFYZl0pyaB7/Dclj1mEUiMrmRNsVlCZ7JE4G0f90jT2HhAzHDEYT0GQZWr3BBsNLKJmSiCsqio/2Nb86iiqH3TuRrpP24mvPEeaCRsVjl3YoCfwwDYUpNAIoP/6o8n7D8u5tV7ePrjfa4g38WhRAUk12igeq16UMFsR8Xy/c+uk/RedgZcuLJFGJ6wlceHUqgsbSyFx1dy2yqdu9jM15O1NYFYWQFzCAglLvux2+mwuAVt3W8Fk2KYmZtpMDMcn+xGzy7MgwzCwdyoQwE3wB4sWYY0NmiqF1zEqgir8+wLUW1UMTe1nvKNW2rk5rcgThtWT1qhAfd4JyR1hYLhvzUmLWmG8SmwSAv4gPHl2IGeboXhexDsEBkDWRIreZjin55C1yyx1Q842kmusLhjHuBq6Dewt1FZwRw2yCV4DENGWURRyyyAOQLkRcM1ZeHH5yE/5PkKdHG6vSdxZHesx00PJvWUXQhGZBpem+fd/AHKJugcl6XF/ePej9op1+q0V2NQUB6FqONJ+lalXq/baXJyRbXYbXiRRcxfhe0sRdgmNLc8DkfoJU3shcXdQIg7QX5dOPygkZbUlC2MIB8lusMj04b9iwkuAIUUaVJZCW5LeafaK7KZGHJu4kizKcTv6qovSjNyQpKU0xQ8HW6ay84osxql/BQu3J1CqNJVc+i4v0QC9G2ZmGK2byx1EhJ+1ZN8yxBwPpC5lfMmmriHDj3aNss4VTnltVfdZ4a8zbPrxygYOm8BSlkx0JLlfX4UhxyGChRWIvMCI9cS gcjF2RSv 6OddMEyh11k0xnarhZta+r05pHQ5M4Fy352V2/Fa4hA2j+OpAfNypYhqMgRbIfuz4uRpxCCcGLsNn5tvC9FEjbvUnEso7opqllxk/v4COHN/W4MA1WUw69EcCvyMB/iv1rNpk/FzCv33wz+LC+HA8CQNg/rt7PoeWDGzGc58L2nmacRcxSpsevB6wgdlLT8xWdtZKRYXGhZ2Wwhx6gqpHX0ly8W+kb1x8kpU4OWRcOd/zliBHvHtfT08s1ZvB6xGk1PEQ4PeOuGCoeaJxZFpmuTwkE3Cv6y+d8HViocq37HyFVwG3zgdb2fU0QACEs54nj89yrd6+cXJAibt1KMncG0LPfcubpJ1yUbOdxCoMNqHn2FHEcrRbbXXBTl0KjVAf55vUq3s4xZpisLnGiz9lA5zqfmCeyS6kxYP3XxYfR866ycY45ORVaAtimg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 5 Aug 2023 19:07:03 +0800 Kemeng Shi wrote: > The freepage is chained with buddy_list in freelist head. Use buddy_list > instead of lru to correct the list operation. > > ... > > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1395,8 +1395,8 @@ move_freelist_head(struct list_head *freelist, struct page *freepage) > { > LIST_HEAD(sublist); > > - if (!list_is_last(freelist, &freepage->lru)) { > - list_cut_before(&sublist, freelist, &freepage->lru); > + if (!list_is_last(freelist, &freepage->buddy_list)) { > + list_cut_before(&sublist, freelist, &freepage->buddy_list); > list_splice_tail(&sublist, freelist); > } > } > @@ -1412,8 +1412,8 @@ move_freelist_tail(struct list_head *freelist, struct page *freepage) > { > LIST_HEAD(sublist); > > - if (!list_is_first(freelist, &freepage->lru)) { > - list_cut_position(&sublist, freelist, &freepage->lru); > + if (!list_is_first(freelist, &freepage->buddy_list)) { > + list_cut_position(&sublist, freelist, &freepage->buddy_list); > list_splice_tail(&sublist, freelist); > } > } This looks like a significant error. Can we speculate about the possible runtime effects?