From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88776C04E69 for ; Sat, 5 Aug 2023 03:21:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7BFA8D0002; Fri, 4 Aug 2023 23:21:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D03E88D0003; Fri, 4 Aug 2023 23:21:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4BE98D0002; Fri, 4 Aug 2023 23:21:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A2A4B8D0001 for ; Fri, 4 Aug 2023 23:21:03 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6FEF5C0199 for ; Sat, 5 Aug 2023 03:21:03 +0000 (UTC) X-FDA: 81088599606.20.A4D59E9 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf11.hostedemail.com (Postfix) with ESMTP id 323DA4001D for ; Sat, 5 Aug 2023 03:20:59 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=none; spf=none (imf11.hostedemail.com: domain of thunder.leizhen@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=thunder.leizhen@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691205661; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=5lbVtJ38zoj6WWnS0l5uqhOfVFbkWu4GVLq9WSdTSYc=; b=fyilr5RBhj3jaAkZVb/c748NPD0bpKmGc5rwBWsacKhvsXNN2ylSGC1h/fP2dWGQZl92Eq NGZw3W7j2LbNl3nbnXTL9P7qOzALqNah/yijwfxaJ4o5cEfasl4KjJDDVMMFe8HlDzzqwS 2lkBfwc/2fkjAOYOthr/yPYBsaRZrUw= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=none; spf=none (imf11.hostedemail.com: domain of thunder.leizhen@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=thunder.leizhen@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691205661; a=rsa-sha256; cv=none; b=L5GPGoD/Dza+78XAQeHyR2pZ/VCsXGfYtrR0W/l4LZIa9gtruuRahDuHxRBYvlHp7aMcEI e/w4MzajJTbf6u5cE3410wRS4pdasuLiDoJTAjuRhsQSVw82xnN+Ej3w4W78pls/AgCIp6 ktUuflX1KD5BxDMe5GOFHrY4Q8ILV/I= Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RHnsc438Wz4f3lDk for ; Sat, 5 Aug 2023 11:20:52 +0800 (CST) Received: from huaweicloud.com (unknown [10.174.178.55]) by APP4 (Coremail) with SMTP id gCh0CgAHoZQRwM1kZdNePg--.61999S4; Sat, 05 Aug 2023 11:20:52 +0800 (CST) From: thunder.leizhen@huaweicloud.com To: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, "Paul E . McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , rcu@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Zhen Lei Subject: [PATCH v7 0/2] rcu: Dump memory object info if callback function is invalid Date: Sat, 5 Aug 2023 11:17:24 +0800 Message-Id: <20230805031726.1230-1-thunder.leizhen@huaweicloud.com> X-Mailer: git-send-email 2.37.3.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:gCh0CgAHoZQRwM1kZdNePg--.61999S4 X-Coremail-Antispam: 1UD129KBjvJXoW7ZFWfJry8Cw4rJw18XrW8WFg_yoW8Zr18p3 ZxW3sxWr1DJry3CF1fZF1xCry5Zay8GFsIk3ZxZw4kuw1YvF97uF97Jr1IqF98GF93K3Wj ya1Y9F1jka1DZrDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvYb4IE77IF4wAFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6r1S6rWUM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7M4kE6xkI j40Ew7xC0wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F4 0E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_GFv_Wryl IxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxV AFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6rWUJVWrZr1UMIIF0xvEx4A2jsIE14v2 6r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07 UKfO7UUUUU= X-CM-SenderInfo: hwkx0vthuozvpl2kv046kxt4xhlfz01xgou0bp/ X-CFilter-Loop: Reflected X-Rspam-User: X-Stat-Signature: xhtef3wk1zeadi9cerewh6978yg35gyb X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 323DA4001D X-HE-Tag: 1691205659-520945 X-HE-Meta: U2FsdGVkX18eMZJYHYWTHhaU90BMXBdp1KpEzMWPlZaGT7GQIJ7TYnyuDnOeHxncIAaxnyGrbbSyu3ac5P/o+11Y1d4pQlo2MG/ZomcHoGi0uyQJ087NXFRoQz2GO2HVUQdus1cfKkS4ZI8/Mb9gNXJedinr/2YgCQbR6wEIv+elp1YCZKo91awaEixnKSwGy93jikg5ywjPmBuac/OMZ7XbH7jEt7INVdU48e7WS5eUGYhxL8DQ1bAhyhSoNUiOZi9kB8zdEAusDwj3jw8aZqWfHX+zb2T8I7jotFNDKJahV9mFRSOlia+cFEVuyh+4VNWX+gs5v4x/3AOgpAdZ7QOxPSNaurhFjLQAn/19kvRT6e3k6RcJEYub+eL00aF8m1Cg+ozxGxArHgrlPFiukDFdIftaK/OJa5bOfg2YA2NaQjVBAURx1vdm3J3LhNNLke/Gyhq39Pe9zULw4j0lh8JKjpgNhi+rP2k4VjPTbRotxY3OIF5vsUXN3sBLvEawC7D1j73dklAD3cqjsXP3fEguAeRcc5cZXIFp4wvxmz5CtYsKhp/EYkRWjtHJmSHWHvLnbjzOJ7ri2pdeVHBOjrIVmOhXUj7lXbsGK+KBlBGXaWO+Frx+ir9oDBL99hl9c+l+PQQlQ994e/pBSK2kmj4xkpIO4YQRMIXn3mCb9zrfw+d5z079bPiDOfG0q8tzXogz/ttIG5etF6ZScfhv95LYanqsrdlPyIjtsseWsVZ6ipT/aVesJErh7X5nAyGtgq7Z+RSqyaPAG2wOxoJytXdjb3yUQDBHLg1dMyljf1zNLnw2KNQ37gg1xHnNzX3b1eQadZk6a7eGqLxmKBod/1Oahi4zLo/dwGrxAh5bOLlHCH5yGuBYbIS6O/2D6essBMr2fiBFSYkBDwnY9vLfWJ/wQi/8I3nuvO2UQ4epm1JJmZ+v8UuTQf/E0YSuYB67eJqnP7xlPfy5kiLkBGJ zYrGPASw Z4+rsA+aj1xygrcIrYm/tNyDq/Rug98AwmvPowLzW9ApbkPWv11H7Rtehu8BU7d/KsytRrzEC05NWqzdJsvVkvVGu5CT58mJ1paRCqY2aaG1TrsUosG52jiVIyHYzWrVGtXcpd/zDWt9poUZm+LibaoGr1BvIDrLE6u2h7OyiROWw0YAAV15Qi9pM/IJ8QEfMuITyy66NtS2ltD1sIM/j6Pd1D7u148v+4kodpsx2yCj8hoXTpOhCXgnR++Jh4Vkgz40Au2hkwi7Jo6mJmJ4+rsxDKQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Zhen Lei v6 --> v7: To avoid snowballing, resend the two RCU-related patches that we've discussed OK. The remaining three patches themselves do not need to be gone into RCU tree, I'll send them separately for discussion. v5 --> v6: 1. Use print_hex_dump() to dump the memory of slab object. 2. Add a new dump prefix DUMP_PREFIX_ADDRESS_LOW16 3. Minimize the output width of the offset v4 --> v5: 1. Add Reviewed-by Acked-by for patch 1/3 2. Add patch 3/3: mm: Dump the memory of slab object in kmem_dump_obj() v3 --> v4: 1. Remove kmem_valid_obj() and convert kmem_dump_obj() to work the same way as vmalloc_dump_obj(). 2. In kernel/rcu/rcu.h -#include +#include v2 --> v3: 1. I made statistics about the source of 'rhp'. kmem_valid_obj() accounts for more than 97.5%, and vmalloc accounts for less than 1%. So change call mem_dump_obj() to call kmem_dump_obj() can meet debugging requirements and avoid the potential deadlock risk of vmalloc_dump_obj(). - mem_dump_obj(rhp); + if (kmem_valid_obj(rhp)) + kmem_dump_obj(rhp); The discussion about vmap_area_lock deadlock in v2: https://lkml.org/lkml/2022/11/11/493 2. Provide static inline empty functions for kmem_valid_obj() and kmem_dump_obj() when CONFIG_PRINTK=n. v1 --> v2: 1. Remove condition "(unsigned long)rhp->func & 0x3", it have problems on x86. 2. Paul E. McKenney helped me update the commit message, thanks. Zhen Lei (2): mm: Remove kmem_valid_obj() rcu: Dump memory object info if callback function is invalid include/linux/slab.h | 5 +++-- kernel/rcu/rcu.h | 7 +++++++ kernel/rcu/srcutiny.c | 1 + kernel/rcu/srcutree.c | 1 + kernel/rcu/tasks.h | 1 + kernel/rcu/tiny.c | 1 + kernel/rcu/tree.c | 1 + mm/slab_common.c | 41 +++++++++++------------------------------ mm/util.c | 4 +--- 9 files changed, 27 insertions(+), 35 deletions(-) -- 2.34.1