linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm: no need to export mm_kobj
@ 2023-08-04  6:43 Greg Kroah-Hartman
  2023-08-04  8:09 ` Mike Rapoport
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2023-08-04  6:43 UTC (permalink / raw)
  To: linux-mm; +Cc: linux-kernel, Greg Kroah-Hartman, Mike Rapoport, Andrew Morton

There are no modules using mm_kobj, so do not export it.

Cc: Mike Rapoport <rppt@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 mm/mm_init.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mm/mm_init.c b/mm/mm_init.c
index a1963c3322af..1c9d6f428906 100644
--- a/mm/mm_init.c
+++ b/mm/mm_init.c
@@ -154,7 +154,6 @@ early_param("mminit_loglevel", set_mminit_loglevel);
 #endif /* CONFIG_DEBUG_MEMORY_INIT */
 
 struct kobject *mm_kobj;
-EXPORT_SYMBOL_GPL(mm_kobj);
 
 #ifdef CONFIG_SMP
 s32 vm_committed_as_batch = 32;
-- 
2.41.0



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm: no need to export mm_kobj
  2023-08-04  6:43 [PATCH] mm: no need to export mm_kobj Greg Kroah-Hartman
@ 2023-08-04  8:09 ` Mike Rapoport
  2023-08-04  8:22 ` Miaohe Lin
  2023-08-07 15:22 ` David Hildenbrand
  2 siblings, 0 replies; 4+ messages in thread
From: Mike Rapoport @ 2023-08-04  8:09 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-mm, linux-kernel, Andrew Morton

On Fri, Aug 04, 2023 at 08:43:37AM +0200, Greg Kroah-Hartman wrote:
> There are no modules using mm_kobj, so do not export it.
> 
> Cc: Mike Rapoport <rppt@kernel.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org>

> ---
>  mm/mm_init.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index a1963c3322af..1c9d6f428906 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -154,7 +154,6 @@ early_param("mminit_loglevel", set_mminit_loglevel);
>  #endif /* CONFIG_DEBUG_MEMORY_INIT */
>  
>  struct kobject *mm_kobj;
> -EXPORT_SYMBOL_GPL(mm_kobj);
>  
>  #ifdef CONFIG_SMP
>  s32 vm_committed_as_batch = 32;
> -- 
> 2.41.0
> 

-- 
Sincerely yours,
Mike.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm: no need to export mm_kobj
  2023-08-04  6:43 [PATCH] mm: no need to export mm_kobj Greg Kroah-Hartman
  2023-08-04  8:09 ` Mike Rapoport
@ 2023-08-04  8:22 ` Miaohe Lin
  2023-08-07 15:22 ` David Hildenbrand
  2 siblings, 0 replies; 4+ messages in thread
From: Miaohe Lin @ 2023-08-04  8:22 UTC (permalink / raw)
  To: Greg Kroah-Hartman, linux-mm; +Cc: linux-kernel, Mike Rapoport, Andrew Morton

On 2023/8/4 14:43, Greg Kroah-Hartman wrote:
> There are no modules using mm_kobj, so do not export it.

Yes, there's only in-kernel user left.

Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>

Thanks.

> 
> Cc: Mike Rapoport <rppt@kernel.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  mm/mm_init.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index a1963c3322af..1c9d6f428906 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -154,7 +154,6 @@ early_param("mminit_loglevel", set_mminit_loglevel);
>  #endif /* CONFIG_DEBUG_MEMORY_INIT */
>  
>  struct kobject *mm_kobj;
> -EXPORT_SYMBOL_GPL(mm_kobj);
>  
>  #ifdef CONFIG_SMP
>  s32 vm_committed_as_batch = 32;
> 



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm: no need to export mm_kobj
  2023-08-04  6:43 [PATCH] mm: no need to export mm_kobj Greg Kroah-Hartman
  2023-08-04  8:09 ` Mike Rapoport
  2023-08-04  8:22 ` Miaohe Lin
@ 2023-08-07 15:22 ` David Hildenbrand
  2 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2023-08-07 15:22 UTC (permalink / raw)
  To: Greg Kroah-Hartman, linux-mm; +Cc: linux-kernel, Mike Rapoport, Andrew Morton

On 04.08.23 08:43, Greg Kroah-Hartman wrote:
> There are no modules using mm_kobj, so do not export it.
> 
> Cc: Mike Rapoport <rppt@kernel.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>   mm/mm_init.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index a1963c3322af..1c9d6f428906 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -154,7 +154,6 @@ early_param("mminit_loglevel", set_mminit_loglevel);
>   #endif /* CONFIG_DEBUG_MEMORY_INIT */
>   
>   struct kobject *mm_kobj;
> -EXPORT_SYMBOL_GPL(mm_kobj);
>   
>   #ifdef CONFIG_SMP
>   s32 vm_committed_as_batch = 32;

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-08-07 15:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-04  6:43 [PATCH] mm: no need to export mm_kobj Greg Kroah-Hartman
2023-08-04  8:09 ` Mike Rapoport
2023-08-04  8:22 ` Miaohe Lin
2023-08-07 15:22 ` David Hildenbrand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox