From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C3D8C001DF for ; Fri, 4 Aug 2023 16:55:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 072398D0001; Fri, 4 Aug 2023 12:55:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0225A6B0072; Fri, 4 Aug 2023 12:55:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2C4C8D0001; Fri, 4 Aug 2023 12:55:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D08986B0071 for ; Fri, 4 Aug 2023 12:55:41 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9B24B1A1483 for ; Fri, 4 Aug 2023 16:55:41 +0000 (UTC) X-FDA: 81087023682.08.42F580A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 0649740011 for ; Fri, 4 Aug 2023 16:55:39 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of "SRS0=OePh=DV=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=OePh=DV=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691168140; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Dbj/KSVmtwg14H5VwNBUkTFhJijCzuzYCZRpYGz3CTw=; b=v7XzczX+1bgTDgCqjqV3RrCNAWy/n5Vldz0smUc45AtfsAeJD1BLxXUNTXsWBbXX1M3Lgn TBW+5exQOlLy9WvJM/m4HtqebaKk2R+aDwPKqdyNGcntGtBulhBPgvJg34Y6uu4fHk1IJw ObbIu0GePOjty1dVlh8WtLb2M1sr/Ms= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of "SRS0=OePh=DV=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=OePh=DV=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691168140; a=rsa-sha256; cv=none; b=QtcHanYIigEA5drczhl2qJlCwtwCKC+fBpu9ProujJhiiHtSE5QlaB+ZxCp37O33WFCmgx oq43wDED60dEw6tmO5aE1a+a5pZ0Y2SPubN5LvtDYIjtXs6o8hxWTQDejIeOwFaIx3oge/ EPaAe+xN/qrajNpUHDsMYg5kleh8+3Q= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 36F91620AC; Fri, 4 Aug 2023 16:55:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B1A8C433C7; Fri, 4 Aug 2023 16:55:37 +0000 (UTC) Date: Fri, 4 Aug 2023 12:55:34 -0400 From: Steven Rostedt To: Marco Elver Cc: Andy Shevchenko , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Petr Mladek , Rasmus Villemoes , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton Subject: Re: [PATCH v1 1/4] lib/vsprintf: Declare no_hash_pointers in a local header Message-ID: <20230804125534.6324f731@gandalf.local.home> In-Reply-To: References: <20230804082619.61833-1-andriy.shevchenko@linux.intel.com> <20230804082619.61833-2-andriy.shevchenko@linux.intel.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: w1nnnqcd4o17sodzq7xqnkas4nmuxy5j X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0649740011 X-HE-Tag: 1691168139-876041 X-HE-Meta: U2FsdGVkX19ecUhryidMNEA174etlJ6jejHDeNeqgNAVAG+vSPJE+hSdz1ucZPBl3Y/gM5W/UNw07QbNDr832B4Qw2NfaD+wTaLI6RQna90pBorgdmh9sSirJWh2cRqzZsXtmFZbO6XE6n7rGAseA6JpLJ8rrPnZXXnbTMnxBA+4gRf1KDvq85YTjMPuZj0om+DGZZGZotG5KuVAcO7FRbNs2Qn/JfLsCajo/8mJKE2cxiqkVGrgLkRVLc2ED5mM/uIlGtIAb832SGgDBoGFfz9k/uo0LcsZ+Ol1e5M7TOuni4sxjEr0KBe1eUiO0rDTmXDuiGH88rOvTuje+8jQ7XW4U5Zltu/r7MelTtXMTVmhP2UTbaGqEM6y5BvNBWQvswQhX3FRoACcmJQBKI5NvnLVrsOrydigAtWnyI4ZiFqlC8GOf4Ix37VHa3G132O3KxjALH7PG3DzFydlYDAUz0HDMfSpkj/Db4pLTW2Of6Ax5Fe9Tj2UKAd3rCK1ZzPVkX7axYm3nvl/qFN6z2ZPgUD2QtB6h6PfibZtc08Nh8PcMw3ijvt9nZOibo7qCFz3qFttwVeeaZuYDx9bMuEGCQHTGTd0fcUqBfrc1aqouCT+T7GEtZ92M2Osl/+yUaN+92/Qgxfpiyq3DIU+PojMW2r1jAt/x0U7DEngsWgzPxCggArQnev1bFOA06f9MZL1rRJ73xjJwcEqtu3JLesP8U/SdnfqEhx9I3OKLH+KENEYBqZsyhh9wzpV+DCDSWGKp9f/dc4dEjbTnha/zu5O5mIMYOXz/Lg4h4hqC7UEs+ZuAtewOG8CIMNL1zzUgO8meiQ2zNdwTlIjZc4WQKL4zWqCQIquBnjLS/L3tHuhePJlhEpQOErDO8hzkXJfT560quWgj+ET6cVQgCjgWCYT1tNVR/+xaFPrcVZfBI714NpTm5pHcWkkyIZJonNVl09bwzmzfIUpwcGaZwkMkFD Xcvf1lfX Pq93+T3K+EZbLsMreMV7Y387fAINLS1pKAxHfk4245YuklHUpJEo3JlshVujKkGR+GpGu042DnEgrFYoi1gGoQhzXE2VotPBDwBNtBACoP3wMFWmMM8gnkqtzxlTd+wo+uYHsJjva63MAMGeHK13WKgWwFBp8td7grZ5nzRGjLNKkj04Rw2X1ri2kh4RGcixz8GMbUBfA5l//s4jYeJfw5p2BRrUer9E4JHp7mprIGoW6VpsdqhcfYZh9nPQ6WaiWJwVfL+s294bS788fOFzxAFgr9HVJaOsEslSdTKu079UdTE4qKYvvhBLw5cummzIpDcmdq11aiLTZJUsfRbmNW5P0CtCEfGIhz9PLDuyn6Xv6mpsYFPYRxkrTsYNn0W773zux4YaceEXILx6dPQJ6j38W5ZVn+EXTjkX76xfqd6MWz28= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 4 Aug 2023 10:38:22 +0200 Marco Elver wrote: > > +++ b/lib/vsprintf.h > > @@ -0,0 +1,7 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#ifndef _LIB_VSPRINTF_H > > +#define _LIB_VSPRINTF_H > > + > > +extern bool no_hash_pointers; > > + > > +#endif > > It seems odd to create such a local header and then refer to it from > other subsystems. > > What's the downside of just putting this into the new > include/linux/sprintf.h? If someone wants to access this variable, > they will one way or another. +1 -- Steve