From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C038C001DF for ; Fri, 4 Aug 2023 09:11:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B13302802DE; Fri, 4 Aug 2023 05:11:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB4B82802DF; Fri, 4 Aug 2023 05:11:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 907002802E0; Fri, 4 Aug 2023 05:11:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7D60D2802DF for ; Fri, 4 Aug 2023 05:11:53 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 40DE4409C0 for ; Fri, 4 Aug 2023 09:11:53 +0000 (UTC) X-FDA: 81085854906.23.0C1B2EE Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf21.hostedemail.com (Postfix) with ESMTP id 3369F1C001A for ; Fri, 4 Aug 2023 09:11:48 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=none; spf=none (imf21.hostedemail.com: domain of thunder.leizhen@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=thunder.leizhen@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691140310; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=pbc1e2wSj4KKNLXhTU2gq4ocG/OJeTiw0YfDxZFjhd8=; b=5cBkZjC1fJopRG611hbmX0H7Gh7o/tSWvN1c6UuUam4Qy5H61/wdqy5NIR6iToPWlvs0Rr vAZvZpa0ZNTxMQiCFPohHlSxKKcmhXdQcuZcz6sJbK5z9Q3uUAKs+QJi3mnvEtOhDy+PT/ Ug7OcBbuwm9eLREEeE8IvwkdzslRg1Q= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=none; spf=none (imf21.hostedemail.com: domain of thunder.leizhen@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=thunder.leizhen@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691140310; a=rsa-sha256; cv=none; b=B/Vx8P5vLDZMraGABMk8OWsoCaDevHBbd0UCuLajKinMGE/G7CcpMQmuKF2z92d0J/1RN3 Vpq99Epuk03BMTxRVS/RIU1MI5wQn/ylGkTWMxZC1dMRElUa3cGlml8RK8xcC2Yc6hmsAL gWCSp30TMYpCO9mbz9+YFpFmzWvYIjY= Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RHKht3khZz4f3v4g for ; Fri, 4 Aug 2023 17:11:42 +0800 (CST) Received: from huaweicloud.com (unknown [10.174.178.55]) by APP4 (Coremail) with SMTP id gCh0CgBH_rHLwMxk2KskPg--.58335S4; Fri, 04 Aug 2023 17:11:42 +0800 (CST) From: thunder.leizhen@huaweicloud.com To: Petr Mladek , Sergey Senozhatsky , Steven Rostedt , John Ogness , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, "Paul E . McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , rcu@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Zhen Lei Subject: [PATCH v6 0/5] rcu: Dump memory object info if callback function is invalid Date: Fri, 4 Aug 2023 17:11:30 +0800 Message-Id: <20230804091136.1177-1-thunder.leizhen@huaweicloud.com> X-Mailer: git-send-email 2.37.3.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:gCh0CgBH_rHLwMxk2KskPg--.58335S4 X-Coremail-Antispam: 1UD129KBjvJXoW7ZFW3ur4ruryktryxAF47Jwb_yoW8Zr4Upw nxW3sxWryUJry3CF13ZF1I9ry5Jw4xGFsIk3ZxZw18uw1Fvr97uFykJr1IqF98GF97K3WU t3WYkF1jkF1UZrDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUv0b4IE77IF4wAFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6r1S6rWUM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7M4kE6xkI j40Ew7xC0wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F4 0E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_GFv_Wryl IxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxV AFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6rW3Jr0E3s1lIxAIcVC2z280aVAFwI0_ Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU1 6uWJUUUUU== X-CM-SenderInfo: hwkx0vthuozvpl2kv046kxt4xhlfz01xgou0bp/ X-CFilter-Loop: Reflected X-Rspam-User: X-Stat-Signature: tn4oik3caw74ye166qypkzkeyzoxs3rc X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3369F1C001A X-HE-Tag: 1691140308-545292 X-HE-Meta: U2FsdGVkX18d9HniYfcOkkq53zKirnTo2UtoWVyKLxnhaU9tSV2b8iY2gm5VSmp24lUDel7AVpS3MbN9/kT1BZnTMRNWUsQMEp8BHBa5d7G6X+su87bHkFSMCObXQ9LP9hX0ykBTQ7YkjkEZEzN+IYUoe3JeaHaFCe+CAC2+O8i3IODuf+uVXWSw8abclIHxG0g4PwcT4jb80GVFEnO/ejeq/ijRTJ/WwkqGG05USzEbQZI/MDpwhoAMb8VgEaCMJYw0gwZ0SNFgEAv/fFHVlb1hySC8q0WKkoysV4uEVGfuv/OMXFko+Hn46oKmGDu++s/4l/pKu6B1oj1tw8q8XtovDPHZdffvwhA9/mJahpxGayB0z4U8u++J39zNfQJ3+SPnbppTrpp/u6XyEVKq2gt7RqxsLSepRs0JNXFPJQzTsupJsPzXjCteSZkI91p2Y6kBAn65ciIfWl3++/W9Sl7FT2igft2jRu6PwCZCy97lZS/p5zR530P2w+iW8QpAFo4eltmbb3vlo2vcbAlpMSbHF9+/y/WrrwBNZR3RnvPPAyjmQqqYbJAlqjYxjphOlHU1lQ8VfRSJR1t43Ox8icNq3Nu0ZjD33FtCMb2VXersEHpwnz06mYJFFsTuJE+YAAbQahW3nFZVneoH0MLR9nmPmsRbX2Fe6+Sx5+nHI3fvXnYlV3iCRihqjN53De7iK5ZlqJqH4nGM+YmAVujfdlMx/f8o0uVBD6hB5ZJhz6fXvZc+ZUfQTr3B/QA20yDsTOFMifwBvF/mqtNUOAI6SR+buI/XLB7vBQibxMiKHdlo3Y1Tiv/nt4uiNeQsRzxHm8apVRo+5q3dj8xfMUsXJeTeeZUGjNWYdLGL5ZTc5J0UERWs/DfdMuiyxO0osx2bTxjUCiK/9gltiAfHz+DHk3VQYjp3aMha4Hov8gJB/alhKdiJ5MUoPIncjhf+NrYgmWsQcGns2OwLXZqTtGo PY5voNx/ F6o9x1UKqL+9woiN0Pw4dBuQxPv4oHyhSjwE3EZizEDGGtsSyT1pl1FnTnIrDbv+F+rTSzu+IuFnuBbOIJHOlwS/BmKN+RB1lEzwiJUeJQCvHI7jaU3Tz+MjesrCPXBfjdQCOC8wVbgB2oIZqJO7fXU8Prih6wyJJRH478GsFJirI6FUPWBU01BkGPpWFImAlrI/tz1AjaaFlu30O5cSUJfdFvK9tcuYfu7MOOA6L5s0h7rtYFL/rnw/+f5S8a1ldAwGScRmfpzjP2QmhltWjBrMp1AqeYd9tVmFAvydbYbayznCmuTECnFRumNeRMc2T2BlM56/SMYlEWsA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Zhen Lei v5 --> v6: 1. Use print_hex_dump() to dump the memory of slab object. 2. Add a new dump prefix DUMP_PREFIX_ADDRESS_LOW16 3. Minimize the output width of the offset v4 --> v5: 1. Add Reviewed-by Acked-by for patch 1/3 2. Add patch 3/3: mm: Dump the memory of slab object in kmem_dump_obj() v3 --> v4: 1. Remove kmem_valid_obj() and convert kmem_dump_obj() to work the same way as vmalloc_dump_obj(). 2. In kernel/rcu/rcu.h -#include +#include v2 --> v3: 1. I made statistics about the source of 'rhp'. kmem_valid_obj() accounts for more than 97.5%, and vmalloc accounts for less than 1%. So change call mem_dump_obj() to call kmem_dump_obj() can meet debugging requirements and avoid the potential deadlock risk of vmalloc_dump_obj(). - mem_dump_obj(rhp); + if (kmem_valid_obj(rhp)) + kmem_dump_obj(rhp); The discussion about vmap_area_lock deadlock in v2: https://lkml.org/lkml/2022/11/11/493 2. Provide static inline empty functions for kmem_valid_obj() and kmem_dump_obj() when CONFIG_PRINTK=n. v1 --> v2: 1. Remove condition "(unsigned long)rhp->func & 0x3", it have problems on x86. 2. Paul E. McKenney helped me update the commit message, thanks. Zhen Lei (5): hexdump: add a new dump prefix DUMP_PREFIX_ADDRESS_LOW16 hexdump: minimize the output width of the offset mm: Remove kmem_valid_obj() mm: Dump the memory of slab object in kmem_dump_obj() rcu: Dump memory object info if callback function is invalid include/linux/printk.h | 1 + include/linux/slab.h | 5 ++-- kernel/rcu/rcu.h | 7 +++++ kernel/rcu/srcutiny.c | 1 + kernel/rcu/srcutree.c | 1 + kernel/rcu/tasks.h | 1 + kernel/rcu/tiny.c | 1 + kernel/rcu/tree.c | 1 + lib/hexdump.c | 17 +++++++++-- mm/slab_common.c | 68 ++++++++++++++++++++++-------------------- mm/util.c | 4 +-- 11 files changed, 67 insertions(+), 40 deletions(-) -- 2.34.1