From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Marco Elver <elver@google.com>,
linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
linux-mm@kvack.org
Cc: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH v1 1/4] lib/vsprintf: Declare no_hash_pointers in a local header
Date: Fri, 4 Aug 2023 11:26:16 +0300 [thread overview]
Message-ID: <20230804082619.61833-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20230804082619.61833-1-andriy.shevchenko@linux.intel.com>
Sparse is not happy to see non-static variable without declaration:
lib/vsprintf.c:61:6: warning: symbol 'no_hash_pointers' was not declared. Should it be static?
Declare respective variable in the local header.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
lib/test_printf.c | 4 ++--
lib/vsprintf.c | 1 +
lib/vsprintf.h | 7 +++++++
mm/kfence/report.c | 3 +--
4 files changed, 11 insertions(+), 4 deletions(-)
create mode 100644 lib/vsprintf.h
diff --git a/lib/test_printf.c b/lib/test_printf.c
index 7677ebccf3c3..9e04b5f7244a 100644
--- a/lib/test_printf.c
+++ b/lib/test_printf.c
@@ -24,6 +24,8 @@
#include <linux/property.h>
+#include "vsprintf.h"
+
#include "../tools/testing/selftests/kselftest_module.h"
#define BUF_SIZE 256
@@ -41,8 +43,6 @@ KSTM_MODULE_GLOBALS();
static char *test_buffer __initdata;
static char *alloced_buffer __initdata;
-extern bool no_hash_pointers;
-
static int __printf(4, 0) __init
do_test(int bufsize, const char *expect, int elen,
const char *fmt, va_list ap)
diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 40f560959b16..6774cf84e623 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -54,6 +54,7 @@
#include <linux/string_helpers.h>
#include "kstrtox.h"
+#include "vsprintf.h"
/* Disable pointer hashing if requested */
bool no_hash_pointers __ro_after_init;
diff --git a/lib/vsprintf.h b/lib/vsprintf.h
new file mode 100644
index 000000000000..ddffde905824
--- /dev/null
+++ b/lib/vsprintf.h
@@ -0,0 +1,7 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _LIB_VSPRINTF_H
+#define _LIB_VSPRINTF_H
+
+extern bool no_hash_pointers;
+
+#endif
diff --git a/mm/kfence/report.c b/mm/kfence/report.c
index 197430a5be4a..fb28c6abd58e 100644
--- a/mm/kfence/report.c
+++ b/mm/kfence/report.c
@@ -19,6 +19,7 @@
#include <asm/kfence.h>
+#include "../../lib/vsprintf.h"
#include "kfence.h"
/* May be overridden by <asm/kfence.h>. */
@@ -26,8 +27,6 @@
#define ARCH_FUNC_PREFIX ""
#endif
-extern bool no_hash_pointers;
-
/* Helper function to either print to a seq_file or to console. */
__printf(2, 3)
static void seq_con_printf(struct seq_file *seq, const char *fmt, ...)
--
2.40.0.1.gaa8946217a0b
next prev parent reply other threads:[~2023-08-04 8:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 8:26 [PATCH v1 0/4] lib/vsprintf: Rework header inclusions Andy Shevchenko
2023-08-04 8:26 ` Andy Shevchenko [this message]
2023-08-04 8:38 ` [PATCH v1 1/4] lib/vsprintf: Declare no_hash_pointers in a local header Marco Elver
2023-08-04 16:55 ` Steven Rostedt
2023-08-04 16:54 ` Steven Rostedt
2023-08-04 8:26 ` [PATCH v1 2/4] lib/vsprintf: Sort headers alphabetically Andy Shevchenko
2023-08-04 8:26 ` [PATCH v1 3/4] lib/vsprintf: Remove implied inclusions Andy Shevchenko
2023-08-04 9:36 ` Rasmus Villemoes
2023-08-04 20:31 ` Andy Shevchenko
2023-08-04 8:26 ` [PATCH v1 4/4] lib/vsprintf: Split out sprintf() and friends Andy Shevchenko
2023-08-04 9:31 ` Rasmus Villemoes
2023-08-04 20:34 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230804082619.61833-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox