From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B120C001DE for ; Fri, 4 Aug 2023 08:14:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC0298E0015; Fri, 4 Aug 2023 04:14:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B71468D0002; Fri, 4 Aug 2023 04:14:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A39168E0015; Fri, 4 Aug 2023 04:14:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 923B88D0002 for ; Fri, 4 Aug 2023 04:14:19 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 66175A1320 for ; Fri, 4 Aug 2023 08:14:19 +0000 (UTC) X-FDA: 81085709838.30.83E3516 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id F1471140019 for ; Fri, 4 Aug 2023 08:14:16 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=j26W0VcE; spf=none (imf09.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691136857; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ub9xozJdZmYxTZOsQ/cHAlZFGg0APeLOKKsChweCvEg=; b=z4nrQwjgd1i53qf2Kcm8i3ofrBdzIFQEAufBNtolnKm2497TGqe5KUntkmdVtd7wgI6jy1 jMky9yijf5BfH7svLlYi9WtjmoHp9POqGEVgGgT8jRt7/01S/QEkWYJsN0wSc7MafvJQdz VGMRHy6CS+dNEFJl71/q8K++1gtrHWA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=j26W0VcE; spf=none (imf09.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691136857; a=rsa-sha256; cv=none; b=AA+MZK/pirS/y7j4SnxDoYEJ4//EKV4RtKep93PRE3VdhpfdTFl3mbFA2HPfWfT5UatOH1 HPAv819jDVXiYFn5dHmyZferKBi8x7WyzmvxGXbHUx4jOGeVbknztS1onKbGjMOn4M6fbJ 2RW8sMc2enGvhVAeGSjy1iDakBKVXvM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ub9xozJdZmYxTZOsQ/cHAlZFGg0APeLOKKsChweCvEg=; b=j26W0VcEfwD9n/UESi4BExVT/L VJk4bonbMp1xZX0mQepndaBFYIBDdlPva/uOtad5UI1cci5luDCiFkU2uMY6slW6oDjPkWmAdZ4SJ QoWVoBp1sCbQrUhOxtRceJCJt75BhsIbtQoKfZVFiTS2Rkz6iUz1ZxmoG1z/+nLilKoVAWVaZPUnS qDCtVeVO5zprkLYxtfiY9HQGfpXbnXw6YCHlb/18k9Hc0yINNhfUgyP3yKD8xVK3HzbI6CxMPHAc1 hCruKM387EpMA0P6xpiHB4T7eMFl5DJvdJE2kbLUOjOTTEs3uwnPlGCr5QQVIOJgm+OXVrYlBR2t0 DXxU2YCw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qRpwq-008lxH-0x; Fri, 04 Aug 2023 08:14:12 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 1C77730007E; Fri, 4 Aug 2023 10:14:11 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id EED1D2107C444; Fri, 4 Aug 2023 10:14:10 +0200 (CEST) Date: Fri, 4 Aug 2023 10:14:10 +0200 From: Peter Zijlstra To: Yury Norov Cc: andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, Andrew Morton , Linus Torvalds , Mateusz Guzik , linux-kernel@vger.kernel.org, linux-mm@kvack.org, tglx@linutronix.de, rppt@kernel.org Subject: Re: [PATCH v2 2/2] mm,nodemask: Use nr_node_ids Message-ID: <20230804081410.GK212435@hirez.programming.kicks-ass.net> References: <20230802112458.230221601@infradead.org> <20230802112525.633758009@infradead.org> <20230802193616.GC231007@hirez.programming.kicks-ass.net> <20230803084125.GE212435@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: F1471140019 X-Rspam-User: X-Stat-Signature: 1fuxocbzjj4ug3hwm7udos7det49wurj X-Rspamd-Server: rspam01 X-HE-Tag: 1691136856-668514 X-HE-Meta: U2FsdGVkX19o/GZogpvMq03FHYqEZ8rFaY7o+SvDp3nJcF8D4SL6PONgZ8meJn3Xh360Ydrxgy1+1um1W7p5cvzdTCUcUpMKgmHKdYZEcq/4E1hDPuzUE6CiP+qVUfwuBUGU3+ko2YTQm5fE9m688mGjUrOoKWMcSOcpbp1pZliIbVFt4SuiDsPbVVrGJReljMbYxVaW/G1zj37LhqJtKoUTF1rZ9VcTTAXRxnmSDWVOJJLfkkm7fnbyZZSOCnuGBE8x6GemA+R3CWV8PlNeQyAffWmWerECHiRwxWg5x7N7gYAV6krrsZxycvL6j9pHAtrKc31bkdd1y8SJ1lkU5kUhS6s6VYEvbDiBvhn98wfUCcB0WjtDl4a4kRqSpc244EDrJkjNnXCsAEenc99WXQ9DWvYfeSC3j5KtlNKIQYoR6mAsPBB0V/Y4fVOKcx0UbYmEvu/Q82zwGXlc4tfOl3lAUrVwCaerwy0zzyTSWYnOwNWaVk1ZLCuIUnyUIL9rPvkKfdyoPvJ+e5IX9k4nE0yHRnOWJTvY9mkvwq6xosj2qLz+JUASInAIWXiWtKBScJ65XfpV6o6kshdEUW6SN9AoHG8gqUUcPy2m8wrwfkCAeTOs2reDxmIutNFAKmmTztDHioAH0lU8u7/JaE5xfoaRX7mViFoFzCJm9TlTfKB6zS0gAJk3jejn8NC71F9uknlZoa6mR0OBWSxJXvl26MTd6j1C2lJYxyyWFfszhX8VfzsTkxHCYPNM7wBnisF57OLxryKHuUo9X5culuX0tVqEL3TZsLfs3wTc+pQltNIRyQj7UnuiWcxRgqYkaw++1KnvLpIkQdVUr3aYXo5DG15epv0x6ykZRDzH4e0PZpmVoeeuKqJnqwQ5UJebxilOC15y9KTVzlFhNTtlyctwL0YnCyYeKq69YymLbJHjW4ZaCS/Y035hdm9KanIi+RxVBTxlSzoM+GoeK4Y/yVt uPrR+gYk oyxcmSEJRFUwsRNiT+LGSNaMbcO0d6FXnKK7F83Qrm2rYIby1u7g9+A7kec4Z0pq9njWkLjZ7pTijz620Ob81aHOaZBOr6vOEskBlu/U7OyZ7YrvAnPSF2HEkkJSD4cypLezAfCUKq/l9kfGpfkJg0zWy/PWGiz1fM6twmiUkYF31e+uKKs033QSPoN6MC+lEdaXM8irtxZt6ohyTUTLB8Yg8+T7bNWRe5O8zasmqfpHyiIxXODz/uGfGlFKoznnhux9V X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 03, 2023 at 01:41:42PM -0700, Yury Norov wrote: > Consider MAX_NUMNODES == 64 and nr_node_ids == 4. Then > small_nodemask_bits == 64. > > The nodes_full() will set all 64 bits: > > #define nodes_full(nodemask) __nodes_full(&(nodemask), small_nodemask_bits) > static inline bool __nodes_full(const nodemask_t *srcp, unsigned int nbits) > { > return bitmap_full(srcp->bits, nbits); > } > > And the following nodes_weight() will return 64: > > #define nodes_weight(nodemask) __nodes_weight(&(nodemask), small_nodemask_bits) > static inline int __nodes_weight(const nodemask_t *srcp, unsigned int nbits) > { > return bitmap_weight(srcp->bits, nbits); > } That would be a straight up bug. You're asking it: tell me how many of these 4 bits are set, and they you say: 64. At which point I'll suggest they go back to primary school and do the counting lessons again. Hmm?