From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5C1FC001DF for ; Fri, 4 Aug 2023 09:31:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C2352802E3; Fri, 4 Aug 2023 05:31:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3722C2802E1; Fri, 4 Aug 2023 05:31:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 260B62802E3; Fri, 4 Aug 2023 05:31:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 16F042802E1 for ; Fri, 4 Aug 2023 05:31:44 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BF92A14139E for ; Fri, 4 Aug 2023 09:31:43 +0000 (UTC) X-FDA: 81085904886.12.26C423C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id E8D67140010 for ; Fri, 4 Aug 2023 09:31:41 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NId2hSFo; spf=pass (imf09.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691141502; a=rsa-sha256; cv=none; b=GZl9Shg5WNobYb6m+T/AEoVdAOoedYodM7+Dz+BN0l2lMHPwcbGdy+b7UPR3PiGppnfbTd sQyBarg6ln2b/P6IVCJ6CgqvBe5WQ4zogh6jTsL6laBnUT3zV4KQQ5pV4lfLnmEvAf1G9a Um7WrW+NQtztO/Hsa8wAvM4Sr3/OsEg= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NId2hSFo; spf=pass (imf09.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691141502; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=htfQuiHHBJdaFrHG012ON7qRygCdigODfWfjLhT5J78=; b=QQPtBjDfnzn+MaHu8nEZq9SPtIUbLCIaOvLrVn3WM8AiDvBxTNBeCi8pZFGTQiWX4oxl9K nEE3BX5pHw81j4fGSj5F1s2IpMwC3V8odnNgHj8ouEeOBdXVvNez4aDoHPqIZ1z+OnkALw 5pIQGhs6rNZ9reMAxhVTlimimUKzjbc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C753F61F6A; Fri, 4 Aug 2023 09:31:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62EC9C433C7; Fri, 4 Aug 2023 09:31:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691141500; bh=Mh1E9gZiK9ycp6tqPpBjwMzV6kf5/hBORiwfZeKUams=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NId2hSFoUMT5FVkJxAB/hx81gneg8ZMZlA+qtsBa8JAOwsb+l2/bicoPfbmQFEvv+ WSwJ7CmubK4r7e6pX9iUBDW+L4HQqq6Fh2WDNBxyd9CQlfJnAtU8P26KhcgrAeCkYH C0u2xQvOPHQwKD/AnmocyfcR5qkU+eZ2/RBByX0lBg6BAnEQIL69U8pm0Q6c+4DmbV Katjg6Q9Xx93HwS8CXjecnYP0tKpfvXBBQ40s7MA5Yv/C9vK9LaGXVQFUml8FYeRLN M6F8p5FW5PQEtfH+RKemuiEw5abwxmresJL8w3DWrNuNFBeVGJ63guYFjdLcSxAvSs JqvAkiE3kT/Yg== From: Christian Brauner To: Hugh Dickins Cc: Christian Brauner , Jan Kara , Carlos Maiolino , Dan Carpenter , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH vfs.tmpfs] shmem: move spinlock into shmem_recalc_inode() to fix quota support Date: Fri, 4 Aug 2023 11:31:33 +0200 Message-Id: <20230804-legalisieren-neukonzeption-97314400abbd@brauner> X-Mailer: git-send-email 2.34.1 In-Reply-To: <29f48045-2cb5-7db-ecf1-72462f1bef5@google.com> References: <29f48045-2cb5-7db-ecf1-72462f1bef5@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1413; i=brauner@kernel.org; h=from:subject:message-id; bh=Mh1E9gZiK9ycp6tqPpBjwMzV6kf5/hBORiwfZeKUams=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaScOVqoHGkt6OWyWHlniNOrmtVBiXfclUM7j04LYN5/pkg7 a19XRykLgxgXg6yYIotDu0m43HKeis1GmRowc1iZQIYwcHEKwETmb2RkmLWC/Xnx/xpji5Kqbal7Tb /Y8b41Xr+3dMrcrVOvd9jPqWBkeKyurnk8++rf8y4XFq1cJSLYbnj3RrDiVH3Vx6E3iy+e5gEA X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E8D67140010 X-Stat-Signature: yrdueo13nn3zhfzes138ae8kk791zspa X-Rspam-User: X-HE-Tag: 1691141501-382491 X-HE-Meta: U2FsdGVkX1/QEA86iZa4R6DWBXZgv5u7vF7Nz/nsIETLuBpC20OWKlboOWL5I+WN/Je5/2at4iw5cw8QuZU8jvPLts71CMvMTKnwbqqIke+RGpBxkl0MCcHj3rlMT7BVpS15KkAUlreWc1qD0Z+Ev+lFmxQSPKPcAWXQGt5glBbKk6Xtb1PWy7AIkPZRSFFIuwoKIBOZNkmWkW/RiWOgOqZh7dNP7Ji5JaFSQEldl4luqNfaL8NB5BjCrLBO1N8sskvcaegDKoh3+P+2225qiJEezsmHA7hDTRcUwtWocwT8wrLmbk08q3pKMyAQTgpT/OualMJ03wKasjKtrE74j5vwiDvFAnhq3PwYvyfLERfIVi5hklycJOAegaM45bVIqgrK0jHYTvrsgAhRUWwUDMRuIJF/ix/ag7qw6XOIFjEpAm7sPDyC0cytYZ1MRlawjUBjUPrxI1rsECyLNH4pqhKxUymeOgNZ8tsNcbtbW4RgpQKvJFqY3r+/0vQuV/IbF3tFfKSgfxVEgqisKm9CMFMv7zDYvk51Gc97aAm1HQGyzjhlwgJzlxdLxSSPtpwgGVsQkuy30ZAx5ii7nFWmfrOnSGQ1OhTm8VtWS+NDfw5veh6Dyr+dsgjWuDHJhtOz2ErIBrs2GY/NA3hg0gEuBQFCFS66iyml9DEe+74P49zpjrYwRMUNVi3OsXqhIWdQbaEEDKwwR2sXacVOmRcmOclQa2BM1pVbdhorc3GditJexmftO1I7nF1plh24rLHLM/Qz0UBVzj4YBeZPmqXpNsR2QZaJeYnoFqi9+C3sQM0oDeZ1KusJ+iVdARvUeWEqGcXHTeEykEZ+HAdQY4l+nMzsL0ijmCe2N0Ys6tlDWCyuk2qtTkprgw4vN5jiXmCailYg2QtRdiG6KcvtuAel+ZYmex5SF4MXhoaOYhL9sxSWQIFAGzP+OaqbvI3HSbXWDFuW7Y8f37DUEtGnguJ JUK1DjQX J3L/5JGKa/Y+vfly9fAc7WKW0yS/ZNHp4TRqc52OQS0pzubhONn/jZFoClCZPEwrYlMSt0zVD7yIc2xktKSUCxcncnKlLzw5x7Cx3sIbTg5/3Gpez1wwemTgRg+BmMnKL+iAdqpKlflv2CV/zyhdozyI+OHLaNEL2csjRlsedZ5orcNtq176M3z3C+3KmZylznSu7S2k5+bC4NJk1ICmeSPajtAO5pv5t03hEHuumeKLv7WeeI774wwhj7jPFSvOiABsLAWYqE7vorfetuJ6c+PKRCc80rRRi4fb5Db7+UE7xA/J/yvvwB5YeeJkEyYEfDql12jSqjqw05iECN9zOhYRGIDbaYhMkyRDw3KDFeioBKv8FOFAz7+vlGPtxr0GdYBtyFXJcoLLdOw4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 03 Aug 2023 22:46:11 -0700, Hugh Dickins wrote: > Commit "shmem: fix quota lock nesting in huge hole handling" was not so > good: Smatch caught shmem_recalc_inode()'s shmem_inode_unacct_blocks() > descending into quota_send_warning(): where blocking GFP_NOFS is used, > yet shmem_recalc_inode() is called holding the shmem inode's info->lock. > > Yes, both __dquot_alloc_space() and __dquot_free_space() are commented > "This operation can block, but only after everything is updated" - when > calling flush_warnings() at the end - both its print_warning() and its > quota_send_warning() may block. > > [...] Applied to the vfs.tmpfs branch of the vfs/vfs.git tree. Patches in the vfs.tmpfs branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.tmpfs [1/1] shmem: move spinlock into shmem_recalc_inode() to fix quota support https://git.kernel.org/vfs/vfs/c/f384c361c99e