From: Christian Brauner <brauner@kernel.org>
To: Hugh Dickins <hughd@google.com>
Cc: Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Carlos Maiolino <cem@kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH vfs.tmpfs] shmem: move spinlock into shmem_recalc_inode() to fix quota support
Date: Fri, 4 Aug 2023 11:31:33 +0200 [thread overview]
Message-ID: <20230804-legalisieren-neukonzeption-97314400abbd@brauner> (raw)
In-Reply-To: <29f48045-2cb5-7db-ecf1-72462f1bef5@google.com>
On Thu, 03 Aug 2023 22:46:11 -0700, Hugh Dickins wrote:
> Commit "shmem: fix quota lock nesting in huge hole handling" was not so
> good: Smatch caught shmem_recalc_inode()'s shmem_inode_unacct_blocks()
> descending into quota_send_warning(): where blocking GFP_NOFS is used,
> yet shmem_recalc_inode() is called holding the shmem inode's info->lock.
>
> Yes, both __dquot_alloc_space() and __dquot_free_space() are commented
> "This operation can block, but only after everything is updated" - when
> calling flush_warnings() at the end - both its print_warning() and its
> quota_send_warning() may block.
>
> [...]
Applied to the vfs.tmpfs branch of the vfs/vfs.git tree.
Patches in the vfs.tmpfs branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.tmpfs
[1/1] shmem: move spinlock into shmem_recalc_inode() to fix quota support
https://git.kernel.org/vfs/vfs/c/f384c361c99e
next prev parent reply other threads:[~2023-08-04 9:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 5:46 Hugh Dickins
2023-08-04 9:31 ` Christian Brauner [this message]
2023-08-07 9:32 ` Carlos Maiolino
2023-08-07 9:34 ` Christian Brauner
2023-08-07 9:20 ` Jan Kara
2023-08-07 9:34 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230804-legalisieren-neukonzeption-97314400abbd@brauner \
--to=brauner@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cem@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox