From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC3AEEB64DD for ; Thu, 3 Aug 2023 16:09:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1971028027A; Thu, 3 Aug 2023 12:09:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 145AA28022C; Thu, 3 Aug 2023 12:09:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00CEB28027A; Thu, 3 Aug 2023 12:09:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E182C28022C for ; Thu, 3 Aug 2023 12:09:46 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 84119807A3 for ; Thu, 3 Aug 2023 16:09:46 +0000 (UTC) X-FDA: 81083279172.04.53ED46B Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by imf24.hostedemail.com (Postfix) with ESMTP id 27CA2180026 for ; Thu, 3 Aug 2023 16:08:31 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=nwBfuP1E; spf=pass (imf24.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.178 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691078912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+XToHAF3Tp6ttDMOwj4eUjXmrH43hQkGliAE52bu3OI=; b=a2zbReeqafDonFIfgnA21dDOrAr2zjkVOf1NMJRl9AUFD7gLX5B3QRgGK8b8HfGQXTy7WX mW3VHC+lkkfJ1mvYjjwNZW/ElPlTk1TcEdKmAjZrj8hOuPxjwOsW4M2DlS5tcPL9KH6U2d ict28C+nqxwRtKQOxPdsU0scbfFTU+c= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=nwBfuP1E; spf=pass (imf24.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.178 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691078912; a=rsa-sha256; cv=none; b=U1jSKAbigvPPrlHKJhHKxfM1GXGOMxtreHo7+CSMXE/5p4+34HjTlPAhKEbL/nXXakXsxF yzctdPIrZPhI0hI2usTyRHVzH5WQ26ZyTHOJGQsJvtDMJMxBgIJ2rdJQfznsfYhub3iu5r xcrtGz1yqGXSWyQ1m39pc1TDpO8b4V4= Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-7679ea01e16so83699685a.2 for ; Thu, 03 Aug 2023 09:08:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1691078909; x=1691683709; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+XToHAF3Tp6ttDMOwj4eUjXmrH43hQkGliAE52bu3OI=; b=nwBfuP1EF89+aISDQLUPsPs557pMHRTYHh/moPt/GEUf3VZSegFJN2WLjwtOxNaeVr tELhzCnpQiVVzn/p9TxTM40ypLAI9Wl8Dm00Ma0u6gCG9cYdJZyEwo/8Du3Xb48kiI3S aj+mMtHg5P4dd9nwwPCbs602BbZueBi9x/ZXCX+ClObKOCBNOJ2QGS2u1cys65T6jh4F sdy7Pm6FD7EqT02Lj5dytAzyu/Lm8M/yCK7CYer/QhZjZ1QXAsA3k1m/WtIhfHYpfDaQ JTwBdRXqxtir8UKBvShgRNW5OjaHl24g01HNtAzPqjO+63i2Pwtjedb13yOisZI7uZQ1 KP1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691078909; x=1691683709; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+XToHAF3Tp6ttDMOwj4eUjXmrH43hQkGliAE52bu3OI=; b=dtpxD5vJK1xf9O1XxlSUxpX3koaj2LV0yT6uONtxwSoH+b8Fk6vAKCCTlHk+NpD6ql 7CvuR2dysR83CHhAt8ejopJticn8umTjrOKw82Y83fTK0pwF7LJyhKMcjR2DXwB7ceKz WHpRLoRAjlVSZ8RoVQMdp6DPTIgPiJLYSwDng0kzqTHVNm93bQ8KC/968KXQAmGuhG74 Rjjkcd10F1St2IIUpJxjcRTKqMZ/kFinOSbQGk8UrLkpPb/MJ6B5NX93aN7Uqx/vVnt4 QsqMPP5x2hgnV8WnLQ+6z+7dXcyl35pfCqbhTByaf/1AZbg/glc1abtvPKTmIoonrDqr h6bA== X-Gm-Message-State: ABy/qLavJwn0Y+Bw+q7ue007MmvTcyC/Fs3kIj4Wj6wHeuy3alkRPuqg s2Jm2Vm3BZlVo+Fz+xASH3xr/Q== X-Google-Smtp-Source: APBJJlE/HITWbFDhpZ/D5lR41JynAMCPkaudsb/XHWlqv+SykPhRMLbLhtMkySOs7sEOxK1mOiRSuw== X-Received: by 2002:a37:5a05:0:b0:767:2471:c880 with SMTP id o5-20020a375a05000000b007672471c880mr18403599qkb.28.1691078909290; Thu, 03 Aug 2023 09:08:29 -0700 (PDT) Received: from localhost ([2620:10d:c091:400::5:9910]) by smtp.gmail.com with ESMTPSA id g16-20020ae9e110000000b0076cb0ed2d7asm14050qkm.24.2023.08.03.09.08.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 09:08:29 -0700 (PDT) Date: Thu, 3 Aug 2023 12:08:28 -0400 From: Johannes Weiner To: Lucas Karpinski Cc: Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Tejun Heo , Zefan Li , Shuah Khan , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] selftests: cgroup: fix test_kmem_basic slab1 check Message-ID: <20230803160828.GA223746@cmpxchg.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 27CA2180026 X-Rspam-User: X-Stat-Signature: p98hdcrrfxc3brdrgmtf4cskd5hriyub X-Rspamd-Server: rspam01 X-HE-Tag: 1691078911-816681 X-HE-Meta: U2FsdGVkX18dUuio17nmqVV/ewNJmsi8pBraZuqFe8MdZkQIHCDlQnJ7nJNs1cAfKIpbTzSSczFYB9cjloJ1aUtRJcH4L07Tf/8z9nMdDrl8gcpDHkOF5nYHrww5sogNUQSLkbnwA25i5NaLzGPdlWZOTcfN2U1B3r7HUBPleCzajgY17Hyv9YBMWu3cvpRDUCqPhHwrwoUViq44ynJ+IPI720cAFBZ/b/7ECzQMV0OUsP6aXE3IUSyLLqtgcPnTCFzi9nv+HpAMeeyQ7oh9/8rAHxSVw0A9j4u0+Lu4E3k6n2ZI3rHWwcJZyyAw7josjAHqxAtrRtoVpdefv/tt8oOHy82zbRdOWyg2RrF1Gl6OyPrENm7GVgaEMb/V8lGgi/scY5FI2b8gcxGRDVmoSuLIviS5MqIfdBC1tQ5vk51iRzwDUhSd2r+e5YaoSlZGBqmatHjJC6PNqUI5yaEHnFt34U75WEHZE3JDNfD77zQurjwSObc0KVP/ECHd0f99694AVGo+dHDeINBgsyK2xQtA7u9GFKktXZPWZg3eY2QjIrAZN0YW9PhuW/OOSuvrfcIyfZlY50enD3nNsdjGR8XQ67UyS18kANxWJSiiPNf/FYVwqekyiU2oO5pi43B1huq+FMRfIdEoOnLvvz1irJYXPmnf+hOZVMuN7uti9zTtg+Qpaa01S0J6+DsXNS5zqyTLvwSJKe7FyFfWVWpVM+SxRlu7/NXo3Kc5uUwqjjtmkFBQ1rsJ2IhMnCl7Kij8wdy244WjVj8UuB6+C0GFKIi23voGkRlNA9NjgglSuDUEAY+TK34yLM6i6Jcm5ABK4oIbAbi5/IeC9sfSFMTL9uJ5RyLQ9FCPVQaZxyLjS3o/ZQqY5TvMMTN91hd0sG+YhG/D5gMEAJXcyMDhjv+VkxDzwx2N4y59asG1MXReRcB0bGSFMuywuSlneiLUAQrlzI0AfCjl3zMcqArfy8e LIoNjJgd pRa2z0gHe3nSmxWHpLIeSoJgTHnpQiZf70WHemI0VfFjKNbQXV8L1pW6zwFGOED9Md8TRpjXVfai29GxAFLDm3nJLEQP4TbQW0mFbM5sQsIf6BohUOaAEYQSXDzIGtsaIiFTBBIRXRIOjbHnVT0+PIr/2RzIXbHERxWpewt6WJSfrgkhYMooPKxUV5HJEOi11docAazfAYpm1HGdt6yXw4atf4jkhwQupkVLfx21dA8GS7HaJ/V0XBw5IpCrq4SdxySdHjcnOg04dJoOxvhayiwgtHqwCDM7fKiGgkv/dVIsEnYLBWcfB6mXIKxfKwo1uyzgskz1osTYcGBTUIKuepCIG5phbXDlVxoWEm20rM+u0kM/EM7KCNl1/OO/BMZzjaRsghos6LbzMoRsP7kkvOWcJr4jMkNM/sE8eBBEvP8Lh+Pg1tojo13obJ/QepzZbXlDJESeGdKztUmNsodp4xNetU1YVdkD/DmTbrJ6fjCtYj1g0e6ELp+1LW1SLv2QmNvPDah39CC0FA86XJFzMGYQqkau2jvX1dEXEA5NtmFhM5FL7yWajp3Dgt9DHyxhGIili/0s4nmtd89EXttqgja3NAFSJK1ESN2/APdO7m2HaDtVd1QJXxfTuQMtkYqRyg6yHldSSMaE1Is+Y9BWMGckxsU/l80ofatSZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 03, 2023 at 12:00:47PM -0400, Lucas Karpinski wrote: > test_kmem_basic creates 100,000 negative dentries, with each one mapping > to a slab object. After memory.high is set, these are reclaimed through > the shrink_slab function call which reclaims all 100,000 entries. The > test passes the majority of the time because when slab1 is calculated, > it is often above 0, however, 0 is also an acceptable value. > > Signed-off-by: Lucas Karpinski Acked-by: Johannes Weiner > @@ -71,7 +71,7 @@ static int test_kmem_basic(const char *root) > > cg_write(cg, "memory.high", "1M"); > slab1 = cg_read_key_long(cg, "memory.stat", "slab "); > - if (slab1 <= 0) > + if (slab1 < 0) > goto cleanup; This conflicts with a recent patch already queued up in -mm: selftests: cgroup: fix test_kmem_basic false positives which adds a sleep(1) between cg_write() and cg_read_key_long(). Can you please rebase on top of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable and re-send the patch with To: Andrew Morton ? Thanks