From: Johannes Weiner <hannes@cmpxchg.org>
To: Lucas Karpinski <lkarpins@redhat.com>
Cc: Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeelb@google.com>,
Muchun Song <muchun.song@linux.dev>, Tejun Heo <tj@kernel.org>,
Zefan Li <lizefan.x@bytedance.com>, Shuah Khan <shuah@kernel.org>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] selftests: cgroup: fix test_kmem_basic slab1 check
Date: Thu, 3 Aug 2023 12:08:28 -0400 [thread overview]
Message-ID: <20230803160828.GA223746@cmpxchg.org> (raw)
In-Reply-To: <ix6vzgjqay2x7bskle7pypoint4nj66fwq7odvd5hektatvp2l@kukoifnfj3dr>
On Thu, Aug 03, 2023 at 12:00:47PM -0400, Lucas Karpinski wrote:
> test_kmem_basic creates 100,000 negative dentries, with each one mapping
> to a slab object. After memory.high is set, these are reclaimed through
> the shrink_slab function call which reclaims all 100,000 entries. The
> test passes the majority of the time because when slab1 is calculated,
> it is often above 0, however, 0 is also an acceptable value.
>
> Signed-off-by: Lucas Karpinski <lkarpins@redhat.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> @@ -71,7 +71,7 @@ static int test_kmem_basic(const char *root)
>
> cg_write(cg, "memory.high", "1M");
> slab1 = cg_read_key_long(cg, "memory.stat", "slab ");
> - if (slab1 <= 0)
> + if (slab1 < 0)
> goto cleanup;
This conflicts with a recent patch already queued up in -mm:
selftests: cgroup: fix test_kmem_basic false positives
which adds a sleep(1) between cg_write() and cg_read_key_long().
Can you please rebase on top of
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable
and re-send the patch with
To: Andrew Morton <akpm@linux-foundation.org>
? Thanks
prev parent reply other threads:[~2023-08-03 16:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 16:00 Lucas Karpinski
2023-08-03 16:08 ` Johannes Weiner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230803160828.GA223746@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=lkarpins@redhat.com \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox