From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE9B3EB64DD for ; Thu, 3 Aug 2023 13:34:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F705280259; Thu, 3 Aug 2023 09:34:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A72328022C; Thu, 3 Aug 2023 09:34:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46F1A280259; Thu, 3 Aug 2023 09:34:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 37DDF28022C for ; Thu, 3 Aug 2023 09:34:35 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EF15540208 for ; Thu, 3 Aug 2023 13:34:34 +0000 (UTC) X-FDA: 81082888068.18.5575F72 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 4883240019 for ; Thu, 3 Aug 2023 13:34:33 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="kPNtGO/G"; spf=pass (imf04.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691069673; a=rsa-sha256; cv=none; b=4DEA20KlLHMbk7lbPVw/ndzB+4k19+M85tkXJ5YZv1EKpir03XblwTkrNhrpXdL/G+GIK2 7L6LeJs0SvCMhqRHWHWSpJci8uNwvlqwB/d+dPytUzhnps6vBtZE9NIQAUdH9vEDGU8cuZ uoHmjEztPA9fO78u7IkyvYwA8ccBbTM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="kPNtGO/G"; spf=pass (imf04.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691069673; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Otp5c34Au/A+61OjsXZHmSy0BokXp4bx9bTkheladwY=; b=oOOVGyJCS+0rztUGHqo2e1danHaxV/ErZK8/AIGwBwvBXD4rYkiMunjfoOJX2DS1ebMprg jL2ezX+n19LM90wztMxchvXeKMv75wTZaV5MgfJ6s8v3b3Xuf+OpE0qGPNOCmkeKAm8kr2 cI//efkFe8xhZLjk/WbaESSrLWLsoMQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3B9FC61DB5; Thu, 3 Aug 2023 13:34:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE3F5C433C7; Thu, 3 Aug 2023 13:34:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691069671; bh=dy2GYZR2b61H37bLEusad9qBv/xyGvAOvToaUiJ8fPU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kPNtGO/G/KDpCholqvr3N0nX4pD8T/WItCJQqZC2kMIwLCDa/Hi06gwXkIVNrxnQ0 crjMIH/Z7xnSpWIPYms1nKzwaQYfuuEFdOtQy5qXs2DCbX+SIjwIkcL1Cys8Zuq8zi u0izyAnIBeM2dpxct27jWPzW0Npdu5qzO122h4iP38Z8dAlU6/6xu85mjaPFHA3tUE OxrxV9n4+SxohnOTlvAjMAzEEqU3wrJ2+ehFCJ1yNVujMxFJ2281TVAinPYoJFspjV VYpprauA7rG0iPYmChb0u2/1iSBQ7Uc60Ick8sbs0yZ3XuFq0Ygp4hN3fH+O8O8PxN 0iG4WBlkbMRow== Date: Thu, 3 Aug 2023 16:33:46 +0300 From: Mike Rapoport To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mm_init: use helper macro BITS_PER_LONG Message-ID: <20230803133346.GH2607694@kernel.org> References: <20230803114051.637709-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230803114051.637709-1-linmiaohe@huawei.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4883240019 X-Stat-Signature: ywzubxbrwswmnn8piwa5pbqn7rzetnhp X-Rspam-User: X-HE-Tag: 1691069673-780149 X-HE-Meta: U2FsdGVkX19nO4PuVFtXgybGFVcnz8XYiX8QU5FWOvoDfI5qMwpYbD6TIrYYPHydaMWlS2BK2YEcjX7Uj/1S//8liNe0z61XdxBrUQ7zeSueru73bMT1ItYvhhlNEMffv75pspPl3BebvfagKlMeIvKghjmLr8Wsyjt9AkVPiSBYY+nm6NWdgFb2DQElyNTqqYmYXuR0v35pLls2lL2YNxmHwKHsnoBhUHWpMMUwOheo1w+ubH5NkniIUwOAHdAT/XMm/rRXDeyuxsZOXATW/6WgFepJa0CaHzrJXI7H4QhmGD+X4NwNmh/OBTR9AVeCsBbkmSs0NH903lqIQymTcirerY5gEIYnWXyHmIPbTVzf4EOYRQl2/uyWUDjtLVAQn/aicu6feQa74+NRgALYiPxynq1kEXfQ4a680Xq/MQRvf1isjobon5hbM5Rw83hIv0XMK+xGZq74cafGShLstO5eYKEzqxPRePQtSpbl8LTUnPx5A3Pvyn+NBcjh3leeTs5UH/JgKrtXxHLr3BURMq0nUNWKTxRRD8X6KSua0ouOnA3Qus/Y2cLxs6A4K9BmAjCuM9hYjxT5OmRH+tpUFdyuTa7HIgBj9+duaLtWggqJ37DUg7AEnEh8cSlF1XuD2ebQmze+X1DdbD2P8OhJh5VWXDwUe/4Sn7UcXOpRFJHlkM4Qf5HncG4bp4Ok74a2zP7xa0xfF5Qi90uS83Wq+pu8n5jN6py3aTyojGHp2Rwzd68ZrJNUalun+GuKxuBIgCeMYE6QRXAJC1tCeQNr0TQX1CqXy1bM9ST0piJCOddIA2m0Vb+i0q/Z9c9nFPDp6cjEo0/Ra9d1yJ4iT7z/aHoIzNNigALWxXwDeSdMPYVrCdP8OqFXXRiEopJpKCoxJFn0G3bvnI+aBuPSyiI1PlJxAbeSC8FpC0FcU6XzIrBBcZSAVdU9YSsc6UjyWPt0n7HNwma3PIACMv7Z0EU MX3EjUN9 Lc6tMND5BXUmlyYu24OsbVAVBpgriMZQfwsLi2OsLmpXHozcBGbdGyjMd93C8ZwBF6flLq056gLo/xwF7FIYImrIjFczVAYnGOZPmiRVa1BeU++4+8AVvghh2DXTgj4cOBgztro3UK2PnVqogli4HnyuZL4wMr2C/yV6O7gVxHma8Brp9nKp66LHHLCMKnLsEzHfCjIaNdS5goNHlbNmktbtPSnVaXXRljLcyHpSUaoW8gpHjvNJQRvoSYmHq8YqdBlyYn9GGYYgMyqw3beNVHr+4CRFD8gkgFVYP9UcjtrvR+hpqzfJmBpNl4pm6kvfQeJwBUq+6w5xgR4veW0Ll0JDnb9du2ZpvL5+DGuHoGSZBRmA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 03, 2023 at 07:40:51PM +0800, Miaohe Lin wrote: > It's more readable to use helper macro BITS_PER_LONG. No functional > change intended. > > Signed-off-by: Miaohe Lin > --- > mm/mm_init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 66aca3f6accd..2f37dbb5ff9a 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -79,7 +79,7 @@ void __init mminit_verify_pageflags_layout(void) > int shift, width; > unsigned long or_mask, add_mask; > > - shift = 8 * sizeof(unsigned long); > + shift = BITS_PER_LONG; > width = shift - SECTIONS_WIDTH - NODES_WIDTH - ZONES_WIDTH > - LAST_CPUPID_SHIFT - KASAN_TAG_WIDTH - LRU_GEN_WIDTH - LRU_REFS_WIDTH; > mminit_dprintk(MMINIT_TRACE, "pageflags_layout_widths", > @@ -1431,7 +1431,7 @@ static unsigned long __init usemap_size(unsigned long zone_start_pfn, unsigned l > usemapsize = roundup(zonesize, pageblock_nr_pages); > usemapsize = usemapsize >> pageblock_order; > usemapsize *= NR_PAGEBLOCK_BITS; > - usemapsize = roundup(usemapsize, 8 * sizeof(unsigned long)); > + usemapsize = roundup(usemapsize, BITS_PER_LONG); > > return usemapsize / 8; BITS_PER_BYTE instead of 8 here? > } -- Sincerely yours, Mike.