From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D591CC04A6A for ; Thu, 3 Aug 2023 10:19:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A8B328022D; Thu, 3 Aug 2023 06:19:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1553028022C; Thu, 3 Aug 2023 06:19:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F399328022D; Thu, 3 Aug 2023 06:19:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D70502801EB for ; Thu, 3 Aug 2023 06:19:17 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B29E41A109D for ; Thu, 3 Aug 2023 10:19:17 +0000 (UTC) X-FDA: 81082395954.28.E4164D7 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf17.hostedemail.com (Postfix) with ESMTP id 0814D40011 for ; Thu, 3 Aug 2023 10:19:14 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=none; spf=none (imf17.hostedemail.com: domain of thunder.leizhen@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=thunder.leizhen@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691057955; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=ZoWetTvd2uES20v+6GvpE2bcg7uvaQqPOX/fZrBZzSM=; b=xwLytRFoHUyHNEYAkuLhDDyYsOaOmp/BsSQhskeDOXCajRtAb5nUtjN0E+o3EsaOToWmfh S+7ciQ0g9zdVkJdLBTaPRXqDwpu2pxmmse08PZl2JtCiYnyuyz6J+kHHMQp+8EAfUxQM8w 9FrBqXy7eKR9L20vnp5Ww5A5Nq4GJAg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=none; spf=none (imf17.hostedemail.com: domain of thunder.leizhen@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=thunder.leizhen@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691057955; a=rsa-sha256; cv=none; b=exAxNS87te6GRKCxMG5HGchnGTWtXD3jY0DRmQ3MDx0YiSZAGFAW+ZV0f+F1bNizsJTFsO b6yA3t59A4CqQLtH1Avo4Tr1XnKellXmBL3IUw8ErjghteOozICD0MGz2Fg7g2KiJKF7yS BQX3IOw8ID+I8KfP77XD0t+v6cFJPvM= Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RGlF56VSyz4f3pBX for ; Thu, 3 Aug 2023 18:19:05 +0800 (CST) Received: from huaweicloud.com (unknown [10.174.178.55]) by APP4 (Coremail) with SMTP id gCh0CgD3mp4Uf8tk4+TaPQ--.35755S4; Thu, 03 Aug 2023 18:19:04 +0800 (CST) From: thunder.leizhen@huaweicloud.com To: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, "Paul E . McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , rcu@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Zhen Lei Subject: [PATCH v5 0/3] rcu: Dump memory object info if callback function is invalid Date: Thu, 3 Aug 2023 18:17:51 +0800 Message-Id: <20230803101754.1149-1-thunder.leizhen@huaweicloud.com> X-Mailer: git-send-email 2.37.3.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:gCh0CgD3mp4Uf8tk4+TaPQ--.35755S4 X-Coremail-Antispam: 1UD129KBjvJXoW7ZFWfuw1Utr4rArykAr43KFg_yoW8WrWUpw nxW3sxWry5Ary3CF13ZF1IkrW5Ga18JFsIk3ZxZw18u3Wjvr97uFykJr1IqF9xGF93KF1U ta1YkF1jkw45ArDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvYb4IE77IF4wAFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6r1S6rWUM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7M4kE6xkI j40Ew7xC0wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F4 0E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_GFv_Wryl IxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxV AFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6rWUJVWrZr1UMIIF0xvEx4A2jsIE14v2 6r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07 UKfO7UUUUU= X-CM-SenderInfo: hwkx0vthuozvpl2kv046kxt4xhlfz01xgou0bp/ X-CFilter-Loop: Reflected X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0814D40011 X-Stat-Signature: 36e96on4pzk6u39gxmcn9p1emcmq3cbr X-Rspam-User: X-HE-Tag: 1691057954-458115 X-HE-Meta: U2FsdGVkX19sD/b42j/4O1TUTdzE/pIIRuBN0WOdrv1wdmwMar+WqsSRvY1sn/3uBwX6s9E+ToEWLlh/9n5dIw0cNS1BBCOqYIIZWSzqfxhKeKFgh+ysGsUu4R+8swowmw9LgrEjKeo078ttt+itq55dqtXuHOTmDIT+5KkGy8+MXaQHolnZCMkQGnVYi+jJ5xa4elOu4+EpTdDunYPSx1zWByIwZS21NCbSgiNNFc6TBsSrx269fsrpk/qMWuiA0r8ppuCzTsJiaxkG9Rq2USXSWrOIu5IrpnwLGkCSx5J0eUpmLrDJLfNegJ3m6j2Yu6O5BL5DdUwdRtB2L3PiyxqCMSvopKklGAKcx6v3V2ivNKcJc1PxTxqstA7GhgVtwGUkm4zSvOTBdK7L+A4VV7+aXQridQ5l5tzy3tpUfymo/bAd5nZite3MqHBfzxyR71U2O6UkcC8yNY1D7jIz3l90sPfygWhgGiD0HRlMliF5Pz36feeJgRUi7T+so714MZ3/iKbcYrOMJRtFLWLQuNWixqdIpPIeVlMutC7JeJwBgBDvR4A04+CDp06KbNDBWwyL9sd9mK7UOfHo7lxNFWSW4WlxYwFV4DHtCdI8lOE8njmpgq498GM2ems/emcsnIeZIYS5zfkHW5TLxaF3UlNbXNWcuGLU2u5pKG/LLeHmcr270MYa87sVGbfyGkQUyIA1DSJtJw/qj7YTH+wzzJLtu8okmAQbTVS1/X/Nm+MpZ9lJYxRWZnAlnUjzgizib5p2opeEm/cre5AVgJ9ilJ6fBP+TBaIKT68q4R0lnDhfB1S4DhFQNeCRhuBYOy0xKF3aZ5wqDBolIMyECkI0xoFYFmooEMYPNaPBjw5pdtuREKmWpKYS+sAxLvdNxjjs+0i49BQjaTodqre8DJpdnNC3Bpg4yjoI7dXAEoZCmsLqqdmWaeItUSOYXnoIvMNBWLWFZmvAkQl++bEHDVK fJ8YkYzJ 5UhzPPExF+6b/rm6GrXmcY56yAgJ2vleguDrht0CD+73xAtkVy5J6I1z7qha2F1mk/AyffDI5vSt3d1y+5JQi37aNOTJF0GvH1NpTZFSXQxXN170OaaXg+PBBYF0xsyu586cjcUFwQ+AAPB2otP2n0TB5ImpS+wQfP55F8Xqi7T0dDG2mw58vI+ZlEVZ+yMVZFakaElUi1Dv19VTy04qFoHQPdE+El8ZP410Fk6a4gc4jDhqx0NYhwdq9weIElWAENo6tIfE6saU9/Mar6Tz5h8TOllYTLb180ORjjggCCnBxzELFVlK8VDWbpV121Y5PuFnRD3GEvQ5KY70= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Zhen Lei v4 --> v5: 1. Add Reviewed-by Acked-by for patch 1/3 2. Add patch 3/3: mm: Dump the memory of slab object in kmem_dump_obj() v3 --> v4: 1. Remove kmem_valid_obj() and convert kmem_dump_obj() to work the same way as vmalloc_dump_obj(). 2. In kernel/rcu/rcu.h -#include +#include v2 --> v3: 1. I made statistics about the source of 'rhp'. kmem_valid_obj() accounts for more than 97.5%, and vmalloc accounts for less than 1%. So change call mem_dump_obj() to call kmem_dump_obj() can meet debugging requirements and avoid the potential deadlock risk of vmalloc_dump_obj(). - mem_dump_obj(rhp); + if (kmem_valid_obj(rhp)) + kmem_dump_obj(rhp); The discussion about vmap_area_lock deadlock in v2: https://lkml.org/lkml/2022/11/11/493 2. Provide static inline empty functions for kmem_valid_obj() and kmem_dump_obj() when CONFIG_PRINTK=n. v1 --> v2: 1. Remove condition "(unsigned long)rhp->func & 0x3", it have problems on x86. 2. Paul E. McKenney helped me update the commit message, thanks. Zhen Lei (3): mm: Remove kmem_valid_obj() rcu: Dump memory object info if callback function is invalid mm: Dump the memory of slab object in kmem_dump_obj() include/linux/slab.h | 5 +-- kernel/rcu/rcu.h | 7 +++++ kernel/rcu/srcutiny.c | 1 + kernel/rcu/srcutree.c | 1 + kernel/rcu/tasks.h | 1 + kernel/rcu/tiny.c | 1 + kernel/rcu/tree.c | 1 + mm/slab_common.c | 71 +++++++++++++++++++++++-------------------- mm/util.c | 4 +-- 9 files changed, 54 insertions(+), 38 deletions(-) -- 2.34.1