From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FE13C41513 for ; Thu, 3 Aug 2023 02:26:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BC89280208; Wed, 2 Aug 2023 22:26:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26C9E2801EB; Wed, 2 Aug 2023 22:26:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13571280208; Wed, 2 Aug 2023 22:26:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0327F2801EB for ; Wed, 2 Aug 2023 22:26:06 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A9422A05E7 for ; Thu, 3 Aug 2023 02:26:05 +0000 (UTC) X-FDA: 81081203490.24.367B104 Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) by imf27.hostedemail.com (Postfix) with ESMTP id C946F40006 for ; Thu, 3 Aug 2023 02:26:02 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=cyphar.com header.s=MBO0001 header.b=Y1QMaVE0; dmarc=pass (policy=reject) header.from=cyphar.com; spf=pass (imf27.hostedemail.com: domain of cyphar@cyphar.com designates 80.241.56.152 as permitted sender) smtp.mailfrom=cyphar@cyphar.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691029563; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QDaQQq8N3pV/0zOSm0S8Jmeu7eQz2E5FW0Ju7kYcogY=; b=wmTl8OlATB5eUCLEOCd4Q+qR1oo4CgaxBDKuGVKYWsN/QIxX9cBjrIqbKPlbYSm5gu4/kl 1yxbmNGSEdRVeWCk917Qsny0KelNQUScyb9RohoWKQtcYU2pHkrzsGyMg508y+mm66ly2a UzVCQjBNLf84Jx06ePGoHvpbVitZqWo= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=cyphar.com header.s=MBO0001 header.b=Y1QMaVE0; dmarc=pass (policy=reject) header.from=cyphar.com; spf=pass (imf27.hostedemail.com: domain of cyphar@cyphar.com designates 80.241.56.152 as permitted sender) smtp.mailfrom=cyphar@cyphar.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691029563; a=rsa-sha256; cv=none; b=LPhdltPCmEHgx27pB2MLyRClDS6uZPslnvqW52+Ntrb8M5xIsquocy3XmKlsAVu9IeUebX DI4JB6wHzrNkuq96rbL+5PRTTmlzUTVC4Ma4gqbBvpIySQ2FQmv82XQgFdk8R0BjY0xfQA hRJg7hOyEeUIdWSyf2VBs3NvlzVrbS8= Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4RGXl92DZNz9sSv; Thu, 3 Aug 2023 04:25:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cyphar.com; s=MBO0001; t=1691029557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QDaQQq8N3pV/0zOSm0S8Jmeu7eQz2E5FW0Ju7kYcogY=; b=Y1QMaVE0KtysYE+lwk1MnyWvrQxXJS9qbQlv2SuhvCeiQhrJnugZ6PyoP5TdBjHVlcHA6W 61Z7A2b1SDPlD6gmsQsoVh91sHohyYVSGA5TZzJDK/nOlqlfcbPORdD0H9pCU8B35nG2WA Yv4yh7KeNg7PI59PogMuBQvzEGr/M7xCPzPM6t8yBxr3nKcnRIShRimmUiAbhNgukDtjkH 92zM38Uv9/yEiWW+aEpxEHex3y3BnhkcH4qsf65XwM0y6Mu/2fwRPGa63Dzox9sZKLyo6V LFZjG+/BfNweZpbLMGAt61Fl8isAN0qJHseIuhGyUKmmJOsKqBiC9nNnHTD1qA== Date: Thu, 3 Aug 2023 12:25:42 +1000 From: Aleksa Sarai To: Jeff Xu Cc: Shuah Khan , Andrew Morton , Daniel Verkamp , Kees Cook , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 3/3] selftests: memfd: error out test process when child test fails Message-ID: <20230803.022458-mundane.voyage.tricky.kinship-yaSxczr9O6cB@cyphar.com> References: <20230713143406.14342-1-cyphar@cyphar.com> <20230713143406.14342-4-cyphar@cyphar.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ol7adjwswqudaxv6" Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C946F40006 X-Stat-Signature: p9uezmhwt9cw5dfdwneb6is7s8uk9ceo X-Rspam-User: X-HE-Tag: 1691029562-172547 X-HE-Meta: U2FsdGVkX1+4ZJHt6GisaJkG5OyFGIwSf9yzgNkSF8xnbzZBJhFSSaECg3xEL6W/k7coyez+V5TyzfCUb7rK5wA3wVI6QUH9niqPK1d3lcvk5dguB06PiOfh9vu0pAJjF9R6jjrHe4wjeshFPldr2ngq7HXBGVpzuP7S/fKOMqJmEC2uCi3RDobcAXemkKgMtNsC5YwL2YoVKJ9eNNGRt+llxcOb1n0IrTpJfEIgq7bWkDY9bI2RVKwiMj3cPSACLijLpzbuWvW5OkNGfclBL43PSYt4Pm+iyjwUgOuqtC2tp8OSzIRwRd7EPTlTOYwnGM2Z7js+mdAl15yXoHnqbTwsl/+HIkN/+fnaWmZ2vvIrcgsrRCGvecZrnryZdSyBItbScgVY0ipc6ZwLsRyIiys2sRact6e9dUkqKxqY18c2sqor6T7rhSn0SFZ5vJDiqU/Ggvf5KOT40/v8XZrrmzyi+PsYb44zdWzRIPpHdtTDMBtfsYfhEHayIS8iJ8p791ZPoNPyunCTPCydiBr07OmZ5GfHrcujE5Uu+6quH95gaJCNlcVth0xxXJA/DKTr/z3Ia8gzVuszwdSnXwdlpq8/P2LLMxxrDiP9mFGdnJ9j7KsEjgkFQhxm9ty3PaQfq0lFMYWkdJ8ulWAxEnBmRY5RPafmsQPVlTU7TcD2739AaS2wsuLNtd1KhLoAbmXCQlfF1/lLXslflj42qp+U8N3d3GXiWnbA3PggNMGHJAXyUr+beXPLNKVfrJgr4gWiKc31fjkErEp/7klIz1E6UraahQnDX3QV/p9A6IYGNQ8tBdklED9mBkOUYjmMsJuTG1SMPJelbUzBTBx+SOZBRQgU6zD/qmebBVOsz3JnTLHdp7ogcngMF1Z04P1khefsG7U8sbo0RUOGwvPgfsyGIDhRFIPXzFNOun17y/8E/hxFPPjlUGXp9Pg6xwvrbVaJ3uNHWgJM13/aAMHoSQo 9TT4Swm4 Ht/78W8xxT6a1y1wM97sP66H0dqhM0VJtSu5Js8EWMujxmnron91uLOnhEdQ4E0JTx/EOGueV3NMBRy8Mbb+ASb0O4RxA3XxDN9uDKPOIat3K3gccVdSik7TwunqsCBASBrqohKD0Y/BaG81pAlv0DdyTy7KdYoiyORmDMKryalh+smOIINduD3z55dGvgfdYHudGGer19q+g/7SGO9tkPuSsA6NKzFs8BZhFK5RWx0+AF33h400PQbcDjk3bvhWlieolpZkhxDu69WyQFSe1vKj1uset/c+XhXhDJOUuORKwmUntZ62Ad1Sn2kYm5hcSdvLLRnhSYFyolQU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --ol7adjwswqudaxv6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2023-07-19, Jeff Xu wrote: > On Thu, Jul 13, 2023 at 7:34=E2=80=AFAM Aleksa Sarai = wrote: > > > > Before this change, a test runner using this self test would see a > > return code of 0 when the tests using a child process (namely the > > MFD_NOEXEC_SEAL and MFD_EXEC tests) failed, masking test failures. > > > > Fixes: 11f75a01448f ("selftests/memfd: add tests for MFD_NOEXEC_SEAL MF= D_EXEC") > > Signed-off-by: Aleksa Sarai > > --- > > tools/testing/selftests/memfd/memfd_test.c | 19 ++++++++++++++++++- > > 1 file changed, 18 insertions(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing= /selftests/memfd/memfd_test.c > > index d8342989c547..8b7390ad81d1 100644 > > --- a/tools/testing/selftests/memfd/memfd_test.c > > +++ b/tools/testing/selftests/memfd/memfd_test.c > > @@ -1219,7 +1219,24 @@ static pid_t spawn_newpid_thread(unsigned int fl= ags, int (*fn)(void *)) > > > > static void join_newpid_thread(pid_t pid) > > { > > - waitpid(pid, NULL, 0); > > + int wstatus; > > + > > + if (waitpid(pid, &wstatus, 0) < 0) { > > + printf("newpid thread: waitpid() failed: %m\n"); > > + abort(); > > + } > > + > > + if (WIFEXITED(wstatus) && WEXITSTATUS(wstatus) !=3D 0) { > > + printf("newpid thread: exited with non-zero error code = %d\n", > > + WEXITSTATUS(wstatus)); > > + abort(); > > + } > > + > > + if (WIFSIGNALED(wstatus)) { > > + printf("newpid thread: killed by signal %d\n", > > + WTERMSIG(wstatus)); > > + abort(); > > + } > > } > > > Signed-off-by: Jeff Xu Did you mean for this to a Reviewed-by? --=20 Aleksa Sarai Senior Software Engineer (Containers) SUSE Linux GmbH --ol7adjwswqudaxv6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQS2TklVsp+j1GPyqQYol/rSt+lEbwUCZMsQJgAKCRAol/rSt+lE b6fuAP9ki0uOZxhvg7UYVxVmtgV9baTK8Br1vb4etGtmEfZ1IwEAg8kjMvzzv+mb zmU0bhe6uOd5ZHdu5KCubvPCLtWzow0= =mmRd -----END PGP SIGNATURE----- --ol7adjwswqudaxv6--