From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9901DC00528 for ; Wed, 2 Aug 2023 21:32:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F41BC2801E8; Wed, 2 Aug 2023 17:32:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF22B2801AA; Wed, 2 Aug 2023 17:32:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6B2A2801E8; Wed, 2 Aug 2023 17:32:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C72492801AA for ; Wed, 2 Aug 2023 17:32:31 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8E146C07C0 for ; Wed, 2 Aug 2023 21:32:31 +0000 (UTC) X-FDA: 81080463702.15.B0A08B9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id A5DBC140014 for ; Wed, 2 Aug 2023 21:32:29 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mhAFKMX9; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691011949; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5nQkTjpE5JkIK0Ug+slCBTeILDePWtarDq+twvurfAs=; b=dT9svFhH1BBl0l+i3zVO020UnKdk/TIklIc6LYpr7J4UgBGr7bEZz7+8ZKegG0wwCQ4DhS qTMGlrnJEET0h3nlVaKcJWJZ33oUBnqusO98lZ5m2CH9Gaxwum/z4wqHNbhbzsqlitVEb5 9wlz4jk05QcP8nSDmbfn5OB3aHxFGD4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mhAFKMX9; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691011949; a=rsa-sha256; cv=none; b=AjIrorw7/JjjqsjX6GHbr5x2VeP1fu3QwHykxAWmQJTzYo7+Udq3cBVfN/0TAuFDKA9QdQ 6qv7GR/Bbtz9xX5hpgaO1NovGS5yTkxj6VEldJeLRppq3CEv+sqQyRT4PDdPeKjw/vhukf /HL6t/+WYS84HIUjXOGKdiO5l4PpuKk= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B66B661B40; Wed, 2 Aug 2023 21:32:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE37FC433CA; Wed, 2 Aug 2023 21:32:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691011948; bh=f9khGIJiHzKXZGP9/5olstezaDHUu4yK0qoxQ3r57d0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mhAFKMX9BWvgmnVvVuE+YKjYxd17hsK/C+pCyLC9qL+02hqk3arsp5C5P1SP7ibv0 nx029Y6xQ5WdsNc/dcokX9cPYD6v4jxXD+bLFUGTnqZU+CpAM2GL3dE0DLf/mKv2MK xyGswxMq/DERqXK7S1dRnRlV/4pRuC92wzf/UhpE21z8l69eE9aIiXl2zmZEy0MOIk uO/99Ugid4LYO9nqaSqVwud/N+jYnqajNXZnYo1XU1Tbzr1krF/BB2UH87kK4D/X/r piUAiCRGvLeCU/R+wJ6IRqufBUYXGSA2yxraYB3SelUuc8r1adX3xDSK5CBGHJtltp EpVf8hvegNgJA== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] mm/damon/sysfs-schemes: implement DAMOS tried total bytes file Date: Wed, 2 Aug 2023 21:32:17 +0000 Message-Id: <20230802213222.109841-2-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230802213222.109841-1-sj@kernel.org> References: <20230802213222.109841-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: bsenmewfzarkoz3i47e6f35czesf7zqb X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A5DBC140014 X-HE-Tag: 1691011949-636533 X-HE-Meta: U2FsdGVkX1+9JkujoeFkX4lMLKnZOpOz6cyBQLbGbNVmxqUf3YW6unRyXN0YqRPdKc7GcXxPdqx5r+t/+8pLPOp7Yo+01PwPNQldbhCHRhk/GRUB05NkXfMpcojSuieo4zPwDwsjf5myfaE+cE7yJgtc9BS5w0RR/cJOjtQgsmQVyWsh6ubaI/sfhFCKzOZfn7MgBkV11CCoY1cYmYbOGS7gVOwUZH1HvSle7Z7MWeXHUIuq2CH1okByB2r5ngxdW+2SKL63V1T1p5Kf+C0vyu0jrzgDHKHtg5NYRwEQtTAP2BQbiouHTUVpYwWbK7N4VHyRBlmZaD5t7loPWpj6p0+X6Tr6Iv3IeOFOC2hRXlidUIvhpeksKjwK9ieRcTChIKjJtL70c5Pf1087OtT9Z/DG98sk8WjmtP4m9IBwwourfb2dyyG1hQYzArLWuzQgy0MYpQxFofkaipMfacXBmAM+a0crkhbi0f9o2LQDyAy/qZtWUQpckYCpUPsCVrXoVq5BcP4ueDsqs12MGXBIZZPFwb9ya9ozWYIqSWZIjUfiguZC7ATY9n9QZwa6oxRlRcUtIGGDFMZM9v27j753MCLWcYoT2HO275zFjI6++sPSCa/vHSgx8EW1cluEmWMmebmocc9+gLfHRei3Qbs+QFMO/jk4xIycZEuRFyWgWPKjGyRKQxnUOlxO4NloacFSPMTpnM8W79qaynsFVffQYCmlACm2QdrJWx3bQcr33hp6vp28voj96Gjq0asGWbv7SQguc98U8ZFEQw5cGUW6ccucnmmrqWS2IfTqT6OPaUE32Iv5jv06n07p7SEsmBNJbIpLkQdeqraxaalJzWe8MLDtFA9suNYUvqbg56/ukY/HFdGPdT7VMRNG8/iH7UnSRVAL6y/k31oCVxXgfbNrfPxG/60pGpKjy7W/1pvScMvBpkBM1NKwOvLuG99i8Qcn8U3iCKfM6WU3h8P9k9u lyER3e/f tX0tfCf/uWeBnZxTUPfoMQeiHHTlnCLlBj7jEyKWTMgHXP2OsJ0gjqAlz4MUkQfIcUGiGVPHIVZd48gXOy+kzfej/P+qMryidu54fPsgIY5KhlS+ciqEpqKbhwd9T5JrkkzOT30ATpL+68RdrNmbrqw5Wk19jsQEpMxXxP1pbg0WMA3RCnGKzCwanHFV5+XzMLrmfbMrZ2MwxAXhWoGqsjv5s2slZfu5+9KgAC19RDjORlMCqx/zXBlSTfNFsoqUfTizX6RYC8ITz0EjJbyJtF9JOzZP287MV8vBBEWr5XGYIcCB3ofFS/kKJ725ToQY4cQ2OQ7K9WUlTziA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The tried_regions directory can be used for retrieving the monitoring results snapshot for regions of specific access pattern, by setting the scheme's action as 'stat' and the access pattern as required. While the interface provides every detail of the monitoring results, some use cases including working set size monitoring requires only the total size of the regions. For such cases, users should read all the information and calculate the total size of the regions. However, it could incur high overhead if the number of regions is high. Add a file for retrieving only the information, namely 'total_bytes' file. It allows users to get the total size by reading only the file. Signed-off-by: SeongJae Park --- mm/damon/sysfs-schemes.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c index 50cf89dcd898..6d3462eb31f2 100644 --- a/mm/damon/sysfs-schemes.c +++ b/mm/damon/sysfs-schemes.c @@ -117,6 +117,7 @@ struct damon_sysfs_scheme_regions { struct kobject kobj; struct list_head regions_list; int nr_regions; + unsigned long total_bytes; }; static struct damon_sysfs_scheme_regions * @@ -128,9 +129,19 @@ damon_sysfs_scheme_regions_alloc(void) regions->kobj = (struct kobject){}; INIT_LIST_HEAD(®ions->regions_list); regions->nr_regions = 0; + regions->total_bytes = 0; return regions; } +static ssize_t total_bytes_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + struct damon_sysfs_scheme_regions *regions = container_of(kobj, + struct damon_sysfs_scheme_regions, kobj); + + return sysfs_emit(buf, "%lu\n", regions->total_bytes); +} + static void damon_sysfs_scheme_regions_rm_dirs( struct damon_sysfs_scheme_regions *regions) { @@ -148,7 +159,11 @@ static void damon_sysfs_scheme_regions_release(struct kobject *kobj) kfree(container_of(kobj, struct damon_sysfs_scheme_regions, kobj)); } +static struct kobj_attribute damon_sysfs_scheme_regions_total_bytes_attr = + __ATTR_RO_MODE(total_bytes, 0400); + static struct attribute *damon_sysfs_scheme_regions_attrs[] = { + &damon_sysfs_scheme_regions_total_bytes_attr.attr, NULL, }; ATTRIBUTE_GROUPS(damon_sysfs_scheme_regions); @@ -1648,6 +1663,7 @@ static int damon_sysfs_before_damos_apply(struct damon_ctx *ctx, return 0; sysfs_regions = sysfs_schemes->schemes_arr[schemes_idx]->tried_regions; + sysfs_regions->total_bytes += r->ar.end - r->ar.start; region = damon_sysfs_scheme_region_alloc(r); list_add_tail(®ion->list, &sysfs_regions->regions_list); sysfs_regions->nr_regions++; @@ -1678,6 +1694,7 @@ int damon_sysfs_schemes_clear_regions( sysfs_scheme = sysfs_schemes->schemes_arr[schemes_idx++]; damon_sysfs_scheme_regions_rm_dirs( sysfs_scheme->tried_regions); + sysfs_scheme->tried_regions->total_bytes = 0; } return 0; } -- 2.25.1