From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C29D9C001E0 for ; Wed, 2 Aug 2023 19:38:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 637962801DF; Wed, 2 Aug 2023 15:38:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E7D32801AA; Wed, 2 Aug 2023 15:38:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 488F12801DF; Wed, 2 Aug 2023 15:38:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 384FA2801AA for ; Wed, 2 Aug 2023 15:38:10 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 061D0140C6F for ; Wed, 2 Aug 2023 19:38:09 +0000 (UTC) X-FDA: 81080175540.28.43C1EB9 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf27.hostedemail.com (Postfix) with ESMTP id CD8084001F for ; Wed, 2 Aug 2023 19:38:07 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LhplXH4J; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=OOAabGww; dmarc=none; spf=pass (imf27.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691005088; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hQKpatODDlYJjI5h6ON2K0Xm2qnmIDyhIc44gu3NWBE=; b=I/maDejNP5kJNqGzBWY6UPjq32ffTvDGCzQmw2yjohST5O9YQ5Wkmfbb+s6AufKotTHKCK fHiAUeyFg/BDpKMha7V7nJBnQMCXaSpNTVQfIntxkvYjpsx7jeb2Evl8Ax+Gzp1K96BW9v 5cMWnhrZb7kKsEYRM/eIQoMESbzxV+M= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LhplXH4J; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=OOAabGww; dmarc=none; spf=pass (imf27.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691005088; a=rsa-sha256; cv=none; b=GQgvq97V0G+HbZ3p+w7zGavsO22pYAWzdb+7GlxIuOL3RGbN8awxoMXTRrtSQWWka/4Vss 66VBgvetVKfcnaOv+XSIbdYdFGpdKOg+68U+c01SOGqSjLIAg9ZY7k5tXrkKnu9mROCxKa 0yimZA1hP9jh37EYSa9WNFvVH+0G6uo= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BBBB81F390; Wed, 2 Aug 2023 19:38:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1691005084; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hQKpatODDlYJjI5h6ON2K0Xm2qnmIDyhIc44gu3NWBE=; b=LhplXH4J5uUbAjgtJUQ8qRPaaSWgOUuCpAHU5WpGZ3ZAa8UXXkk/2huxZA8KHPddB0sxWg 82L3KRAWJBUdPEoSRzDYuyi9h1xUjxTNvcAYVw2CReEhTitiu/Xav/t4Oc3Djs3GIk7CnS UDsWSZfelZno+J9gahI+zq5QLWxp4pM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1691005084; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hQKpatODDlYJjI5h6ON2K0Xm2qnmIDyhIc44gu3NWBE=; b=OOAabGwwpODl/y0IYa1Ey56S8QpPiHacMq0qFwPFteERmRpVU6lGbeF0lh1V5mr0JH+VK9 pnHPb7fzF+uFUUAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9A12E1391A; Wed, 2 Aug 2023 19:38:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id kteGJZywymRaHwAAMHmgww (envelope-from ); Wed, 02 Aug 2023 19:38:04 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id EBAAAA076B; Wed, 2 Aug 2023 21:38:03 +0200 (CEST) Date: Wed, 2 Aug 2023 21:38:03 +0200 From: Jan Kara To: Jeff Layton Cc: Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Alexander Viro , Christian Brauner , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , "Darrick J. Wong" , Dave Chinner , Anthony Iliopoulos , v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v6 6/7] ext4: switch to multigrain timestamps Message-ID: <20230802193803.onjopgwdqjonzkwa@quack3> References: <20230725-mgctime-v6-0-a794c2b7abca@kernel.org> <20230725-mgctime-v6-6-a794c2b7abca@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725-mgctime-v6-6-a794c2b7abca@kernel.org> X-Rspamd-Queue-Id: CD8084001F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 31uco87z6tkkgf1gyydmpkhuth4m7emh X-HE-Tag: 1691005087-589238 X-HE-Meta: U2FsdGVkX1+QXYJNw0nLIOjKF9Ncx2/L+wnOm7O1pz8Spxo1pTGTOP6Eu1TKsfcxhLLqpSwmXpuQMYhnEJWTUw2sLbtpq4DDB9ttrFYOMJgDia6SxankmqcNd98hvDH8/E1BfoBuoD8cTEkt6aGK2D55SotN9lStZhNLOfNd9DSYXtQedV3dvZI06cqgFBeah88LyO+jaYsYufv2P7LMbBYg05WfK2kWQalBQNq70mAp2ymmldufYlnNVH/TvqZfT9wksJKy6HK3Nnj3fuhd07j4m8wTGSFCwGe2A3hLTv6FR/kfPUMFRecUNLua9RONiucmx0sGh7CuUCxyF8DRbGvRZgw7sboyLDQkUMVndD9UdD3qVEuYpGdzGqaMLA9SULhJ6SfZU3U/rg1KBLIBakI+pO+y7V/bt7MdawASJTgd/KbFxWO4BL6AIz8u1937FOFHvuvB94/oKTrOqIMkLPnrWYS9jfYYK5c96gGZL7xhH4yQ7zM+A7UI1n/eQVqq/d6o8lmOQ5mkhMlN3hW+6AvXZK00o/2OEAEONUn5/+JUhFKS4vpbGVRKpi77nnAGqDRaMhPZ+UjaLUuXXL0LbDeMEqYL/0YkxPqCEycKV0WR0tUjMF/i1pJ3HWDacM/M3xt8yDVxGW2PhkP+iwVPWj3xJ134u+jEC0kMVYHgdU7nzTI10+q2Gr69DTbiaqSyBOUAXqWp11SQbPHLjfG1DkJqRUZk0VYxUapDfHU3hLMW2MK/VEjJaWY8JB6n8T9msdrkX59R9G2tHAmPeEO6/UC3ljRn+fnvC1xsLyzm10l9Fow4piku2PNQ7KKSLv/j4mFI2/SxdUMzuXGmworL2m6WAYgC8dZ7NfibGwvVDzveU+X3ltPVi4J03zN1QK1lMT6eyIPwZebisLz+k6iemCpHR5vPIPzyfIdt1m4OUjyz9wN7ZdkainFMI0424UH7GpqW8wZpbyiVgTUYXH7 OYCoKdhk Ud3V8oEYFwOAqFFX/SmHmBCnaCQxjEAgHYWanPPthscE7mtJE3pa8Qv1ilX7SyI4BtBQGCCu9uKp//dtjmzR8zkvJ4Cyv3ceRVTnTzAE/L3hDgyt0kCPSku6ZWmMbpSNoPpzeR5amuTpJ0szWWdlb73HFhnUAKxFm4blKgS+9oWM47Ts81OGlLGkDaZ5j5wHJ5gznjGYeGN6ClbMcv9aUk6CYbEJlWiCtnmfvk/iKmm+G2wanD0+qjs58Abj5u8rq+Lhf7TmekpRjdIwwEeluvJOFzUi5fNJRUyiHpWzSX8SuZKI+OvYhNdCQsw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 25-07-23 10:58:19, Jeff Layton wrote: > Enable multigrain timestamps, which should ensure that there is an > apparent change to the timestamp whenever it has been written after > being actively observed via getattr. > > For ext4, we only need to enable the FS_MGTIME flag. > > Signed-off-by: Jeff Layton Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/ext4/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index b54c70e1a74e..cb1ff47af156 100644 > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -7279,7 +7279,7 @@ static struct file_system_type ext4_fs_type = { > .init_fs_context = ext4_init_fs_context, > .parameters = ext4_param_specs, > .kill_sb = kill_block_super, > - .fs_flags = FS_REQUIRES_DEV | FS_ALLOW_IDMAP, > + .fs_flags = FS_REQUIRES_DEV | FS_ALLOW_IDMAP | FS_MGTIME, > }; > MODULE_ALIAS_FS("ext4"); > > > -- > 2.41.0 > -- Jan Kara SUSE Labs, CR