From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FD2CC04A94 for ; Wed, 2 Aug 2023 19:37:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CFF82801DE; Wed, 2 Aug 2023 15:37:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 858E82801AA; Wed, 2 Aug 2023 15:37:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D2D22801DE; Wed, 2 Aug 2023 15:37:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5B72E2801AA for ; Wed, 2 Aug 2023 15:37:49 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2A7BC1A07DD for ; Wed, 2 Aug 2023 19:37:49 +0000 (UTC) X-FDA: 81080174658.29.0CD471E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf07.hostedemail.com (Postfix) with ESMTP id BA53640016 for ; Wed, 2 Aug 2023 19:37:46 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=UU3Tm3G6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NX6MG0fd; spf=pass (imf07.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691005067; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hej32SUQUL4wq5J7Js3JkDxcXNHsWA1VwQ0tN8Q+liI=; b=Ykyzmvx2EYY76NLCD6qjk4MGsk89zfx0BXHieCg5/KcozPaE1xYbkcdefOtM7CAYKsUb// ECzR/D/rZLzn3+6VZaIltPTFHbpduZo1EoTtbTvDEQK4RT9vVZBuYmxuJaX9lMzuqw2nhR WeeR6MTuoAdqEp3lawGkidWcHO3xWsU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691005067; a=rsa-sha256; cv=none; b=LM59n+9tgGuh4MD0i4USr0M9qtHDa4LuBDWPOGi+CDmZFPjCVtYdyCetVKZLbBi5JW0T9O vEhqiOM9YsqGpRTxHI14DuyWzb1kEWMok4ZEVSxL8EHAMt4va7sARjR5khfnbIIzY+jsyz TDiwqukKL2fiRrQ3q8Ynzi7x5xmcNvc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=UU3Tm3G6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=NX6MG0fd; spf=pass (imf07.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DCAD821A35; Wed, 2 Aug 2023 19:37:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1691005064; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hej32SUQUL4wq5J7Js3JkDxcXNHsWA1VwQ0tN8Q+liI=; b=UU3Tm3G6FjCiIipHgljAOgzfMZUvjNWSdsYJJguFbMcYv2scO9r7dcYFw5uMe9CC4Ad2Qy FUudTxu/2yivhdo/UZ5ja6uq7Y8xdfcD076CUCQw9ZWJtvqXlN1rOkolKNpsEKUGhppUdv mjpPxkrZ0aUM04DZ+ksCa0CPDmtuXDE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1691005064; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hej32SUQUL4wq5J7Js3JkDxcXNHsWA1VwQ0tN8Q+liI=; b=NX6MG0fdteUMkKXyD+4G36a30wQWbVAM4a8TsTJKCdzWP/Zccm95SaZr1qpnKF7LvVwXes KKCtU/rORrmysuAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 973B01391A; Wed, 2 Aug 2023 19:37:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 1UjoJIiwymQKHwAAMHmgww (envelope-from ); Wed, 02 Aug 2023 19:37:44 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id B8B08A076B; Wed, 2 Aug 2023 21:37:43 +0200 (CEST) Date: Wed, 2 Aug 2023 21:37:43 +0200 From: Jan Kara To: Jeff Layton Cc: Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Alexander Viro , Christian Brauner , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , "Darrick J. Wong" , Dave Chinner , Anthony Iliopoulos , v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v6 4/7] tmpfs: add support for multigrain timestamps Message-ID: <20230802193743.3nomcrox6pqhsc5x@quack3> References: <20230725-mgctime-v6-0-a794c2b7abca@kernel.org> <20230725-mgctime-v6-4-a794c2b7abca@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725-mgctime-v6-4-a794c2b7abca@kernel.org> X-Rspamd-Queue-Id: BA53640016 X-Rspam-User: X-Stat-Signature: yenkre7rw7qrny3zaw3wnbciqs9sip17 X-Rspamd-Server: rspam03 X-HE-Tag: 1691005066-6640 X-HE-Meta: U2FsdGVkX19tP8gWhHK0NcS2IJrGilmUHU5iH4sDfZXMCK5nKXwzYzn3nF1MPQoVRp1K4aVHqNxox3bPQV5X8EGX0veN34pi3BYxQXOM7FQ3ltPy5X5ES9YPPl0oKZ2bSnnpQ4cDtEw0QZYK236oOV79ndKAHJBc6tWw6HEcWS1r0BVjBsSxDcQON8euALkcmLUXivOigADCnAzkwBTnrMrlI303YtCxk6Ux5iadY367lIyaZ02CUNuZbfZvBlTewO2afJPe+tHFTIDd8f4eJCTLc3GbYCY29TNv4UX2TM8PDF9MzrxDdgtaM1yCQRe96BsiTQa/57kjPLqlOBoUMqhXU3/1j1/392FTdwLV1v2BnM6O78Rc2xvhdQei1gHXbZyKTdwUq0oHJ8P/j3NXZdk+IaGeX+5xQ1VsXB8WYWTfj2HNk8k2ASnOeCMBU61yyeZsyOEAuYO4FrGlqStY44mEeX9xCq+MK2Nebpd6BEl4HyCfUTz8BdKGXtj/Ed+WdZyF7RIHfVkgjs0ARV1Gb4m7331umQnCX0UUbHIust4RqjU5NUI1+6Uji8EEFIHcBsOYJ6IDkeDn/O3BApYifs6rqxy35GHbxbhuS38PdDSlapMCIThGRUEKq0O4Zmu9iQZ+c6TH5MQ+0ydydnk7mWi3DwVm9t0o9LINoQOVC/d0pdJyW2UAk1f1q6NdP7Wsx9f30UnjOqjwIkXDcJjrYqr6BDXw4ubHqCPNpPIV1blfiQuyHNf+FREQJgFJI2Chnx2Gcp9Y29Ru2UtfYEpz0OC4Gi+1pgsW2A2GOfe8CIHK1sU+pDMKrNiNEKnQRDncTNHjMZDLqQ+PD8aiIEe38wFxyh5buu3l9dmBBvuIM/JEvEos53FX3bQdhMku8bLb1ThIXcg7LDOVen/EheQGok6tJWw2OoKY8DarYfVnDpc7J2HHr7BP2TBwp45/NxHBzO5s8hde3qBFhLwdhmG Edn2efpq fjIcGIOnV9TDOn2g2mR+zbZgEOtQGNARcSj9lq+eOGjSUNKdC4Eg/VSxfYcasZ9+ry8P58ZaXAl0FftyB8iG5vu30mtGxwwwbVx8cRFwAsY4BmLJtb+AlIbBO0WUvW5/aXu2rVyq4Se5Yf5t+QAUWmOYsZ2Mnl+z5BHXa4RBcxNl+PXOD+85G8MZL9AzrmFMHrwvjyMu0109WDzUZTUEnFSBtc7p9YDNQnKkHKBiF4gK6S9IusK59PpvH/2sFNUfv1IIJSJzWNwDH1KWxYp9KQzEN+1RIBMSV7lBiYd1xD5HTsw696WSxdk2NQQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 25-07-23 10:58:17, Jeff Layton wrote: > Enable multigrain timestamps, which should ensure that there is an > apparent change to the timestamp whenever it has been written after > being actively observed via getattr. > > tmpfs only requires the FS_MGTIME flag. > > Signed-off-by: Jeff Layton Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > mm/shmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 654d9a585820..b6019c905058 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -4264,7 +4264,7 @@ static struct file_system_type shmem_fs_type = { > #endif > .kill_sb = kill_litter_super, > #ifdef CONFIG_SHMEM > - .fs_flags = FS_USERNS_MOUNT | FS_ALLOW_IDMAP, > + .fs_flags = FS_USERNS_MOUNT | FS_ALLOW_IDMAP | FS_MGTIME, > #else > .fs_flags = FS_USERNS_MOUNT, > #endif > > -- > 2.41.0 > -- Jan Kara SUSE Labs, CR