From: Levi Yun <ppbuk5246@gmail.com>
To: rppt@kernel.org, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Levi Yun <ppbuk5246@gmail.com>
Subject: [PATCH] mm/mm_init: Ignore kernelcore=mirror boot option when no mirror memory presents.
Date: Wed, 2 Aug 2023 19:36:14 +0100 [thread overview]
Message-ID: <20230802183614.15520-1-ppbuk5246@gmail.com> (raw)
In the machine where no mirror memory is set,
All memory region in ZONE_NORMAL is used as ZONE_MOVABLE
when kernelcore=mirror boot option is used.
So, ZONE_NORMAL couldn't be populated properly
because all of ZONE_NORMAL pages is absent.
To avoid this abnormal situation,
ignore disable kernelcore=mirror option when no mirror memory is found.
Signed-off-by: Levi Yun <ppbuk5246@gmail.com>
---
mm/mm_init.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/mm/mm_init.c b/mm/mm_init.c
index a1963c3322af..4c180ef1a993 100644
--- a/mm/mm_init.c
+++ b/mm/mm_init.c
@@ -376,10 +376,13 @@ static void __init find_zone_movable_pfns_for_nodes(void)
*/
if (mirrored_kernelcore) {
bool mem_below_4gb_not_mirrored = false;
+ bool no_mirror_mem = true;
for_each_mem_region(r) {
- if (memblock_is_mirror(r))
+ if (memblock_is_mirror(r)) {
+ no_mirror_mem = false;
continue;
+ }
nid = memblock_get_region_node(r);
@@ -398,6 +401,12 @@ static void __init find_zone_movable_pfns_for_nodes(void)
if (mem_below_4gb_not_mirrored)
pr_warn("This configuration results in unmirrored kernel memory.\n");
+ if (no_mirror_mem) {
+ pr_warn("There is no mirrored memory. Ignore kernelcore=mirror.\n");
+ mirrored_kernelcore = false;
+ memset(zone_movable_pfn, 0x00, sizeof(zone_movable_pfn));
+ }
+
goto out2;
}
--
2.37.2
reply other threads:[~2023-08-02 18:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230802183614.15520-1-ppbuk5246@gmail.com \
--to=ppbuk5246@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox